Re: [PHP-DEV] [RFC] IntlCharsetDetector

On 4/26/16 12:10 PM, Sara Golemon wrote: On Tue, Apr 26, 2016 at 2:06 AM, Yasuo Ohgaki wrote: Things might have been changed, but as you've mentioned encoding detection is unstable and ICU is poor compared to mbstring's detection at least for Japanese encodings. For me,

Re: [PHP-DEV] [RFC] IntlCharsetDetector

Hi Sara, On Wed, Apr 27, 2016 at 1:10 AM, Sara Golemon wrote: > On Tue, Apr 26, 2016 at 2:06 AM, Yasuo Ohgaki wrote: >> Things might have been changed, but as you've mentioned encoding >> detection is unstable and ICU is poor compared to mbstring's detection

Re: [PHP-DEV] [RFC] IntlCharsetDetector

Hi! > For me, the difference is that I expect further work to be done on > improving ICU, while I lack that confidence for mbstring. If the API My experience over the years has been that established supported libraries like ICU usually have better track record in improving and maintenance than

Re: [PHP-DEV] [RFC] IntlCharsetDetector

On Tue, Apr 26, 2016 at 2:06 AM, Yasuo Ohgaki wrote: > Things might have been changed, but as you've mentioned encoding > detection is unstable and ICU is poor compared to mbstring's detection > at least for Japanese encodings. > For me, the difference is that I expect further

Re: [PHP-DEV] [RFC] IntlCharsetDetector

Hi Sara, On Tue, Apr 12, 2016 at 7:54 AM, Sara Golemon wrote: > With a light push from Stas, I've decided to go ahead and put up > IntlCharsetDetector for discussion. > https://wiki.php.net/rfc/intl.charset-detector > > I'm still not personally convinced this API is trustworthy

Re: [PHP-DEV] [RFC] IntlCharsetDetector

On Mon, 11 Apr 2016, Sara Golemon wrote: > With a light push from Stas, I've decided to go ahead and put up > IntlCharsetDetector for discussion. > https://wiki.php.net/rfc/intl.charset-detector > > I'm still not personally convinced this API is trustworthy enough, but > it's worth a formal

Re: [PHP-DEV] [RFC] IntlCharsetDetector

On 4/12/2016 1:25 AM, Sara Golemon wrote: > On Mon, Apr 11, 2016 at 4:09 PM, Stanislav Malyshev > wrote: >> The API looks a bit strange - new IntlCharsetDetector($text) and then >> detect(). Can't we just have detect([$text])? >> > I went with a direct wrapping of the

Re: [PHP-DEV] [RFC] IntlCharsetDetector

Hi! > That said, how do you feel about compromising by adding this function > in addition to the raw API? > > function ucsdet_detect_encoding(string $text, string $hint = null, > bool $filter = false) { > $det = new IntlCharsetDetector($text); > if ($hint !== null) { >

Re: [PHP-DEV] [RFC] IntlCharsetDetector

On Mon, Apr 11, 2016 at 4:09 PM, Stanislav Malyshev wrote: > The API looks a bit strange - new IntlCharsetDetector($text) and then > detect(). Can't we just have detect([$text])? > I went with a direct wrapping of the underlying API because it always feels like we regret

Re: [PHP-DEV] [RFC] IntlCharsetDetector

Hi! > With a light push from Stas, I've decided to go ahead and put up > IntlCharsetDetector for discussion. > https://wiki.php.net/rfc/intl.charset-detector > > I'm still not personally convinced this API is trustworthy enough, but > it's worth a formal discussion period at least. The API

[PHP-DEV] [RFC] IntlCharsetDetector

With a light push from Stas, I've decided to go ahead and put up IntlCharsetDetector for discussion. https://wiki.php.net/rfc/intl.charset-detector I'm still not personally convinced this API is trustworthy enough, but it's worth a formal discussion period at least. -Sara -- PHP Internals -