Re: [PHP-DEV] [VOTE]: Change Default mysqli Error Mode

2021-02-28 Thread Craig Francis
On Sun, 28 Feb 2021 at 17:06, Kamil Tekiela wrote: > if someone has a proposal on how to introduce a deprecation phase > If the extra step is necessary... I liked Nikita's suggestion to "issue a deprecation warning when creating a connection without mysqli_report() having been explicitly called

Re: [PHP-DEV] [VOTE]: Change Default mysqli Error Mode

2021-02-28 Thread Kamil Tekiela
Hi Internals, The RFC was accepted with 20 Yes and 9 No votes. During the voting phase, a discussion has arisen whether this change should land in PHP 8.1 or 8.2 following a deprecation phase. At present, the RFC was accepted to include it in 8.1, but if someone has a proposal on how to introduce

Re: [PHP-DEV] [VOTE]: Change Default mysqli Error Mode

2021-02-23 Thread Johannes Schlüter
Hi, On Wed, 2021-02-10 at 23:35 +, Kamil Tekiela wrote: > I have started voting on > https://wiki.php.net/rfc/mysqli_default_errmode > The voting period is 2020-02-11 -- 2020-02-28 Sorry, I didn't see this before. I agree that Exceptions are the way to go and it were good if that had been d

Re: [PHP-DEV] [VOTE]: Change Default mysqli Error Mode

2021-02-23 Thread Benjamin Eberlei
On Thu, Feb 11, 2021 at 12:36 AM Kamil Tekiela wrote: > Hi internals, > > I have started voting on https://wiki.php.net/rfc/mysqli_default_errmode > The voting period is 2020-02-11 -- 2020-02-28 > While the change in itself is something I want to see, I voted no on this proposal because its a BC

Re: [PHP-DEV] [VOTE]: Change Default mysqli Error Mode

2021-02-12 Thread Craig Francis
On 12 Feb 2021, at 15:17, Christian Schneider wrote: > > Am 12.02.2021 um 15:30 schrieb Craig Francis : >> Switching the default from `OFF` to `ERROR` to `ERROR | STRICT` isn't an >> obvious step, as that still means you're still having a single step to >> change from error reporting to excepti

Re: [PHP-DEV] [VOTE]: Change Default mysqli Error Mode

2021-02-12 Thread Christian Schneider
Am 12.02.2021 um 15:30 schrieb Craig Francis : > Switching the default from `OFF` to `ERROR` to `ERROR | STRICT` isn't an > obvious step, as that still means you're still having a single step to change > from error reporting to exceptions. It is the usual step for (almost) all BC breaking change

Re: [PHP-DEV] [VOTE]: Change Default mysqli Error Mode

2021-02-12 Thread Craig Francis
On 12 Feb 2021, at 08:45, Peter Bowyer wrote: > On Thu, 11 Feb 2021 at 13:31, Christian Schneider > wrote: > >> [...] If there would have been an intermediate PHP version with default >> MYSQLI_REPORT_ERROR I would have voted "Yes", but in the current form I >> have to say "No". >> > > I vote

Re: [PHP-DEV] [VOTE]: Change Default mysqli Error Mode

2021-02-12 Thread Peter Bowyer
On Thu, 11 Feb 2021 at 13:31, Christian Schneider wrote: > For the record: I do not think the wording fo the "Backward Incompatible > Changes" section is appropriate, especially the *only* in "To bring back > the old behaviour one needs to add only this line before instantiating > mysqli class".

Re: [PHP-DEV] [VOTE]: Change Default mysqli Error Mode

2021-02-11 Thread Christian Schneider
Am 11.02.2021 um 00:35 schrieb Kamil Tekiela : > I have started voting on https://wiki.php.net/rfc/mysqli_default_errmode > The voting period is 2020-02-11 -- 2020-02-28 For the record: I do not think the wording fo the "Backward Incompatible Changes" section is appropriate, especially the *only*

[PHP-DEV] [VOTE]: Change Default mysqli Error Mode

2021-02-10 Thread Kamil Tekiela
Hi internals, I have started voting on https://wiki.php.net/rfc/mysqli_default_errmode The voting period is 2020-02-11 -- 2020-02-28 Kind Regards, Kamil