[PHP-DEV] [VOTE] Debugging PDO Prepared Statement Emulation v2

2016-12-07 Thread Adam Baratz
Hi, A little over two weeks have passed since posting this RFC: https://wiki.php.net/rfc/debugging_pdo_prepared_statement_emulation_v2 There's been some discussion on this list: http://marc.info/?l=php-internals&m=148034706404511&w=2 Discussion has cooled off, so I'd like to open to a vote. Voti

Re: [PHP-DEV] [VOTE] Debugging PDO Prepared Statement Emulation

2016-11-21 Thread Stanislav Malyshev
Hi! On 11/16/16 3:06 PM, Adam Baratz wrote: > Hi, > > No, you're not misreading the subject line. I began working on the docs for > the previously accepted proposal and became uncomfortable with the > approach. I think it will be better to integrate this info into > PDOStatement::debugDumpParams(

Re: [PHP-DEV] [VOTE] Debugging PDO Prepared Statement Emulation

2016-11-17 Thread Adam Baratz
> > Once the proposal had been accepted, and merged, it's not really > legitimate to unilaterally decide that it's a bad implementation and revert > it yourself. > That's fair. I will revert the revert and open a new RFC to supersede the previous one. Thanks again for your patience. Adam

Re: [PHP-DEV] [VOTE] Debugging PDO Prepared Statement Emulation

2016-11-16 Thread Joe Watkins
Morning Adam, Once the proposal had been accepted, and merged, it's not really legitimate to unilaterally decide that it's a bad implementation and revert it yourself. In addition, what we are looking at is a new RFC, that uses some of the same words as the old one, but a different approach and a

[PHP-DEV] [VOTE] Debugging PDO Prepared Statement Emulation

2016-11-16 Thread Adam Baratz
Hi, No, you're not misreading the subject line. I began working on the docs for the previously accepted proposal and became uncomfortable with the approach. I think it will be better to integrate this info into PDOStatement::debugDumpParams(). It will let me do the testing I want to do without int

[PHP-DEV] [VOTE] Debugging PDO Prepared Statement Emulation

2016-10-31 Thread Adam Baratz
Hi, Two weeks have passed since posting this RFC: https://wiki.php.net/rfc/debugging_pdo_prepared_statement_emulation There's been some discussion on this list: http://marc.info/?l=php-internals&m=147638162506291&w=2 http://marc.info/?l=php-internals&m=147734024403899&w=2 http://marc.info/?l=php-