Re: [PHP-DEV] [VOTE] Deprecations for PHP 7.3

2018-07-10 Thread Niklas Keller
I put that item onto the list. The author of https://github.com/mikey179/bovigo-assert originally had the issue that a function named `assert` behaves really weird. `assert()` in namespaced code might refer to the namespaced `assert()` function, but might also fall back to the global `assert()`. W

Re: [PHP-DEV] [VOTE] Deprecations for PHP 7.3

2018-07-09 Thread Sara Golemon
On Mon, Jul 9, 2018 at 11:18 AM, Levi Morrison wrote: > Can you prove this somehow? Based on how `use function my\assert;` > works a call to `assert()` later in that file should appear to engine > as `my\assert`, not `assert`. > The vote is on deprecating (and ultimately blocking) the *declaration

Re: [PHP-DEV] [VOTE] Deprecations for PHP 7.3

2018-07-09 Thread Levi Morrison
On Mon, Jul 9, 2018 at 8:43 AM Sara Golemon wrote: > > On Mon, Jul 9, 2018 at 5:57 AM, Marco Pivetta wrote: > > Something unclear to me here: is the removal of `assert()` affecting also > > my own`my\assert()` (imported via `use function`)? > > > Yes, but in fairness, your namespaced assert funct

Re: [PHP-DEV] [VOTE] Deprecations for PHP 7.3

2018-07-09 Thread Marco Pivetta
Alright, voted "NO" on that one then - namespaced stuff should have whichever symbol name without colliding with internals Marco Pivetta http://twitter.com/Ocramius http://ocramius.github.com/ On Mon, Jul 9, 2018 at 4:42 PM, Sara Golemon wrote: > On Mon, Jul 9, 2018 at 5:57 AM, Marco Pivetta

Re: [PHP-DEV] [VOTE] Deprecations for PHP 7.3

2018-07-09 Thread Sara Golemon
On Mon, Jul 9, 2018 at 5:57 AM, Marco Pivetta wrote: > Something unclear to me here: is the removal of `assert()` affecting also > my own`my\assert()` (imported via `use function`)? > Yes, but in fairness, your namespaced assert function is already a bit broken if you're not expecting it to be eli

Re: [PHP-DEV] [VOTE] Deprecations for PHP 7.3

2018-07-09 Thread Marco Pivetta
Something unclear to me here: is the removal of `assert()` affecting also my own`my\assert()` (imported via `use function`)? Marco Pivetta http://twitter.com/Ocramius http://ocramius.github.com/ On Mon, Jul 9, 2018 at 10:47 AM, Nikita Popov wrote: > Hi, > > I would like to start voting on the

[PHP-DEV] [VOTE] Deprecations for PHP 7.3

2018-07-09 Thread Nikita Popov
Hi, I would like to start voting on the "Deprecation for PHP 7.3" RFC, which combines six minor deprecation proposals: https://wiki.php.net/rfc/deprecations_php_7_3 Each deprecation is voted separately and will require a 2/3 majority independently of whether it is a language or library change. T