Re: [PHP-DEV] Dedicated StreamBucket class

2024-01-19 Thread James Titcumb
On Fri, 19 Jan 2024 at 16:04, Sara Golemon wrote: > > No disrespect to all the folks (including myself) who had a part in file > I/O as it exists today, but it *IS* a hot mess. I've sketched out > redesigns with folks over the years, but I have to be honest that I don't > have the spoons to

Re: [PHP-DEV] Dedicated StreamBucket class

2024-01-19 Thread Sara Golemon
On Sat, Jan 13, 2024 at 1:29 AM Máté Kocsis wrote: > Recently, I realized that the stream_bucket_new() and > stream_bucket_make_writeable() functions > create stdClass instances by dynamically adding a "bucket", a "data" and a > "datalen" property to it. > I don't want to stand in the way of

Re: [PHP-DEV] Dedicated StreamBucket class

2024-01-19 Thread Máté Kocsis
Hi Jakub, > The only issue that I see that if you migrate the resource to object you > effectively drop that property which might be a BC break but based on the > recent RFC results it will happen in PHP 9.0 so it's not such a big issue. > I think this might be actually an opportunity to

Re: [PHP-DEV] Dedicated StreamBucket class

2024-01-19 Thread Jakub Zelenka
Hi, On Wed, Jan 17, 2024 at 9:14 PM Máté Kocsis wrote: > I just submitted feedback to the PR but will also mention it here as it's >> probably more an API thing. The problem that I see is that it combines two >> distinct things and create quite ugly self reference inside the proposed >>

Re: [PHP-DEV] Dedicated StreamBucket class

2024-01-17 Thread Máté Kocsis
Hi Jakub, I just submitted feedback to the PR but will also mention it here as it's > probably more an API thing. The problem that I see is that it combines two > distinct things and create quite ugly self reference inside the proposed > StreamBucket object. I would prefer we split it and

Re: [PHP-DEV] Dedicated StreamBucket class

2024-01-13 Thread Jakub Zelenka
Hi, On Sat, Jan 13, 2024 at 9:29 AM Máté Kocsis wrote: > Hi Everyone, > > Recently, I realized that the stream_bucket_new() and > stream_bucket_make_writeable() functions > create stdClass instances by dynamically adding a "bucket", a "data" and a > "datalen" property to it. > > A few days ago,

[PHP-DEV] Dedicated StreamBucket class

2024-01-13 Thread Máté Kocsis
Hi Everyone, Recently, I realized that the stream_bucket_new() and stream_bucket_make_writeable() functions create stdClass instances by dynamically adding a "bucket", a "data" and a "datalen" property to it. A few days ago, I submitted a PR which makes the above mentioned functions return a