Re: [PHP-DEV] Deprecated functions

2014-09-14 Thread Stas Malyshev
Hi! > The above are, as far as I’m concerned, all potential candidates for > removal in PHP 7, so in order to reliably test a deprecated function > I would suggest introducing a hidden function with this signature: > > void __deprecated__() { } > > And mark that function as eternally deprecated

Re: [PHP-DEV] Deprecated functions

2014-09-10 Thread Chris Wright
On 10 September 2014 06:42, Tjerk Meesters wrote: > Hi, > > When I was fixing test cases on my `kill-ereg` branch I noticed a Reflection > test case for `ReflectionFunction::isDeprecated()`. > > The problem with such a test case is that you’d be chasing deprecated > functions to tests against as

Re: [PHP-DEV] Deprecated functions

2014-09-10 Thread Matteo Beccati
On 10/09/2014 07:42, Tjerk Meesters wrote: > void __deprecated__() { } > > And mark that function as eternally deprecated using the ZEND_ACC_DEPRECATED > flag. Is it really worth adding a new completely useless function just for a test? It's not like functions are actually removed every day...

Re: [PHP-DEV] Deprecated functions

2014-09-10 Thread Tjerk Meesters
Hi Alex, On 10 Sep 2014, at 13:59, Alexander Lisachenko wrote: > Hi! > > Maybe it will be better to do this in another way: introduce an RFC to > add 'deprecated' keyword into the syntax like 'final' or 'protected'. > There are many frameworks that want to deprecate some methods or > classes. C

Re: [PHP-DEV] Deprecated functions

2014-09-09 Thread Alexander Lisachenko
Hi! Maybe it will be better to do this in another way: introduce an RFC to add 'deprecated' keyword into the syntax like 'final' or 'protected'. There are many frameworks that want to deprecate some methods or classes. Currently it's only possible via "@deprecated" tag in the phpDoc-block, but thi

Re: [PHP-DEV] Deprecated functions

2014-09-09 Thread Levi Morrison
On Tue, Sep 9, 2014 at 11:42 PM, Tjerk Meesters wrote: > Hi, > > When I was fixing test cases on my `kill-ereg` branch I noticed a Reflection > test case for `ReflectionFunction::isDeprecated()`. > > The problem with such a test case is that you’d be chasing deprecated > functions to tests again

[PHP-DEV] Deprecated functions

2014-09-09 Thread Tjerk Meesters
Hi, When I was fixing test cases on my `kill-ereg` branch I noticed a Reflection test case for `ReflectionFunction::isDeprecated()`. The problem with such a test case is that you’d be chasing deprecated functions to tests against as we move along; this is the current list of deprecated functio