Re: [PHP-DEV] PDO Subclasses coming to vote soon.

2023-06-29 Thread BohwaZ
> Yes? > > I think you possibly misread my email. Ah! sorry I understood the opposite, that you were wondering about letting people load extensions from SQL. Great that we are on the same note :) > Sorry, I am in too much pain to look at those before the deadline. > There is always 8.4 https://w

Re: [PHP-DEV] PDO Subclasses coming to vote soon.

2023-06-29 Thread Dan Ackroyd
On Thu, 29 Jun 2023 at 11:40, BohwaZ wrote: > > I'm sorry to disagree, but changing this would be a bad idea for > security. > > I'm quite sure that I never want users to be able to load any > extension through SQL, or it would mean trouble :( > > So just like in the SQLite3 extension, extension l

Re: [PHP-DEV] PDO Subclasses coming to vote soon.

2023-06-29 Thread BohwaZ
> As that means that SQLite extensions can only be loaded through C code > (not through SQL), and if someone can upload and execute code to your > server, your server is compromised anyway, having to edit ini files to > enable extension loading, seems like a bad tradeoff. I'm sorry to disagree, bu

Re: [PHP-DEV] PDO Subclasses coming to vote soon.

2023-06-27 Thread Larry Garfield
On Tue, Jun 27, 2023, at 5:20 PM, Dan Ackroyd wrote: > On Tue, 27 Jun 2023 at 17:25, Larry Garfield wrote: >> >> The RFC doesn't specify if `new PDO(...)` changes behavior at all. > > That behaviour is not changed at all. > >> will PDO still have the postgres methods > > Yes, until someone does an

Re: [PHP-DEV] PDO Subclasses coming to vote soon.

2023-06-27 Thread Dan Ackroyd
On Tue, 27 Jun 2023 at 17:25, Larry Garfield wrote: > > The RFC doesn't specify if `new PDO(...)` changes behavior at all. That behaviour is not changed at all. > will PDO still have the postgres methods Yes, until someone does another RFC to deprecate and remove them. > if someone does [`new

Re: [PHP-DEV] PDO Subclasses coming to vote soon.

2023-06-27 Thread Larry Garfield
On Tue, Jun 27, 2023, at 1:49 PM, Dan Ackroyd wrote: > Hi everyone, > > Just giving an update on the > https://wiki.php.net/rfc/pdo_driver_specific_subclasses RFC as time is > running out. The RFC text has been updated with the implemented > subclasses stubs. The RFC doesn't specify if `new PDO(..

[PHP-DEV] PDO Subclasses coming to vote soon.

2023-06-27 Thread Dan Ackroyd
Hi everyone, Just giving an update on the https://wiki.php.net/rfc/pdo_driver_specific_subclasses RFC as time is running out. The RFC text has been updated with the implemented subclasses stubs. There are a few small things to note, and one larger thing: Marc Bennewitz wrote: > It would be great