RE: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

llet > <r...@fedoraproject.org>; internals@lists.php.net; Yasuo Ohgaki > <yohg...@php.net> > Subject: Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - BC break > *** > > Hi Anatol, > > On Wed, Jan 27, 2016 at 6:28 PM, Anatol Belski <anatol@belski.net&

RE: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

gmail.com> > Subject: RE: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - BC break > *** > The fails in Symfony seems to be caused by > ff7ed9021cd72a7f82dd4301cdc266afdff458ad, but also the corresponding > places in Symfony seems a bit odd with %f format for a string &g

RE: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

Hi, I can check early next week, I'm almost AFK currently. Thanks, Nicolas

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

Hi all and Stas, On Wed, Jan 27, 2016 at 3:53 PM, Stanislav Malyshev wrote: >> The Horde_SessionHandler test suite still fail differently: Both >> are related to "getSessionIDs" (which list active sessions) > > Any way to get a short repro script for that too? > > In

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

Hi Anatol, On Wed, Jan 27, 2016 at 5:06 PM, Anatol Belski wrote: > Thanks for all the investigation (as well Remi, Stas and everyone). At first > glance last week, as for me, it looked like OK to keep at least the 7.0 part, > as the breach was only concerning the unit

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Using 2 patches: https://gist.github.com/smalyshev/4d8435b7993bef80c0ed https://gist.github.com/yohgaki/c3783b22bae9dcb78d69 $ /work/build/php56/sapi/cli/php /usr/bin/phpunit - --include-path=/usr/share/pear . PHPUnit 5.1.4 by Sebastian Bergmann

RE: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

@lists.php.net; Yasuo > Ohgaki <yohg...@php.net> > Subject: Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - BC break > *** > > Hi Stas, > > On Wed, Jan 27, 2016 at 2:45 PM, Stanislav Malyshev <smalys...@gmail.com> > wrote: > >> Note for thi

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

Hi Anatol, On Wed, Jan 27, 2016 at 6:28 PM, Anatol Belski wrote: > If you're willing to work on fixing BC breaches till next minor RC, it might > be the way to proceed. If on the next RC we see no signs of regression, so we > could take it into the next minor. Otherwise,

RE: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

llet > <r...@fedoraproject.org>; internals@lists.php.net; Yasuo Ohgaki > <yohg...@php.net> > Subject: Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - BC break > *** > > Hi Anatol, > > On Wed, Jan 27, 2016 at 5:06 PM, Anatol Belski <anatol@belski

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

On Jan 26, 2016 4:02 AM, "Yasuo Ohgaki" wrote: > > Hi Remi and all, > > On Fri, Jan 22, 2016 at 1:20 AM, Remi Collet wrote: > > Fedora detected a BC break in 5.6.18RC1 and 7.0.3RC1 related to > > session management. > > > > This update breaks: > > > >

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

Hi! > The Horde_SessionHandler test suite still fail differently: Both > are related to "getSessionIDs" (which list active sessions) Any way to get a short repro script for that too? In general, I start to be more and more doubtful about the idea of messing with sessions in stable versions. --

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

Hi Remi, On Wed, Jan 27, 2016 at 3:32 PM, Remi Collet wrote: > > There were 2 failures: > > 1) Horde_SessionHandler_Storage_BuiltinTest::testGc > Failed asserting that two arrays are equal. > - --- Expected > +++ Actual > @@ @@ > Array ( > +0 =>

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

Hi Stas, On Wed, Jan 27, 2016 at 2:45 PM, Stanislav Malyshev wrote: >> Note for this issue. >> The change does not breaks normal codes as PHP cannot set new session >> ID when header is already sent. The session is _not_ accessible >> anyway. Not writing orphaned session

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

Hi all, On Wed, Jan 27, 2016 at 12:28 PM, Yasuo Ohgaki wrote: >> Note for this issue. >> The change does not breaks normal codes as PHP cannot set new session >> ID when header is already sent. The session is _not_ accessible >> anyway. Not writing orphaned session does not

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

Hi! > Note for this issue. > The change does not breaks normal codes as PHP cannot set new session > ID when header is already sent. The session is _not_ accessible > anyway. Not writing orphaned session does not matter at all. So it looks like this particular breakage is because write does not

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 27/01/2016 06:45, Stanislav Malyshev a écrit : > Yes, this patch: > https://gist.github.com/smalyshev/4d8435b7993bef80c0ed fixes it for > me. Remi, could you check that it also fixes the failures in the > test suites? I confirm it fix the unit

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

> > > > This is added because when session cannot be started, then it should > fail. > > This fix is related to https://bugs.php.net/bug.php?id=71243 > > The php_session_abort() is not directly related to this bug, but this > (and > > other fixes) is added because session_start() returns TRUE even

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

Hi! >> It seems that using a user land SessionHandler, the "write" method >> is not called, raising this issue. > > Attached as .phpt Bisecting with this test shows a15e9ccba8a34553c029fb4574edba87c76447e5 as the breaking change. So we need to either fix it (this week, as next week it should be

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

Hi all, On Wed, Jan 27, 2016 at 11:04 AM, Stanislav Malyshev wrote: > >>> It seems that using a user land SessionHandler, the "write" method >>> is not called, raising this issue. >> >> Attached as .phpt > > Bisecting with this test shows

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

Hi all, On Wed, Jan 27, 2016 at 12:19 PM, Yasuo Ohgaki wrote: > > On Wed, Jan 27, 2016 at 11:04 AM, Stanislav Malyshev > wrote: >> It seems that using a user land SessionHandler, the "write" method is not called, raising this issue. >>> >>>

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

Hi Remi and all, On Fri, Jan 22, 2016 at 1:20 AM, Remi Collet wrote: > Fedora detected a BC break in 5.6.18RC1 and 7.0.3RC1 related to > session management. > > This update breaks: > > Horde_SessionHandler (2.2.6) and symfony (2.7.9) Thank you for notifying issue. Remi

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

Hi Remi, On Fri, Jan 22, 2016 at 7:38 PM, Remi Collet wrote: > > It seems that using a user land SessionHandler, the "write" method is > not called, raising this issue. Thank you. I'll check it soon. (in a few days) I'm not sure what's causing it now, but I'll find it

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

Hi Remi, On Mon, Jan 25, 2016 at 11:47 AM, Yasuo Ohgaki wrote: > > On Fri, Jan 22, 2016 at 7:38 PM, Remi Collet wrote: >> >> It seems that using a user land SessionHandler, the "write" method is >> not called, raising this issue. > > Thank you. I'll

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 25/01/2016 05:06, Yasuo Ohgaki a écrit : > As I add comments in code, session_write_close() should not do > anything but the test script assumes write/close is called? I've > tested with Fedora 23's PHP 5.6.17 and got the expected result Yes,

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Reproducer attached It seems that using a user land SessionHandler, the "write" method is not called, raising this issue. Remi. -BEGIN PGP SIGNATURE- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

Le 21/01/2016 23:07, Yasuo Ohgaki a écrit : > Patch for fixing BC would be this, if I'm correct about the cause. > > e8f1c29cc96ce333fa808aba126297b77d94abdf (main patch) > 57be57ac94ef46fa7a73889a1e7d6e75aa4ab00f (TSRM fix for PHP 5.6) > > I appreciate if you could run tests without these

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 22/01/2016 11:38, Remi Collet a écrit : > Reproducer attached > > It seems that using a user land SessionHandler, the "write" method > is not called, raising this issue. Attached as .phpt Notice: the issue only happens after the: PHP Warning:

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

Le 21/01/2016 11:53, Anatol Belski a écrit : > Hi, > > PHP 7.0.3 RC1 was just released and can be downloaded from: Fedora detected a BC break in 5.6.18RC1 and 7.0.3RC1 related to session management. This update breaks: Horde_SessionHandler (2.2.6) and symfony (2.7.9)

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

Hi! > Fedora detected a BC break in 5.6.18RC1 and 7.0.3RC1 related to > session management. Looks like something to do with last session changes. Yasuo, could you take a look at it? -- Stas Malyshev smalys...@gmail.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe,

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

Hi! > We have 2 choices > - Enforce new and correct behavior since it will not affect normal >operation. i.e. Actual production site > - Restore old behavior for the time being. (For this option, I prefer >to restore only for PHP 5.6, but Ok for PHP 7.0 also. No for master) Since it

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

HI Remi and all, The reason of this BC I can think of immediately is location of GC. GC was performed after session read previously. GC is moved before session read because previous logic is buggy. Old behavior: - Do session read (Session data is initialized and store in memory) - Do session

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

Hi Remi and Stas, Thank you for head up. I'll address this today. -- Yasuo Ohgaki yohg...@ohgaki.net On Fri, Jan 22, 2016 at 3:44 AM, Stanislav Malyshev wrote: > Hi! > >> Fedora detected a BC break in 5.6.18RC1 and 7.0.3RC1 related to >> session management. > > Looks like

Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***

Hi Stas, On Fri, Jan 22, 2016 at 7:15 AM, Stanislav Malyshev wrote: > >> We have 2 choices >> - Enforce new and correct behavior since it will not affect normal >>operation. i.e. Actual production site >> - Restore old behavior for the time being. (For this option, I