On Wed, Mar 1, 2023 at 11:34 AM Niels Dossche
wrote:
> On 3/1/23 08:42, Dmitry Stogov wrote:
> > On Wed, Mar 1, 2023 at 8:37 AM Max Kellermann wrote:
> >
> >> On 2023/02/28 23:33, Max Kellermann wrote:
> Include cleanups RFC was rejected.
> No refactoring RFC was presented.
> A l
On 3/1/23 08:42, Dmitry Stogov wrote:
> On Wed, Mar 1, 2023 at 8:37 AM Max Kellermann wrote:
>
>> On 2023/02/28 23:33, Max Kellermann wrote:
Include cleanups RFC was rejected.
No refactoring RFC was presented.
A lot of changes that affect all core contributors are committed into
>
On Wed, Mar 1, 2023 at 8:37 AM Max Kellermann wrote:
> On 2023/02/28 23:33, Max Kellermann wrote:
> > > Include cleanups RFC was rejected.
> > > No refactoring RFC was presented.
> > > A lot of changes that affect all core contributors are committed into
> > > master.
> >
> > Do you mean to impl
On 2023/02/28 23:33, Max Kellermann wrote:
> > Include cleanups RFC was rejected.
> > No refactoring RFC was presented.
> > A lot of changes that affect all core contributors are committed into
> > master.
>
> Do you mean to imply that code changes that do not implement RFC or
> fix a bug should
Am 01.03.2023 um 01:13 schrieb Bob Weinand :
> In this case, while the primary concern of the RFC was rejected, I think it's
> pretty clear, that there was a supermajority for something specific.
I didn't vote on this RFC but I have to disagree with you and Max here: My
understanding of such a v
Hey Max and Dmitry,
> Am 28.02.2023 um 23:34 schrieb Dmitry Stogov :
>
> On Wed, Mar 1, 2023 at 1:21 AM Max Kellermann wrote:
>
>> On 2023/02/28 22:31, Dmitry Stogov wrote:
>>> https://github.com/php/php-src/commit/0270a1e54c0285fa3c89ee2b0120073ef57ab5fa
>>
>> This kind of change was favored
On 28 February 2023 21:04:35 GMT, Max Kellermann wrote:
>On 2023/02/28 21:16, Dmitry Stogov wrote:
>> Recently we voted for inluce cleanup RFC
>> https://wiki.php.net/rfc/include_cleanup and it was declined.
>> Despite that a series of code refactoring commits from Max were silently
>> merged int
I'm a bit out of the loop on the higher level discussion, but as I got named
dropped here, a quick note...
On Tue, Feb 28, 2023, at 23:21, Max Kellermann wrote:
> On 2023/02/28 22:31, Dmitry Stogov wrote:
> > https://github.com/php/php-src/commit/0270a1e54c0285fa3c89ee2b0120073ef57ab5fa
>
> Thi
On 2023/02/28 23:34, Dmitry Stogov wrote:
> > https://github.com/php/php-src/commit/b98f18e7c3838cf587a1b6d0f033b89e9909c79d
> >
> > No vote was made on this, therefore this doesn't violate any community
> > rules, does it?
> >
>
> Please reread https://wiki.php.net/RFC/voting#voting
> RFC is acc
On Wed, Mar 1, 2023 at 1:21 AM Max Kellermann wrote:
> On 2023/02/28 22:31, Dmitry Stogov wrote:
> >
> https://github.com/php/php-src/commit/0270a1e54c0285fa3c89ee2b0120073ef57ab5fa
>
> This kind of change was favored by a supermajority.
>
> You argue that this supermajority vote is irrelevant,
On 2023/02/28 23:08, Dmitry Stogov wrote:
> > Which community rule was violated by whom?
> >
>
> Merging the things that were rejected. You may name this differently but
> this is still code refactoring.
That sidesteps my question, and answers something else.
> In your opinion, what exactly doe
On 2023/02/28 22:31, Dmitry Stogov wrote:
> https://github.com/php/php-src/commit/0270a1e54c0285fa3c89ee2b0120073ef57ab5fa
This kind of change was favored by a supermajority.
You argue that this supermajority vote is irrelevant, and formally it
indeed is, but pondering about formalities is kind
On Wed, Mar 1, 2023 at 12:04 AM Max Kellermann wrote:
> On 2023/02/28 21:16, Dmitry Stogov wrote:
> > Recently we voted for inluce cleanup RFC
> > https://wiki.php.net/rfc/include_cleanup and it was declined.
> > Despite that a series of code refactoring commits from Max were silently
> > merged
On Tue, Feb 28, 2023 at 11:59 PM Dan Liebner wrote:
> Which commit?
>
just some of them:
https://github.com/php/php-src/commit/0270a1e54c0285fa3c89ee2b0120073ef57ab5fa
https://github.com/php/php-src/commit/b98f18e7c3838cf587a1b6d0f033b89e9909c79d
https://github.com/php/php-src/commit/42577c6b6b7
Am 28.02.2023 um 22:04 schrieb Max Kellermann :
> On 2023/02/28 21:16, Dmitry Stogov wrote:
>> Recently we voted for inluce cleanup RFC
>> https://wiki.php.net/rfc/include_cleanup and it was declined.
>
> Which specific commits do you wish to revert? Is this about include
> cleanups (none of w
On 2023/02/28 21:16, Dmitry Stogov wrote:
> Recently we voted for inluce cleanup RFC
> https://wiki.php.net/rfc/include_cleanup and it was declined.
> Despite that a series of code refactoring commits from Max were silently
> merged into the master.
> As this is a violation of the community rules
Which commit?
On Tue, Feb 28, 2023, 3:17 PM Dmitry Stogov wrote:
> Hi @internals,
>
> I have to say that we came to a serious conflict.
>
> Recently we voted for inluce cleanup RFC
> https://wiki.php.net/rfc/include_cleanup and it was declined.
> Despite that a series of code refactoring commits
Hi @internals,
I have to say that we came to a serious conflict.
Recently we voted for inluce cleanup RFC
https://wiki.php.net/rfc/include_cleanup and it was declined.
Despite that a series of code refactoring commits from Max were silently
merged into the master.
As this is a violation of the co
18 matches
Mail list logo
