Re: [PHP-DEV] Pre-RFC: Fixing spec bugs in the DOM extension

2023-12-30 Thread Niels Dossche
Hi Robert On 30/12/2023 10:25, Robert Landers wrote: > Hi Niels, > >> They are indeed going to be very similar, but at least having better return >> types would be good to give one particular example. >> e.g. we currently have a lot of methods that can return an object or false. >> The current

Re: [PHP-DEV] Pre-RFC: Fixing spec bugs in the DOM extension

2023-12-30 Thread Sebastian Bergmann
Am 29.12.2023 um 17:58 schrieb Larry Garfield: I am also on team "yes, let's just do it right." If that means the new classes are only 99% drop ins for the old ones, I'm OK with that. People can switch over when they're ready and do all the clean up at once. +1 -- PHP Internals - PHP

Re: [PHP-DEV] Pre-RFC: Fixing spec bugs in the DOM extension

2023-12-30 Thread Robert Landers
Hi Niels, > They are indeed going to be very similar, but at least having better return > types would be good to give one particular example. > e.g. we currently have a lot of methods that can return an object or false. > The current living DOM spec always throws exceptions instead of returning

Re: [PHP-DEV] Pre-RFC: Fixing spec bugs in the DOM extension

2023-12-29 Thread Niels Dossche
Hi Larry On 29/12/2023 17:58, Larry Garfield wrote: > > I am also on team "yes, let's just do it right." If that means the new > classes are only 99% drop ins for the old ones, I'm OK with that. People can > switch over when they're ready and do all the clean up at once. > They are

Re: [PHP-DEV] Pre-RFC: Fixing spec bugs in the DOM extension

2023-12-29 Thread Niels Dossche
Hi Gina On 29/12/2023 15:40, G. P. B. wrote: > Thank you for the work! > > I agree that making them proper classes instead of aliases is the better > proposition here. > I'm not fully informed about the DOM spec, and I don't know if the current > class/interface hierarchy is in the best shape,

Re: [PHP-DEV] Pre-RFC: Fixing spec bugs in the DOM extension

2023-12-29 Thread Larry Garfield
On Tue, Dec 26, 2023, at 3:45 PM, Niels Dossche wrote: > Hi internals > > The DOM extension in PHP is used to parse, query and manipulate > XML/HTML documents. The DOM extension is based on the DOM specification. > Originally this was the DOM Core Level 3 specification, but nowadays, > that

Re: [PHP-DEV] Pre-RFC: Fixing spec bugs in the DOM extension

2023-12-29 Thread G. P. B.
On Tue, 26 Dec 2023 at 21:45, Niels Dossche wrote: > Hi internals > > The DOM extension in PHP is used to parse, query and manipulate XML/HTML > documents. The DOM extension is based on the DOM specification. > Originally this was the DOM Core Level 3 specification, but nowadays, that >

Re: [PHP-DEV] Pre-RFC: Fixing spec bugs in the DOM extension

2023-12-26 Thread Robert Landers
On Tue, Dec 26, 2023 at 11:14 PM Niels Dossche wrote: > > Hi Tim > > On 26/12/2023 22:58, Tim Düsterhus wrote: > > Hi > > > > On 12/26/23 22:45, Niels Dossche wrote: > >> In my opinion, having them become proper classes instead of aliases has my > >> preference: either we fix everything in one

Re: [PHP-DEV] Pre-RFC: Fixing spec bugs in the DOM extension

2023-12-26 Thread Niels Dossche
Hi Tim On 26/12/2023 22:58, Tim Düsterhus wrote: > Hi > > On 12/26/23 22:45, Niels Dossche wrote: >> In my opinion, having them become proper classes instead of aliases has my >> preference: either we fix everything in one go now while we have the >> opportunity, or never. > > As I've already

Re: [PHP-DEV] Pre-RFC: Fixing spec bugs in the DOM extension

2023-12-26 Thread Tim Düsterhus
Hi On 12/26/23 22:45, Niels Dossche wrote: In my opinion, having them become proper classes instead of aliases has my preference: either we fix everything in one go now while we have the opportunity, or never. As I've already told you in private, I'm in favor of using this opportunity.

[PHP-DEV] Pre-RFC: Fixing spec bugs in the DOM extension

2023-12-26 Thread Niels Dossche
Hi internals The DOM extension in PHP is used to parse, query and manipulate XML/HTML documents. The DOM extension is based on the DOM specification. Originally this was the DOM Core Level 3 specification, but nowadays, that specification has evolved into the current "Living Specification"