Re: [PHP-DEV] Re: #53437

2013-06-10 Thread Pierre Joye
hi, On Fri, Jun 7, 2013 at 9:27 PM, Gustavo Lopes glo...@nebm.ist.utl.pt wrote: On Fri, 07 Jun 2013 14:06:11 +0200, Derick Rethans der...@php.net wrote: That's the one where conversion int string for serialization was developed. It came into 5.5 with this patches (the originally proposed

Re: [PHP-DEV] Re: #53437

2013-06-10 Thread Etienne Kneuss
On Fri, Jun 7, 2013 at 9:27 PM, Gustavo Lopes glo...@nebm.ist.utl.ptwrote: On Fri, 07 Jun 2013 14:06:11 +0200, Derick Rethans der...@php.net wrote: That's the one where conversion int string for serialization was developed. It came into 5.5 with this patches (the originally proposed patch

Re: [PHP-DEV] Re: #53437

2013-06-10 Thread Pierre Joye
On Jun 10, 2013 1:24 PM, Etienne Kneuss col...@php.net wrote: So if I understand correctly var_dump now indicates a different type than what accessing the property returns? Even if the change itself does not constitute a big BC break, this behavior is confusing and seems like a big no-no

Re: [PHP-DEV] Re: #53437

2013-06-10 Thread Anatol Belski
Hi Etienne, On Mon, June 10, 2013 13:24, Etienne Kneuss wrote: On Fri, Jun 7, 2013 at 9:27 PM, Gustavo Lopes glo...@nebm.ist.utl.ptwrote: On Fri, 07 Jun 2013 14:06:11 +0200, Derick Rethans der...@php.net wrote: That's the one where conversion int string for serialization was

Re: [PHP-DEV] Re: #53437

2013-06-10 Thread Etienne Kneuss
On Mon, Jun 10, 2013 at 1:56 PM, Anatol Belski a...@php.net wrote: Hi Etienne, On Mon, June 10, 2013 13:24, Etienne Kneuss wrote: On Fri, Jun 7, 2013 at 9:27 PM, Gustavo Lopes glo...@nebm.ist.utl.ptwrote: On Fri, 07 Jun 2013 14:06:11 +0200, Derick Rethans der...@php.net wrote:

Re: [PHP-DEV] Re: #53437

2013-06-10 Thread Etienne Kneuss
On Mon, Jun 10, 2013 at 1:47 PM, Pierre Joye pierre@gmail.com wrote: On Jun 10, 2013 1:24 PM, Etienne Kneuss col...@php.net wrote: So if I understand correctly var_dump now indicates a different type than what accessing the property returns? Even if the change itself does not

Re: [PHP-DEV] Re: #53437

2013-06-10 Thread Johannes Schlüter
On Mon, 2013-06-10 at 14:07 +0200, Etienne Kneuss wrote: I propose we fix the serialization/unserialization crash in a way that does not affect var_dump. That was the summary of my message a while back, too. Aside from that I trust the assessment of extension maintainers. I want to take this

Re: [PHP-DEV] Re: #53437

2013-06-10 Thread Anatol Belski
On Mon, June 10, 2013 14:04, Etienne Kneuss wrote: On Mon, Jun 10, 2013 at 1:56 PM, Anatol Belski a...@php.net wrote: Hi Etienne, On Mon, June 10, 2013 13:24, Etienne Kneuss wrote: On Fri, Jun 7, 2013 at 9:27 PM, Gustavo Lopes glo...@nebm.ist.utl.ptwrote: On Fri, 07 Jun 2013 14:06:11

Re: [PHP-DEV] Re: #53437

2013-06-10 Thread Pierre Joye
On Mon, Jun 10, 2013 at 2:33 PM, Johannes Schlüter johan...@schlueters.de wrote: On Mon, 2013-06-10 at 14:07 +0200, Etienne Kneuss wrote: I propose we fix the serialization/unserialization crash in a way that does not affect var_dump. That was the summary of my message a while back, too.

Re: [PHP-DEV] Re: #53437

2013-06-10 Thread Stas Malyshev
Hi! As I mentioned previously, that small piece is easy fixable, though it possibly makes that place not portable between 32 and 64 bit. The main intention is to fix the unserialization crash, which IMHO interleaves this small deviation. What you mean by not portable? Different code,

Re: [PHP-DEV] Re: #53437

2013-06-10 Thread Stas Malyshev
Hi! Stas, Johannes? We have to fix this crash, in one way or another. The current patch is good imo. I'm ok with this in 5.4 but I'd really like to fix the var_dump issue if possible. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 --

Re: [PHP-DEV] Re: #53437

2013-06-10 Thread Anatol Belski
Hi Stas, On Mon, 2013-06-10 at 10:54 -0700, Stas Malyshev wrote: Hi! Stas, Johannes? We have to fix this crash, in one way or another. The current patch is good imo. I'm ok with this in 5.4 but I'd really like to fix the var_dump issue if possible. I've reworked the patch before

Re: [PHP-DEV] Re: #53437

2013-06-07 Thread Derick Rethans
On Thu, 6 Jun 2013, Pierre Joye wrote: On Jun 6, 2013 6:03 PM, Derick Rethans der...@php.net wrote: On Thu, 6 Jun 2013, Pierre Joye wrote: The fix for #53437 is around for some time now. It full fills the requirements described by Derick when we discussed the possible fixes.

Re: [PHP-DEV] Re: #53437

2013-06-07 Thread Anatol Belski
Hi Derick, On Fri, June 7, 2013 12:45, Derick Rethans wrote: On Thu, 6 Jun 2013, Pierre Joye wrote: On Jun 6, 2013 6:03 PM, Derick Rethans der...@php.net wrote: On Thu, 6 Jun 2013, Pierre Joye wrote: The fix for #53437 is around for some time now. It full fills the requirements

Re: [PHP-DEV] Re: #53437

2013-06-07 Thread Derick Rethans
On Fri, 7 Jun 2013, Anatol Belski wrote: On Fri, June 7, 2013 12:45, Derick Rethans wrote: On Thu, 6 Jun 2013, Pierre Joye wrote: On Jun 6, 2013 6:03 PM, Derick Rethans der...@php.net wrote: On Thu, 6 Jun 2013, Pierre Joye wrote: The fix for #53437 is around for some time now. It

Re: [PHP-DEV] Re: #53437

2013-06-07 Thread Anatol Belski
Hi Derick, On Fri, June 7, 2013 14:06, Derick Rethans wrote: On Fri, 7 Jun 2013, Anatol Belski wrote: On Fri, June 7, 2013 12:45, Derick Rethans wrote: On Thu, 6 Jun 2013, Pierre Joye wrote: On Jun 6, 2013 6:03 PM, Derick Rethans der...@php.net wrote: On Thu, 6 Jun 2013, Pierre Joye

Re: [PHP-DEV] Re: #53437

2013-06-07 Thread Gustavo Lopes
On Fri, 07 Jun 2013 14:06:11 +0200, Derick Rethans der...@php.net wrote: That's the one where conversion int string for serialization was developed. It came into 5.5 with this patches (the originally proposed patch is still attached to that ticket)

[PHP-DEV] Re: #53437

2013-06-06 Thread Derick Rethans
On Thu, 6 Jun 2013, Pierre Joye wrote: The fix for #53437 is around for some time now. It full fills the requirements described by Derick when we discussed the possible fixes. Unless there are strong objections in the next couple of days, I will ask Anatol to apply it on Monday. This is

Re: [PHP-DEV] Re: #53437

2013-06-06 Thread Pierre Joye
On Jun 6, 2013 6:03 PM, Derick Rethans der...@php.net wrote: On Thu, 6 Jun 2013, Pierre Joye wrote: The fix for #53437 is around for some time now. It full fills the requirements described by Derick when we discussed the possible fixes. Unless there are strong objections in the next