Re: [PHP-DEV] Re: Don't silence fatal errors

2019-02-11 Thread Nikita Popov
On Wed, Feb 6, 2019 at 10:45 PM Christoph M. Becker wrote: > On 06.02.2019 at 05:42, Zeev Suraski wrote: > > > As long as we have a prominent warning about this in our migration guide > > alerting people to the associated risk in setups where display errors is > on > > - I can live with the

Re: [PHP-DEV] Re: Don't silence fatal errors

2019-02-06 Thread Christoph M. Becker
On 06.02.2019 at 05:42, Zeev Suraski wrote: > As long as we have a prominent warning about this in our migration guide > alerting people to the associated risk in setups where display errors is on > - I can live with the change as-is. How do we ensure that it doesn't get > lost in the clutter

Re: [PHP-DEV] Re: Don't silence fatal errors

2019-02-05 Thread Zeev Suraski
On Tue, Feb 5, 2019 at 7:19 PM Nikita Popov wrote: > On Tue, Feb 5, 2019 at 5:55 PM Zeev Suraski wrote: > >> On Tue, Feb 5, 2019 at 5:17 PM Nikita Popov wrote: >> >>> On Mon, Nov 26, 2018 at 10:42 PM Nikita Popov >>> wrote: >>> >>> >>> I'd like to move forward with this change. I think the

Re: [PHP-DEV] Re: Don't silence fatal errors

2019-02-05 Thread Nikita Popov
On Tue, Feb 5, 2019 at 5:55 PM Zeev Suraski wrote: > On Tue, Feb 5, 2019 at 5:17 PM Nikita Popov wrote: > >> On Mon, Nov 26, 2018 at 10:42 PM Nikita Popov >> wrote: >> >> >> I'd like to move forward with this change. I think the overall reception >> here has been positive, although in the

Re: [PHP-DEV] Re: Don't silence fatal errors

2019-02-05 Thread Zeev Suraski
On Tue, Feb 5, 2019 at 5:17 PM Nikita Popov wrote: > On Mon, Nov 26, 2018 at 10:42 PM Nikita Popov > wrote: > > > I'd like to move forward with this change. I think the overall reception > here has been positive, although in the discussion some other possibilities > that avoid/reduce the BC

[PHP-DEV] Re: Don't silence fatal errors

2019-02-05 Thread Nikita Popov
On Mon, Nov 26, 2018 at 10:42 PM Nikita Popov wrote: > Hi internals, > > When the silencing operator @ is used, the intention is generally to > silence expected warnings or notices. However, it currently also silences > fatal errors. As fatal errors also abort request execution, the result will

Re: [PHP-DEV] Re: Don't silence fatal errors

2018-12-03 Thread Zeev Suraski
On Mon, Dec 3, 2018 at 12:51 AM Andrea Faulds wrote: > Hi Nikita, > > Nikita Popov wrote: > > When the silencing operator @ is used, the intention is generally to > > silence expected warnings or notices. However, it currently also silences > > fatal errors. As fatal errors also abort request

Re: [PHP-DEV] Re: Don't silence fatal errors

2018-12-02 Thread Stanislav Malyshev
Hi! > It's always been bizarre to me that @ can silence fatal errors, which > has no practical application and makes using @ to silence a lower-level > error potentially hszardous if its targeted function can also produce a > fatal error. Yes, silencing something that kills the script is

[PHP-DEV] Re: Don't silence fatal errors

2018-12-02 Thread Andrea Faulds
Hi Nikita, Nikita Popov wrote: When the silencing operator @ is used, the intention is generally to silence expected warnings or notices. However, it currently also silences fatal errors. As fatal errors also abort request execution, the result will often be a hard to debug white screen of