[PHP-DEV] Re: RFC for Sqlite3 Extended Error Codes

2019-06-18 Thread Robert Kopack
Hello everybody, I've had the PR open for this a while now (https://github.com/php/php-src/pull/4166) and was hoping to get more eyes on it; Kalle was looking at it but he appears to have not been as active lately and as I believe it is in a good state right now I was hoping to have some other fee

[PHP-DEV] Re: RFC for Sqlite3 Extended Error Codes

2019-05-18 Thread Christoph M. Becker
On 16.05.2019 at 15:51, Robert Kopack wrote: > On Wed, May 15, 2019 at 7:00 PM Christoph M. Becker > wrote: > >> I haven't reviewed closely for now, but basically I like these >> additions. With regard to sqlite3_extended_result_codes() we have to >> review existing error checks (they likely nee

[PHP-DEV] Re: RFC for Sqlite3 Extended Error Codes

2019-05-16 Thread Robert Kopack
On Wed, May 15, 2019 at 7:00 PM Christoph M. Becker wrote: > On 15.05.2019 at 19:14, Robert Kopack wrote: > > > I would to extend the functionality of the current sqlite3 implementation > > (in *ext/sqlite3* and in *ext/pdo_sqlite*) by exposing the functions > > related to extended result codes.

[PHP-DEV] Re: RFC for Sqlite3 Extended Error Codes

2019-05-15 Thread Christoph M. Becker
On 15.05.2019 at 19:14, Robert Kopack wrote: > I would to extend the functionality of the current sqlite3 implementation > (in *ext/sqlite3* and in *ext/pdo_sqlite*) by exposing the functions > related to extended result codes. I have already forked and made my changes > at > https://github.com/rk