[PHP-DEV] Re: Remove useless opcode handlers

2016-03-14 Thread Andrea Faulds
Hi, Nikita Popov wrote: What I mean is, for example: var_dump(~(bool)true); echo "Done\n"; Will throw an exception without opcache, will result in no output (and no *visible* error) with opcache. My point here is that const-operand-only cases might be necessary to handle error cases like this.

[PHP-DEV] Re: Remove useless opcode handlers

2016-03-14 Thread Nikita Popov
On Mon, Mar 14, 2016 at 12:58 PM, Dmitry Stogov wrote: > > > On 03/14/2016 02:29 PM, Nikita Popov wrote: > > On Mon, Mar 14, 2016 at 11:56 AM, Dmitry Stogov wrote: > >> Please take a quick look and let me know if you see any problems. >> >> >> https://gist.github.com/dstogov/23cc318dd3e411904e10

[PHP-DEV] Re: Remove useless opcode handlers

2016-03-14 Thread Dmitry Stogov
On 03/14/2016 02:29 PM, Nikita Popov wrote: On Mon, Mar 14, 2016 at 11:56 AM, Dmitry Stogov > wrote: Please take a quick look and let me know if you see any problems. https://gist.github.com/dstogov/23cc318dd3e411904e10 I'm going to commit this tomorrow.

[PHP-DEV] Re: Remove useless opcode handlers

2016-03-14 Thread Nikita Popov
On Mon, Mar 14, 2016 at 11:56 AM, Dmitry Stogov wrote: > Please take a quick look and let me know if you see any problems. > > > https://gist.github.com/dstogov/23cc318dd3e411904e10 > > > I'm going to commit this tomorrow. > > > Thanks. Dmitry. > ZEND_ADD is not commutative for array operands. Z