Re: [PHP-DEV] Re: Small regression in PHP-LDAP

2015-11-15 Thread Côme Chilliet
Le samedi 14 novembre 2015, 16:06:14 Ferenc Kovacs a écrit : > Côme, what do you think about my suggestion for 5.6? I’m gonna do the same thing as for the port=NULL support, only commit this to 5.6. I’ll push to 7 the notice when using URI+PORT on the other hand. -- PHP Internals - PHP Runtime D

Re: [PHP-DEV] Re: Small regression in PHP-LDAP

2015-11-14 Thread Ferenc Kovacs
2015. nov. 6. 1:07 ezt írta ("Ferenc Kovacs" ): > > > > On Thu, Nov 5, 2015 at 9:53 PM, Adam Howard wrote: >> >> I don't think it is possible to make everyone happy all the time. I think this should be kept for a user code fix. >> > > please don't top post on the php.net mailing lists. > on one h

Re: [PHP-DEV] Re: Small regression in PHP-LDAP

2015-11-05 Thread Ferenc Kovacs
On Thu, Nov 5, 2015 at 9:53 PM, Adam Howard wrote: > I don't think it is possible to make everyone happy all the time. I think > this should be kept for a user code fix. > > please don't top post on the php.net mailing lists. on one hand this change doesn't really make any person happy (apart ma

Re: [PHP-DEV] Re: Small regression in PHP-LDAP

2015-11-05 Thread Adam Howard
I don't think it is possible to make everyone happy all the time. I think this should be kept for a user code fix. On Thu, Nov 5, 2015 at 2:37 PM, Ferenc Kovacs wrote: > On Thu, Nov 5, 2015 at 5:38 PM, Bishop Bettini wrote: > > > On Thu, Nov 5, 2015 at 8:56 AM, Ferenc Kovacs wrote: > > > >> O

Re: [PHP-DEV] Re: Small regression in PHP-LDAP

2015-11-05 Thread Ferenc Kovacs
On Thu, Nov 5, 2015 at 5:38 PM, Bishop Bettini wrote: > On Thu, Nov 5, 2015 at 8:56 AM, Ferenc Kovacs wrote: > >> On Thu, Nov 5, 2015 at 2:26 PM, Andreas Heigl wrote: >> >> > Am 05.11.15 um 14:14 schrieb Ferenc Kovacs: >> > [...] >> > > I would keep the old behavior for 5.6, even if that was un

Re: [PHP-DEV] Re: Small regression in PHP-LDAP

2015-11-05 Thread Bishop Bettini
On Thu, Nov 5, 2015 at 8:56 AM, Ferenc Kovacs wrote: > On Thu, Nov 5, 2015 at 2:26 PM, Andreas Heigl wrote: > > > Am 05.11.15 um 14:14 schrieb Ferenc Kovacs: > > [...] > > > I would keep the old behavior for 5.6, even if that was unintended > nobody > > > complained about it(so removing it isn't

Re: [PHP-DEV] Re: Small regression in PHP-LDAP

2015-11-05 Thread Ferenc Kovacs
On Thu, Nov 5, 2015 at 2:26 PM, Andreas Heigl wrote: > Am 05.11.15 um 14:14 schrieb Ferenc Kovacs: > [...] > > I would keep the old behavior for 5.6, even if that was unintended nobody > > complained about it(so removing it isn't a bugfix per se), so I see no > > reason to break userland code wor

Re: [PHP-DEV] Re: Small regression in PHP-LDAP

2015-11-05 Thread Andreas Heigl
Am 05.11.15 um 14:14 schrieb Ferenc Kovacs: [...] > I would keep the old behavior for 5.6, even if that was unintended nobody > complained about it(so removing it isn't a bugfix per se), so I see no > reason to break userland code working before in a micro version. > for PHP-7.0 we can remove the o

Re: [PHP-DEV] Re: Small regression in PHP-LDAP

2015-11-05 Thread Ferenc Kovacs
On Wed, Nov 4, 2015 at 4:28 AM, Côme Chilliet wrote: > Le mardi 3 novembre 2015, 18:59:42 Andrea Faulds a écrit : > > I'd argue this is a regression, documented feature or not. Supporting > > 'host:port' is not a bug, and this has broken existing code, which micro > > (x.y.Z) versions are not all

Re: [PHP-DEV] Re: Small regression in PHP-LDAP

2015-11-03 Thread Côme Chilliet
Le mardi 3 novembre 2015, 18:59:42 Andrea Faulds a écrit : > I'd argue this is a regression, documented feature or not. Supporting > 'host:port' is not a bug, and this has broken existing code, which micro > (x.y.Z) versions are not allowed to do. It should be fixed ASAP. So I got two votes agai

[PHP-DEV] Re: Small regression in PHP-LDAP

2015-11-03 Thread Andrea Faulds
Hi Côme, Côme Chilliet wrote: The use of ldap_connect(host:port) without ldap:// is not something that is in the tests, and is not explicitely allowed by our documentation: http://php.net/manual/en/function.ldap-connect.php I don't use LDAP, so maybe it's different here, but accepting both