[PHP-DEV] Re: Ternary operator improvements

2011-07-11 Thread Dmitry Stogov
For now the patch still looks a bit messing to me. Also, I would probably prefer to use new opcodes ZEND_QM_ASSIGN_VAR and ZEND_JMP_SET_VAR. Ok, I'll change the patch to use new opcodes instead It's not necessary yet. Please, let me think a bit more. Thanks. Dmitry. -- PHP Internals - PH

[PHP-DEV] Re: Ternary operator improvements

2011-07-11 Thread Arnaud Le Blanc
Hi Dmitry, Le Monday 11 July 2011 09:49:27, Dmitry Stogov a écrit : > Hi Arnaud, > > Is the main advantage of the patch - elimination of zval copy > constructor for IS_VAR and IS_CV operands? Yes. Currently the ternary operator does a copy of its second and third operands. This is costly when

[PHP-DEV] Re: Ternary operator improvements

2011-07-11 Thread Dmitry Stogov
Hi Arnaud, Is the main advantage of the patch - elimination of zval copy constructor for IS_VAR and IS_CV operands? Does it improve speed only for VAR/CV array operands? Will the following script require an extra zval ealloc/efree with the patch? For now the patch still looks a bit messing