[PHP-DEV] Re: implode() speedup in PHP4

2005-03-21 Thread Alexander Valyalkin
> After applying the change to ext/standard/string.c in PHP4 the following > Test failed: > Bug #4 (implode changes object references in array) > [ext/standard/tests/strings/bug4.phpt] > > Regards, > Christian Stadler I understood my fault. I didn't notice condition if (!(*ppzv)->is_ref)

[PHP-DEV] Re: implode() speedup in PHP4

2005-03-18 Thread Christian Stadler
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Alexander Valyalkin schrieb: > I've posted patch last summer http://www.zend.com/zend/week/pat/pat5.txt > which imporves performance of implode() function in PHP4, but nobody > doesn't > commit it yet. Can anybody explain the reason? After applying t

[PHP-DEV] Re: implode() speedup

2004-06-14 Thread Alexander Valyalkin
I've read CODING_STANDARDS (thanks to Christian Schneider) and corrected my code according to your standards. Also I've improved speed of algorithm. Now it is not duplicate the string value of array item, if it is has string type already: if (Z_TYPE_PP(tmp) != IS_STRING) { /* create new ins