Hi Derick,
I saw you have landed the recent updates of timelib to PHP master.
There are few ongoing improvements:
https://github.com/derickr/timelib/pull/103 - an obvious code motion, that
avoid useless "year" calculation
https://github.com/derickr/timelib/pull/104 - an adoption of my old idea,
hi,
On Thu, Mar 4, 2021 at 3:30 PM Derick Rethans wrote:
> Hi,
>
> I saw the PRs coming in, I'll reply inline:
>
> On Thu, 4 Mar 2021, Dmitry Stogov wrote:
>
> >
> https://github.com/php/php-src/commit/b4e9b1846376f562e27a13572a137ec584c13f58
>
> As Nikita already commented, this now seems to in
Hi,
I saw the PRs coming in, I'll reply inline:
On Thu, 4 Mar 2021, Dmitry Stogov wrote:
> https://github.com/php/php-src/commit/b4e9b1846376f562e27a13572a137ec584c13f58
As Nikita already commented, this now seems to introduce flakeyness into
tests.
> And created 3 pull request for timelib:
>
Hi Derick,
I spent some time looking in the timelib implementation caused slowness in
the Symphony Demo app (https://github.com/symfony/demo)
I committed one patch into ext/date:
https://github.com/php/php-src/commit/b4e9b1846376f562e27a13572a137ec584c13f58
And created 3 pull request for timeli
