Re: [PHP-DEV] Releasing 4.3.5pl1

2004-04-01 Thread Andi Gutmans
At 10:28 AM 4/1/2004 -0800, Rasmus Lerdorf wrote: On Thu, 1 Apr 2004, Andi Gutmans wrote: > I'm OK with RC and 4.3.6 but we should get it out quickly which means we > should RC ASAP. How much time until the DST issues are fixed? I haven't > seen any other problematic patches except for Ilia's lates

Re: [PHP-DEV] Releasing 4.3.5pl1

2004-04-01 Thread Rasmus Lerdorf
On Thu, 1 Apr 2004, Andi Gutmans wrote: > I'm OK with RC and 4.3.6 but we should get it out quickly which means we > should RC ASAP. How much time until the DST issues are fixed? I haven't > seen any other problematic patches except for Ilia's latest Zend Engine > patch which I didn't get a chan

Re: [PHP-DEV] Releasing 4.3.5pl1

2004-04-01 Thread Derick Rethans
On Thu, 1 Apr 2004, Andi Gutmans wrote: > I'm OK with RC and 4.3.6 but we should get it out quickly which means we > should RC ASAP. How much time until the DST issues are fixed? If all goes well in a couple of hours. Derick -- PHP Internals - PHP Runtime Development Mailing List To unsubscrib

Re: [PHP-DEV] Releasing 4.3.5pl1

2004-04-01 Thread Andi Gutmans
I'm OK with RC and 4.3.6 but we should get it out quickly which means we should RC ASAP. How much time until the DST issues are fixed? I haven't seen any other problematic patches except for Ilia's latest Zend Engine patch which I didn't get a chance to review first. Andi At 12:44 PM 4/1/2004 -

Re: [PHP-DEV] Releasing 4.3.5pl1

2004-04-01 Thread Ilia Alshanetsky
On April 1, 2004 12:25 pm, Rasmus Lerdorf wrote: > I don't think we should push it out without an RC. I just think we should > instigate the RC process now rather than waiting. Especially considering > the fact that there were some non-trivial changes. The more other changes > we add on top of t

Re: [PHP-DEV] Releasing 4.3.5pl1

2004-04-01 Thread Andrei Zmievski
On Thu, 01 Apr 2004, Rasmus Lerdorf wrote: > I don't think we should push it out without an RC. I just think we should > instigate the RC process now rather than waiting. Especially considering > the fact that there were some non-trivial changes. The more other changes > we add on top of thes

Re: [PHP-DEV] Releasing 4.3.5pl1

2004-04-01 Thread Rasmus Lerdorf
On Thu, 1 Apr 2004, Ilia Alshanetsky wrote: > On April 1, 2004 12:05 pm, you wrote: > > Yup, given the fact that the DST change date is fast approaching, it would > > be good to get the mktime/gmmktime fixes out there soon along with the > > strftime fix. Nothing says we have to wait until we have

Re: [PHP-DEV] Releasing 4.3.5pl1

2004-04-01 Thread Derick Rethans
On Thu, 1 Apr 2004, Rasmus Lerdorf wrote: > On Thu, 1 Apr 2004, Ilia Alshanetsky wrote: > > > On April 1, 2004 07:51 am, Edin Kadribasic wrote: > > > +1 except I would call it 4.3.6. We have precedent for this sort bug fix > > > release. 4.3.1 if I remember correctly. > > > > +1 > > > > > There we

Re: [PHP-DEV] Releasing 4.3.5pl1

2004-04-01 Thread Ilia Alshanetsky
On April 1, 2004 12:05 pm, you wrote: > Yup, given the fact that the DST change date is fast approaching, it would > be good to get the mktime/gmmktime fixes out there soon along with the > strftime fix. Nothing says we have to wait until we have 100+ bug fixes > in there. We have fixed 20 or so

Re: [PHP-DEV] Releasing 4.3.5pl1

2004-04-01 Thread Rasmus Lerdorf
On Thu, 1 Apr 2004, Ilia Alshanetsky wrote: > On April 1, 2004 07:51 am, Edin Kadribasic wrote: > > +1 except I would call it 4.3.6. We have precedent for this sort bug fix > > release. 4.3.1 if I remember correctly. > > +1 > > > There were many bug reports regarding some data/time functions, ma

Re: [PHP-DEV] Releasing 4.3.5pl1

2004-04-01 Thread Ilia Alshanetsky
On April 1, 2004 07:51 am, Edin Kadribasic wrote: > +1 except I would call it 4.3.6. We have precedent for this sort bug fix > release. 4.3.1 if I remember correctly. +1 > There were many bug reports regarding some data/time functions, maybe we > should merge that fix in as well? Rasmus/Derick sh

Re: [PHP-DEV] Releasing 4.3.5pl1

2004-04-01 Thread Edin Kadribasic
+1 except I would call it 4.3.6. We have precedent for this sort bug fix release. 4.3.1 if I remember correctly. There were many bug reports regarding some data/time functions, maybe we should merge that fix in as well? Rasmus/Derick should know more about this one,. Edin On Thursday 01 Apr

[PHP-DEV] Releasing 4.3.5pl1

2004-04-01 Thread Andi Gutmans
Hi, A pretty serious bug crept into 4.3.5. A few weeks ago, a TSRM fix was commited which was supposed to prevent memory leaks when PHP ends its execution (shutdown dtor was not being called in tsrm_shutdown()). This fix causes a crash when a shared extension registers a dtor function. This is