Re: [PHP-DEV] Throwable and Error exceptions break existing PHP 5.x code

2016-01-12 Thread Giovanni Giacobbi
I want to thank Markus and Björn for getting me up to speed with the pointers. Please see the rest of my response below. On 11 January 2016 at 15:05, Rowan Collins wrote: > Giovanni Giacobbi wrote on 11/01/2016 13:31: > >> set_exception_handler(callback function, bool

Re: [PHP-DEV] Throwable and Error exceptions break existing PHP 5.x code

2016-01-12 Thread Rowan Collins
Giovanni Giacobbi wrote on 12/01/2016 09:37: But the fact is that it did NOT exist, so when you say "other than the specific transition to PHP 7", well I think it is a big deal and motivates the introduction of a new feature just for that. I guess what I meant was, once everyone has been

Re: [PHP-DEV] Throwable and Error exceptions break existing PHP 5.x code

2016-01-12 Thread Umberto Salsi
giova...@giacobbi.net (Giovanni Giacobbi) wrote: > Also think about the possible upcoming changes to the Throwable definition, > I saw in another thread that you are thinking about dropping > Throwable::getCode(), which would make things even worse, in case of > something as simple as: >

Re: [PHP-DEV] Throwable and Error exceptions break existing PHP 5.x code

2016-01-11 Thread Andrea Faulds
Hi Adam, Adam Harvey wrote: On 11 January 2016 at 06:05, Rowan Collins wrote: Since set_exception_handler() is intended as a last-ditch "something's gone very wrong" function anyway, I think it receiving all Throwables makes sense, even if the BC break in your

Re: [PHP-DEV] Throwable and Error exceptions break existing PHP 5.x code

2016-01-11 Thread Adam Harvey
On 11 January 2016 at 06:05, Rowan Collins wrote: > Since set_exception_handler() is intended as a last-ditch "something's gone > very wrong" function anyway, I think it receiving all Throwables makes > sense, even if the BC break in your scenario is unfortunate. Agreed

[PHP-DEV] Throwable and Error exceptions break existing PHP 5.x code

2016-01-11 Thread Giovanni Giacobbi
Greetings, Short premise before I get flamed: I know PHP 7 is rolling and it is way too late for this, that I should've tested the RCs, follow the mailing list and so on, but I'm a dev like you guys and struggle with the time to do everything by the book, including reading the previous threads

Re: [PHP-DEV] Throwable and Error exceptions break existing PHP 5.x code

2016-01-11 Thread Rowan Collins
Giovanni Giacobbi wrote on 11/01/2016 13:31: set_exception_handler(callback function, bool also_throwables = false); The new parameter "also_throwables" defaults to false, so the same behaviour as before is preserved. If you want it to catch also the new PHP7 Error exceptions, you can just set

Re: [PHP-DEV] Throwable and Error exceptions break existing PHP 5.x code

2016-01-11 Thread Markus Fischer
Dear Giovanni, I brought this up last July, see https://bugs.php.net/bug.php?id=70050 ; because in a few code bases I tested back then, this was the first issue I hit. Unfortunately, it was only deemed a "Documentation Problem" back then. AFAIK this is the most up to date information. Sorry I