Re: [PHP-DEV] What gruntwork needs to be done

2010-04-07 Thread Martin Jansen
On 6.4.2010 19:54, Rasmus Lerdorf wrote: On 04/06/2010 10:47 AM, Scott MacVicar wrote: http://whisky.macvicar.net/patches/utf8-string.diff.txt My only issue with this is that it essentially duplicates the utf8 part of get_next_char() from html.c. I'd like to see cs parsing in one place

[PHP-DEV] Bug 47435[Was]: Re: [PHP-DEV] What gruntwork needs to be done

2010-04-07 Thread Justin Dearing
Ramus, On Tue, Apr 6, 2010 at 1:34 PM, Rasmus Lerdorf ras...@lerdorf.com wrote: Here is a straightforward (but not easy) one: http://bugs.php.net/bug.php?id=47435 I actually found it easy, slightly tedious, and not straightforward. I guess its perspective. I am CCing my former colleague

[PHP-DEV] Re: Bug 47435[Was]: Re: [PHP-DEV] What gruntwork needs to be done

2010-04-07 Thread Justin Dearing
On Wed, Apr 7, 2010 at 3:39 PM, Rasmus Lerdorf ras...@lerdorf.com wrote: I'm ok with these. Like you say, this stuff is a bit tedious to sort through, and anything we can do to make it easier on users is a good thing. I'm trying to get the filter extension beefed up in the next version of

[PHP-DEV] Re: Bug 47435[Was]: Re: [PHP-DEV] What gruntwork needs to be done

2010-04-07 Thread Michael Graziano
Ramus, On Tue, Apr 6, 2010 at 1:34 PM, Rasmus Lerdorf ras...@lerdorf.com wrote: Here is a straightforward (but not easy) one: http://bugs.php.net/bug.php?id=47435 I actually found it easy, slightly tedious, and not straightforward. I guess its perspective. I am CCing my former

Re: [PHP-DEV] Re: Bug 47435[Was]: Re: [PHP-DEV] What gruntwork needs to be done

2010-04-07 Thread Ferenc Kovacs
I want both!!! :) Tyrael On Wed, Apr 7, 2010 at 11:18 PM, Michael Graziano mi...@bsd-box.net wrote: Ramus, On Tue, Apr 6, 2010 at 1:34 PM, Rasmus Lerdorf ras...@lerdorf.com wrote: Here is a straightforward (but not easy) one: http://bugs.php.net/bug.php?id=47435 I actually

[PHP-DEV] What gruntwork needs to be done

2010-04-06 Thread Justin Dearing
Hi, So pending review an acceptance by Dmitry, I've written my first patch for PHP. While there is a good chance I will need to make further revisions to the test or code, I don't know what that is. However, I've got some free time at the moment, and I'd like to make use of some of the sunk

Re: [PHP-DEV] What gruntwork needs to be done

2010-04-06 Thread Rasmus Lerdorf
On 04/06/2010 10:08 AM, Justin Dearing wrote: So pending review an acceptance by Dmitry, I've written my first patch for PHP. While there is a good chance I will need to make further revisions to the test or code, I don't know what that is. However, I've got some free time at the moment,

Re: [PHP-DEV] What gruntwork needs to be done

2010-04-06 Thread Scott MacVicar
On Apr 6, 2010, at 10:34 AM, Rasmus Lerdorf wrote: On 04/06/2010 10:08 AM, Justin Dearing wrote: So pending review an acceptance by Dmitry, I've written my first patch for PHP. While there is a good chance I will need to make further revisions to the test or code, I don't know what that is.

Re: [PHP-DEV] What gruntwork needs to be done

2010-04-06 Thread Rasmus Lerdorf
On 04/06/2010 10:47 AM, Scott MacVicar wrote: On Apr 6, 2010, at 10:34 AM, Rasmus Lerdorf wrote: On 04/06/2010 10:08 AM, Justin Dearing wrote: So pending review an acceptance by Dmitry, I've written my first patch for PHP. While there is a good chance I will need to make further revisions to

Re: [PHP-DEV] What gruntwork needs to be done

2010-04-06 Thread Scott MacVicar
On Apr 6, 2010, at 10:54 AM, Rasmus Lerdorf wrote: On 04/06/2010 10:47 AM, Scott MacVicar wrote: On Apr 6, 2010, at 10:34 AM, Rasmus Lerdorf wrote: On 04/06/2010 10:08 AM, Justin Dearing wrote: So pending review an acceptance by Dmitry, I've written my first patch for PHP. While there is a