Re: [PHP-DEV] ZTS leak

2005-08-29 Thread Sara Golemon
@@ -706,7 +707,6 @@ zend_shutdown_extensions(TSRMLS_C); free(zend_version_info); - zend_shutdown_constants(TSRMLS_C); free(GLOBAL_FUNCTION_TABLE); free(GLOBAL_CLASS_TABLE); #ifdef ZTS Are you sure it's not leaking the global constants table with the zend_

Re: [PHP-DEV] ZTS leak

2005-08-29 Thread Zeev Suraski
At 04:03 30/08/2005, Sara Golemon wrote: Are you sure it's not leaking the global constants table with the zend_shutdown_constants() removed from zend_shutdown()? valgrind says no. To be honest I havn't gone looking to see where the global table is cleaned up...Just got back home... If valgri

Re: [PHP-DEV] ZTS leak

2005-08-29 Thread Sara Golemon
As far as I can tell it's a bug. By the way, we're not talking about a leak that happens too often - unless you're spawning and killing threads very often (in which case TSRM is very inefficient regardless of anything). The leak would happen per-terminated thread. Good call. The backstory i

Re: [PHP-DEV] ZTS leak

2005-08-29 Thread Zeev Suraski
At 01:13 30/08/2005, Sara Golemon wrote: In looking into a series of leaks regarding tsrm interpreter contexts with George and Wez, we came across a problem with how EG(zend_constants) is created and destroyed. Specifically it's only destroyed once, from zend_shutdown(). However it's created by

[PHP-DEV] ZTS leak

2005-08-29 Thread Sara Golemon
In looking into a series of leaks regarding tsrm interpreter contexts with George and Wez, we came across a problem with how EG(zend_constants) is created and destroyed. Specifically it's only destroyed once, from zend_shutdown(). However it's created by executor_globals_ctor(). In non-ZTS this