Re: [PHP-DEV] ext/soap and http header

2008-10-01 Thread Dmitry Stogov
Hi Brain, A little bit different patch committed into PHP_5_3 and HEAD. I don't think it's allowed to commit it into PHP_5_2. Please verify, if it works for you. Thanks. Dmitry. Brian J. France wrote: > After some more testing I needed to tweak the patch and the example, > here is version 2. >

Re: [PHP-DEV] ext/soap and http header

2008-09-30 Thread Dmitry Stogov
Rasmus Lerdorf wrote: > Dmitry Stogov wrote: >> Hi Rasmus, >> >> Rasmus Lerdorf wrote: >>> Dmitry Stogov wrote: Hi Brian, I think you patch does the things you like properly, but why do we need such ability? I don't see a use-case. In case of accepting this patch, we

Re: [PHP-DEV] ext/soap and http header

2008-09-29 Thread Rasmus Lerdorf
Dmitry Stogov wrote: Hi Rasmus, Rasmus Lerdorf wrote: Dmitry Stogov wrote: Hi Brian, I think you patch does the things you like properly, but why do we need such ability? I don't see a use-case. In case of accepting this patch, we also need to care about duplicate headers. Some web services

Re: [PHP-DEV] ext/soap and http header

2008-09-29 Thread Dmitry Stogov
David Zülke wrote: > just curious, why is ext/soap internally duplicating this http stuff > instead of using the http stream stuff directly? or did I misunderstand > something? good question. :) As I remember php streams weren't able to do all necessary things which were necessary for ext/soap,

Re: [PHP-DEV] ext/soap and http header

2008-09-29 Thread David Zülke
just curious, why is ext/soap internally duplicating this http stuff instead of using the http stream stuff directly? or did I misunderstand something? Am 29.09.2008 um 10:11 schrieb Dmitry Stogov: Hi Brian, I think you patch does the things you like properly, but why do we need such

Re: [PHP-DEV] ext/soap and http header

2008-09-29 Thread Dmitry Stogov
Hi Rasmus, Rasmus Lerdorf wrote: > Dmitry Stogov wrote: >> Hi Brian, >> >> I think you patch does the things you like properly, but why do we need >> such ability? I don't see a use-case. >> >> In case of accepting this patch, we also need to care about duplicate >> headers. > > Some web services

Re: [PHP-DEV] ext/soap and http header

2008-09-29 Thread Rasmus Lerdorf
Dmitry Stogov wrote: Hi Brian, I think you patch does the things you like properly, but why do we need such ability? I don't see a use-case. In case of accepting this patch, we also need to care about duplicate headers. Some web services require custom headers for authentication or to bounce

Re: [PHP-DEV] ext/soap and http header

2008-09-29 Thread Dmitry Stogov
Hi Brian, I think you patch does the things you like properly, but why do we need such ability? I don't see a use-case. In case of accepting this patch, we also need to care about duplicate headers. Thanks. Dmitry. Brian J. France wrote: > After some more testing I needed to tweak the patch and

Re: [PHP-DEV] ext/soap and http header

2008-09-26 Thread Brian J. France
After some more testing I needed to tweak the patch and the example, here is version 2. $opts = array('http' => array('header' => 'X-foo: bar')); $ctx = stream_context_create($opts); Brian --- ext/soap/php_http.c.orig2008-09-26 05:39:50.0 -0700 +++ ext/soap/php_http.c 2008-09-2

[PHP-DEV] ext/soap and http header

2008-09-26 Thread Brian J. France
Hi, Currently there isn't a way to add http headers into a soap request. Below is a patch to get headers from the passed in context (code taken from ext/standard/http_fopen_wrapper.c). Doing something like this: $opts = array('http' => array('header' => 'X-foo: bar')); $ctx = stre