[PHP-DEV] leaks related with virtual_file_ex()

2006-09-16 Thread Nuno Lopes
Hello, There are some leaks in PHP associated with virtual_file_ex() usage. The problem is that that function doesn't free the new 'cwd' on error (path not found). Taking a look at http://lxr.php.net/ident?i=virtual_file_ex we can see the function usage. For example, expand_filepath() free()s

Re: [PHP-DEV] leaks related with virtual_file_ex()

2006-09-17 Thread Nuno Lopes
AIL PROTECTED]> To: "PHPdev" Sent: Saturday, September 16, 2006 12:35 PM Subject: [PHP-DEV] leaks related with virtual_file_ex() Hello, There are some leaks in PHP associated with virtual_file_ex() usage. The problem is that that function doesn't free the new 'cwd&#

Re: [PHP-DEV] leaks related with virtual_file_ex()

2006-09-17 Thread Ilia Alshanetsky
On 17-Sep-06, at 8:03 AM, Nuno Lopes wrote: OK, first patch to fix the 'tests/lang/bug35176.phpt' specific problem: http://mega.ist.utl.pt/~ncpl/zend_include_memleak.txt There might be other issues with virtual_file_ex() that I haven't fully tested. Can you not simply add the free before

Re: [PHP-DEV] leaks related with virtual_file_ex()

2006-09-18 Thread Nuno Lopes
On 17-Sep-06, at 8:03 AM, Nuno Lopes wrote: OK, first patch to fix the 'tests/lang/bug35176.phpt' specific problem: http://mega.ist.utl.pt/~ncpl/zend_include_memleak.txt There might be other issues with virtual_file_ex() that I haven't fully tested. Can you not simply add the free before th