Re: [PHP-DEV] patch review

2011-04-03 Thread Pierre Joye
Please post relevant comments and information to the bug report directly. It will make our work and review easier. Thanks, On Sun, Apr 3, 2011 at 2:07 PM, Tomas Kuliavas wrote: > 2011.04.03 13:58 Tomas Brastavičius rašė: >> Hi, >> >> can somebody review the following patch: >> http://bugs.php.ne

Re: [PHP-DEV] patch review

2011-04-03 Thread Tomas Kuliavas
2011.04.03 13:58 Tomas Brastavičius rašė: > Hi, > > can somebody review the following patch: > http://bugs.php.net/bug.php?id=54369 > > I am willing the bug is fixed in the next PHP release and ready to do a > job if something is wrong with the patch. Check url encoding documentation first. http:/

Re: [PHP-DEV] patch review

2011-04-03 Thread Pascal COURTOIS
Le 03/04/2011 13:30, Peter Beverloo a écrit : > The parsing change you are proposing is invalid per RFC 1738. RFC 1738 has been obsoleted by RFC 3986 http://tools.ietf.org/html/rfc3986 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.

Re: [PHP-DEV] patch review

2011-04-03 Thread Peter Beverloo
2011/4/3 Tomas Brastavičius : > Hi, > > can somebody review the following patch: > http://bugs.php.net/bug.php?id=54369 > > I am willing the bug is fixed in the next PHP release and ready to do a > job if something is wrong with the patch. > > Thank you > > Regards, > Tomas > > > -- > PHP Internals

[PHP-DEV] patch review

2011-04-03 Thread Tomas Brastavičius
Hi, can somebody review the following patch: http://bugs.php.net/bug.php?id=54369 I am willing the bug is fixed in the next PHP release and ready to do a job if something is wrong with the patch. Thank you Regards, Tomas -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe,

Re: [PHP-DEV] patch review for acinclude.m4

2003-11-13 Thread Jani Taskinen
On Thu, 13 Nov 2003, Brian J. France wrote: >> Hint: Don't compile extensions as shared..it really doesn't give >> you anything extra, just more problems like this. > >Yes, I agree that is true in almost 99.9% of all cases, but I am in that >0.1%. No point building snmp (or insert any ot

Re: [PHP-DEV] patch review for acinclude.m4

2003-11-13 Thread Rasmus Lerdorf
On Thu, 13 Nov 2003, Jani Taskinen wrote: > Hint: Don't compile extensions as shared..it really doesn't give > you anything extra, just more problems like this. Brian has a very good reason for compiling this stuff shared! ;) -Rasmus -- PHP Internals - PHP Runtime Development Mailing L

Re: [PHP-DEV] patch review for acinclude.m4

2003-11-13 Thread Brian J. France
On Thu, 13 Nov 2003 16:19:23 +0200 (EET), Jani Taskinen wrote: > On Wed, 12 Nov 2003, Brian J. France wrote: > Yes, you shouldn't pollute LIBS like that. :) > I committed a bit better fix for this. Thank you! > Hint: Don't compile extensions as shared..it really doesn't give > you

Re: [PHP-DEV] patch review for acinclude.m4

2003-11-13 Thread Jani Taskinen
On Wed, 12 Nov 2003, Brian J. France wrote: >If there are no objections I plan on committing this tomorrow on both HEAD and >PHP_4_3 branches. This fixes the openssl FreeBSD problem I posted about >earlier. > >Is there a better way of fixing it? Yes, you shouldn't pollute LIBS like that. :

[PHP-DEV] patch review for acinclude.m4

2003-11-13 Thread Brian J. France
If there are no objections I plan on committing this tomorrow on both HEAD and PHP_4_3 branches. This fixes the openssl FreeBSD problem I posted about earlier. Is there a better way of fixing it? Brian Index: acinclude.m4 === RCS