RE: [PHP-DEV] question about backward-compatibility break/bug in php 5.2.6

2008-07-25 Thread Derick Rethans
On Thu, 24 Jul 2008, Jack Steadman wrote: Thank you for taking the time to explain this to me. A couple more points below: strtotime() has always accepted month and day numbers 0 in order to express last month of the previos year and last day of the previous month. Take: So my

Re: [PHP-DEV] question about backward-compatibility break/bug in php 5.2.6

2008-07-24 Thread Christian Seiler
Hi, Last week I submitted a bug report on the issue described below. The response (also below) was that this is not a bug. I fail to see how it could *not* be a bug given that strtotime is parsing an invalid date into a seemingly-arbitrary and definitely-meaningless number, strtotime() has

RE: [PHP-DEV] question about backward-compatibility break/bug in php 5.2.6

2008-07-24 Thread Jack Steadman
Ah, yes, the change responsible is the following: http://cvs.php.net/viewvc.cgi/php-src/ext/date/lib/timelib.h? r1=1.10.2.11.2.4r2=1.10.2.11.2.5pathrev=PHP_5_2 It fixes bug #44209 http://bugs.php.net/bug.php?id=44209. OK, thanks, it's good to understand the change in behavior. Or to

Re: [PHP-DEV] question about backward-compatibility break/bug in php 5.2.6

2008-07-24 Thread Christian Seiler
Hi! This 64-bit machine is running 5.2.5 and returns false on the all-zero datetime string. It was upgraded last week to 5.2.6 and started returning the large negative integer. Ah, yes, the change responsible is the following:

Re: [PHP-DEV] question about backward-compatibility break/bug in php 5.2.6

2008-07-24 Thread Zach Shepherd
I'm not sure that there's any problem with the documentation (although it wouldn't hurt to mention it in the comments). What is it about -00-00 00:00:00 that makes it an invalid date? (See Christian's explanation) Zach On Thu, Jul 24, 2008 at 11:09 AM, Jack Steadman [EMAIL PROTECTED] wrote:

RE: [PHP-DEV] question about backward-compatibility break/bug in php 5.2.6

2008-07-24 Thread Jack Steadman
I'm not sure that there's any problem with the documentation (although it wouldn't hurt to mention it in the comments). What is it about -00-00 00:00:00 that makes it an invalid date? (See Christian's explanation) Zero values for month and day are NOT valid. PHP treats them as valid,

RE: [PHP-DEV] question about backward-compatibility break/bug in php 5.2.6

2008-07-24 Thread Jack Steadman
Thank you for taking the time to explain this to me. A couple more points below: strtotime() has always accepted month and day numbers 0 in order to express last month of the previos year and last day of the previous month. Take: So my biggest issue with this is that it's exception-case

Re: [PHP-DEV] question about backward-compatibility break/bug in php 5.2.6

2008-07-24 Thread Jordan Wambaugh
On Jul 24, 2008, at 11:30 AM, Jack Steadman wrote: The upshot is that we can't actually rely on strtotime to determine whether a string is a valid date/time. The docs don't ever explicitly say that the date strings themselves are checked for validity, but returning false on failure implies to

[PHP-DEV] question about backward-compatibility break/bug in php 5.2.6

2008-07-23 Thread Jack Steadman
Hello all, Last week I submitted a bug report on the issue described below. The response (also below) was that this is not a bug. I fail to see how it could *not* be a bug given that strtotime is parsing an invalid date into a seemingly-arbitrary and definitely-meaningless number, rather than

Re: [PHP-DEV] question about backward-compatibility break/bug in php 5.2.6

2008-07-23 Thread Tomas Kuliavas
Hello all, Last week I submitted a bug report on the issue described below. The response (also below) was that this is not a bug. I fail to see how it could *not* be a bug given that strtotime is parsing an invalid date into a seemingly-arbitrary and definitely-meaningless number, rather