[PHP-DEV] run-tests.php and dynamic extension dependencies

2015-10-23 Thread François Laupretre
Hi, 4 years ago, Derick proposed a patch to add an '--EXTENSIONS--' section in phpt files for extensions depending on another one (http://grokbase.com/t/php/php-internals/11bwptaj78/run-tests-php-and-dynamic-extension-dependencies). I don't know why, but it seems the patch was not commited.

[PHP-DEV] run-tests.php and dynamic extension dependencies

2011-11-28 Thread Derick Rethans
Hi, I'm currently writing a shared extension thta depends on another shared extension (igbinary). "make test" doesn't handle this at the moment, because it removes every extension= line from it's temporary php.ini. This means that the dependent extension (igbinary) now isn't loaded, which means

Re: [PHP-DEV] run-tests.php and dynamic extension dependencies

2015-10-23 Thread Kalle Sommer Nielsen
Hi François 2015-10-24 3:04 GMT+02:00 François Laupretre : > Hi, > > 4 years ago, Derick proposed a patch to add an '--EXTENSIONS--' section in > phpt files for extensions depending on another one > (http://grokbase.com/t/php/php-internals/11bwptaj78/run-tests-php-and-dynamic-extension-dependencie

Re: [PHP-DEV] run-tests.php and dynamic extension dependencies

2011-11-28 Thread Ferenc Kovacs
On Mon, Nov 28, 2011 at 2:11 PM, Derick Rethans wrote: > Hi, > > I'm currently writing a shared extension thta depends on another shared > extension (igbinary). "make test" doesn't handle this at the moment, > because it removes every extension= line from it's temporary php.ini. > This means that

Re: [PHP-DEV] run-tests.php and dynamic extension dependencies

2011-11-28 Thread Derick Rethans
On Mon, 28 Nov 2011, Ferenc Kovacs wrote: > On Mon, Nov 28, 2011 at 2:11 PM, Derick Rethans wrote: > > > I'm currently writing a shared extension thta depends on another > > shared extension (igbinary). "make test" doesn't handle this at the > > moment, because it removes every extension= line

Re: [PHP-DEV] run-tests.php and dynamic extension dependencies

2011-11-28 Thread Richard Quadling
On 28 November 2011 13:36, Derick Rethans wrote: > On Mon, 28 Nov 2011, Ferenc Kovacs wrote: > >> On Mon, Nov 28, 2011 at 2:11 PM, Derick Rethans wrote: >> >> > I'm currently writing a shared extension thta depends on another >> > shared extension (igbinary). "make test" doesn't handle this at th

Re: [PHP-DEV] run-tests.php and dynamic extension dependencies

2011-11-28 Thread Derick Rethans
On Mon, 28 Nov 2011, Richard Quadling wrote: > On 28 November 2011 13:36, Derick Rethans wrote: > > On Mon, 28 Nov 2011, Ferenc Kovacs wrote: > > > >> On Mon, Nov 28, 2011 at 2:11 PM, Derick Rethans wrote: > >> > >> > I'm currently writing a shared extension thta depends on another > >> > shared

Re: [PHP-DEV] run-tests.php and dynamic extension dependencies

2011-11-28 Thread Pierre Joye
hi Derick, On Mon, Nov 28, 2011 at 2:11 PM, Derick Rethans wrote: > I'm currently writing a shared extension thta depends on another shared > extension (igbinary). "make test" doesn't handle this at the moment, > because it removes every extension= line from it's temporary php.ini. > This means

Re: [PHP-DEV] run-tests.php and dynamic extension dependencies

2011-11-28 Thread Ferenc Kovacs
On Mon, Nov 28, 2011 at 2:44 PM, Derick Rethans wrote: > On Mon, 28 Nov 2011, Richard Quadling wrote: > > > On 28 November 2011 13:36, Derick Rethans wrote: > > > On Mon, 28 Nov 2011, Ferenc Kovacs wrote: > > > > > >> On Mon, Nov 28, 2011 at 2:11 PM, Derick Rethans > wrote: > > >> > > >> > I'm

Re: [PHP-DEV] run-tests.php and dynamic extension dependencies

2011-11-28 Thread Johannes Schlüter
On Mon, 2011-11-28 at 15:18 +0100, Ferenc Kovacs wrote: > + foreach ($extensions as $req_ext) { > + $loaded = `$php -n -r 'echo (int) extension_loaded("$req_ext");'`; > + if ($loaded == '0') { This should use the tmp-php.ini as that might already load the required extension if it was built in the

Re: [PHP-DEV] run-tests.php and dynamic extension dependencies

2011-11-28 Thread Derick Rethans
On Mon, 28 Nov 2011, Johannes Schlüter wrote: > On Mon, 2011-11-28 at 15:18 +0100, Ferenc Kovacs wrote: > > + foreach ($extensions as $req_ext) { > > + $loaded = `$php -n -r 'echo (int) extension_loaded("$req_ext");'`; > > + if ($loaded == '0') { > > This should use the tmp-php.ini as that might

Re: [PHP-DEV] run-tests.php and dynamic extension dependencies

2011-11-28 Thread Ferenc Kovacs
2011/11/28 Johannes Schlüter > On Mon, 2011-11-28 at 15:18 +0100, Ferenc Kovacs wrote: > > + foreach ($extensions as $req_ext) { > > + $loaded = `$php -n -r 'echo (int) extension_loaded("$req_ext");'`; > > + if ($loaded == '0') { > > This should use the tmp-php.ini as that might already load the

Re: [PHP-DEV] run-tests.php and dynamic extension dependencies

2011-11-28 Thread Pierre Joye
2011/11/28 Ferenc Kovacs : >>    run-tests.php -d extension=/path/to/extname.so >> > > yeah, but we advertise make test as the official/endorsed way to run the > test suite, so that should work. any reliable tests cannot be done using make test as long as there some random php.ini's in the system

Re: [PHP-DEV] run-tests.php and dynamic extension dependencies

2011-11-28 Thread Johannes Schlüter
On Mon, 2011-11-28 at 15:02 +, Derick Rethans wrote: > On Mon, 28 Nov 2011, Johannes Schlüter wrote: > > > On Mon, 2011-11-28 at 15:18 +0100, Ferenc Kovacs wrote: > > > + foreach ($extensions as $req_ext) { > > > + $loaded = `$php -n -r 'echo (int) extension_loaded("$req_ext");'`; > > > + if (

Re: [PHP-DEV] run-tests.php and dynamic extension dependencies

2011-11-28 Thread Derick Rethans
On Mon, 28 Nov 2011, Ferenc Kovacs wrote: > thanks for the answer, in this case I think this would be a worthwhile > improvement. > > + foreach ($extensions as $req_ext) { > + $loaded = `$php -n -r 'echo (int) extension_loaded("$req_ext");'`; > + if ($loaded == '0') { > > it would be more effici