Re: [PHP-DEV] Re: Stop Breaking Our Apps For the Sake of OO

2006-05-12 Thread Jochem Maas
Some might consider the following a rant, personally I just feel passionately about php and feel I need to speak up. that you might consider it/me irrelevant or 'moany' is your privelege - so with all due respect ( Ilia Alshanetsky wrote: On 11-May-06, at 4:37 PM, Brian Moon wrote: How did t

Re: [PHP-DEV] Re: Stop Breaking Our Apps For the Sake of OO

2006-05-12 Thread Ilia Alshanetsky
On 11-May-06, at 4:37 PM, Brian Moon wrote: How did this thread turn into complaining about tests? The complaint was about breaking working code. I don't give a crap about tests. I want my code to work. And, I believe that was the original point of this thread. Complaining about

Re: [PHP-DEV] Re: Stop Breaking Our Apps For the Sake of OO

2006-05-12 Thread David Zülke
As I already said many times, I disagree with the (recent) attitude to break things in minor releases (no matter which things). We have added an E_STRICT mode, such changes should raise a notice in E_STRICT and be what it should be in the next major version. However, if the error/notice is only a

Re: [PHP-DEV] Re: Stop Breaking Our Apps For the Sake of OO

2006-05-11 Thread Marcus Boerger
Hello bertrand, one of the thinks i work on is this: http://gcov.php.net Thursday, May 11, 2006, 11:57:09 PM, you wrote: > Marcus Boerger wrote: >> Hello bertrand, >> >> we already have an infrastructure that allows you to run tests. >> Just do: make test > I forgot the point: > I said in

Re: [PHP-DEV] Re: Stop Breaking Our Apps For the Sake of OO

2006-05-11 Thread bertrand Gugger
Marcus Boerger wrote: Hello bertrand, we already have an infrastructure that allows you to run tests. Just do: make test I forgot the point: I said infrastucture as what would need php to be complete , with a minimal build (with nothing) 45% of the tests are skipped. Anyway, unit tests are

Re: [PHP-DEV] Re: Stop Breaking Our Apps For the Sake of OO

2006-05-11 Thread bertrand Gugger
Bonsoir Marcus Boerger wrote: Hello bertrand, we already have an infrastructure that allows you to run tests. Just do: make test I guess I was aware of that, even if I'm more used to the pear format of .phpt make test is easy reporting failing ones is not I just told I would try Regards --

Re: [PHP-DEV] Re: Stop Breaking Our Apps For the Sake of OO

2006-05-11 Thread Richard Lynch
On Thu, May 11, 2006 3:58 pm, Rasmus Lerdorf wrote: > Marcus has a point here. People are complaining loudly about bugs > being > introduced. These bugs would have been found quicker if we had better > tests. If every complaint included a nice clean .phpt test file that > can be dropped right in

Re: [PHP-DEV] Re: Stop Breaking Our Apps For the Sake of OO

2006-05-11 Thread Rasmus Lerdorf
Brian Moon wrote: Marcus Boerger wrote: <[EMAIL PROTECTED]> However i said that already on IRC nobody is taking care on tests but complain is what you guys are all goo at! Instead of screaming and whining after a release you should write tests. When looking at <50% coverage from a test run and @

Re: [PHP-DEV] Re: Stop Breaking Our Apps For the Sake of OO

2006-05-11 Thread Marcus Boerger
Hello Brian, sure i wanted to express to things. First 5.2 is work in (heavy) progress and second that the lack of tests causes a bunch of unnecessary problems. That said i ask everybody again to write tests for stuff he/she doesn't like to change in case it hasn't been decided to change. best

Re: [PHP-DEV] Re: Stop Breaking Our Apps For the Sake of OO

2006-05-11 Thread Brian Moon
Marcus Boerger wrote: <[EMAIL PROTECTED]> However i said that already on IRC nobody is taking care on tests but complain is what you guys are all goo at! Instead of screaming and whining after a release you should write tests. When looking at <50% coverage from a test run and @ <5K tests for a be

Re: [PHP-DEV] Re: Stop Breaking Our Apps For the Sake of OO

2006-05-11 Thread Marcus Boerger
Hello bertrand, we already have an infrastructure that allows you to run tests. Just do: make test Thursday, May 11, 2006, 9:39:30 PM, you wrote: > Bonsoir, > Marcus Boerger wrote: >> Hello Jared, >> >> this is the first prodictive mail in this thread, we can easily >> extend the .phpt sys

Re: [PHP-DEV] Re: Stop Breaking Our Apps For the Sake of OO

2006-05-11 Thread bertrand Gugger
Bonsoir, Marcus Boerger wrote: Hello Jared, this is the first prodictive mail in this thread, we can easily extend the .phpt system to have different expectations for different versions of php. That was we can handle stuff that slightly changes like spell correction in error messages and such.

Re: [PHP-DEV] Re: Stop Breaking Our Apps For the Sake of OO

2006-05-11 Thread Marcus Boerger
Hello Jared, this is the first prodictive mail in this thread, we can easily extend the .phpt system to have different expectations for different versions of php. That was we can handle stuff that slightly changes like spell correction in error messages and such. Now not to you Jared but to all:

Re: [PHP-DEV] Re: Stop Breaking Our Apps For the Sake of OO

2006-05-11 Thread Richard Lynch
On Thu, May 11, 2006 7:47 am, Sebastian Bergmann wrote: > Maybe we could set up a testing system that runs the tests from > PHP_4_4, > PHP_5_0, PHP_5_1, and HEAD and shows the differences? That way we > would > notice that a test that passed with a previous version fails with a > newer one. +1

RE: [PHP-DEV] Re: Stop Breaking Our Apps For the Sake of OO

2006-05-11 Thread Jared Williams
> Pierre wrote: > > I forgot to mention how vicious such changes can be. Most > of times the > > related tests are "updated" in the same commit (or right after) to > > follow the new behavior. Making nearly impossible to know about the > > breakages without duplicating core tests in our apps.

Re: [PHP-DEV] Re: Stop Breaking Our Apps For the Sake of OO

2006-05-11 Thread Sebastian Bergmann
Pierre wrote: > I forgot to mention how vicious such changes can be. Most of times the > related tests are "updated" in the same commit (or right after) to > follow the new behavior. Making nearly impossible to know about the > breakages without duplicating core tests in our apps. Also commit > mes