Re: [PHP-DEV] run-tests.php exit code

2018-03-01 Thread Stanislav Malyshev
Hi! > If behavior wasn't changed unless ENV var or CLI option was specified, > then I think it can go into 7.1  (run-test.php isn't production code > part of a build, etc...). The point is to change behavior - namely, make run-tests return proper exit code even if no variables are set. True,

Re: [PHP-DEV] run-tests.php exit code

2018-03-01 Thread Matt Ficken
If behavior wasn't changed unless ENV var or CLI option was specified, then I think it can go into 7.1 (run-test.php isn't production code part of a build, etc...). Behavior remaining the same of course wouldn't break anybody's existing CI. For those who benefit from this in 7.3, they should

RE: [PHP-DEV] run-tests.php exit code

2018-03-01 Thread Anatol Belski
Hi Stas, > -Original Message- > From: Stanislav Malyshev [mailto:smalys...@gmail.com] > Sent: Wednesday, February 28, 2018 9:26 PM > To: PHP Internals > Subject: [PHP-DEV] run-tests.php exit code > > Hi! > > When running tests with run-tests.php, if the tests