On Fri, Oct 12, 2012 at 7:46 PM, Omar Ramirez Luna wrote:
> On 12 October 2012 02:48, Felipe Contreras wrote:
>> I already made most of these comments, but here they go again.
>
> I replied to all, but here it goes again:
Mostly, but not all :)
>>> @@ -142,11 +142,10 @@ static int iommu_enable(
Shuah Khan wrote:
> On Fri, 2012-10-12 at 11:38 -0700, Jonathan Nieder wrote:
>> To save Willy time: am I correct in guessing the upstream commit you
>> are referring to is 98fc5a693bbdda498a556654c70d1e31a186c988
>> (x86/amd-iommu: Use get_device_id and check_device where appropriate,
>> 2009-11-
On Fri, 2012-10-12 at 11:38 -0700, Jonathan Nieder wrote:
> Shuah Khan wrote:
>
> > This bug is in linux-2.6.32 and an equivalent fix in linux-2.6.33 and has
> > been
> > carried forward to later kernels and is in the upstream kernel. This
> > equivalent
> > fix includes restructuring and consol
Shuah Khan wrote:
> This bug is in linux-2.6.32 and an equivalent fix in linux-2.6.33 and has been
> carried forward to later kernels and is in the upstream kernel. This
> equivalent
> fix includes restructuring and consolidating device checks into a routine
> check_device(). Instead of back-port
On 12 October 2012 02:48, Felipe Contreras wrote:
> I already made most of these comments, but here they go again.
I replied to all, but here it goes again:
>> @@ -142,11 +142,10 @@ static int iommu_enable(struct omap_iommu *obj)
>> }
>> }
>>
>> - clk_enable(obj->cl
On Fri, 2012-10-12 at 10:29 -0600, Shuah Khan wrote:
> amd_iommu_attach_device() checks if device id is within the limits
> of amd_iommu_last_bdf and instead checking if devid > amd_iommu_last_bdf,
> it checks devid >= amd_iommu_last_bdf. As a result the last device attach
> fails because amd_iommu
amd_iommu_attach_device() checks if device id is within the limits
of amd_iommu_last_bdf and instead checking if devid > amd_iommu_last_bdf,
it checks devid >= amd_iommu_last_bdf. As a result the last device attach
fails because amd_iommu_attach_device() returns an -EINVAL.
This bug is in linux-2.
On Fri, Oct 12, 2012 at 3:06 AM, Omar Ramirez Luna wrote:
> Use runtime PM functionality interfaced with hwmod enable/idle
> functions, to replace direct clock operations and sysconfig
> handling.
>
> Dues to reset sequence, pm_runtime_put_sync must be used, to avoid
> possible operations with the
