Re: [PATCH 03/23] ARM: dt: tegra30: iommu: Add nvidia,memory-clients

2013-06-27 Thread Thierry Reding
On Wed, Jun 26, 2013 at 12:28:06PM +0300, Hiroshi Doyu wrote: Add nvidia,memory-clients to identify which swgroup ID a device belongs to. Why not call the property nvidia,swgid instead? That seems a lot more intuitive. Thierry pgpsrF4R4_pOe.pgp Description: PGP signature

Re: [PATCH 01/23] ARM: tegra: Create a DT header defining swgroups ID

2013-06-27 Thread Thierry Reding
On Wed, Jun 26, 2013 at 12:28:04PM +0300, Hiroshi Doyu wrote: [...] +#define SWGID_AFI 0 +#define SWGID_AVPC 1 +#define SWGID_DC 2 +#define SWGID_DCB 3 +#define SWGID_EPP 4 +#define SWGID_G2 5 +#define SWGID_HC 6 +#define SWGID_HDA 7 +#define SWGID_ISP 8 +#define SWGID_ISP2 SWGID_ISP

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-06-27 Thread Dave Young
On Fri, Jun 14, 2013 at 10:11 AM, Takao Indoh indou.ta...@jp.fujitsu.comwrote: (2013/06/13 12:41), Bjorn Helgaas wrote: On Wed, Jun 12, 2013 at 8:44 PM, Takao Indoh indou.ta...@jp.fujitsu.com wrote: (2013/06/12 13:45), Bjorn Helgaas wrote: [+cc Vivek, Haren; sorry I didn't think to add

Re: [PATCH 18/23] iommu/tegra: smmu: Workaround PCIe IOMMU'able

2013-06-27 Thread Thierry Reding
On Wed, Jun 26, 2013 at 01:09:06PM +0200, Hiroshi Doyu wrote: Thierry Reding thierry.red...@gmail.com wrote @ Wed, 26 Jun 2013 13:06:27 +0200: * PGP Signed by an unknown key On Wed, Jun 26, 2013 at 12:28:21PM +0300, Hiroshi Doyu wrote: Make PCIe work as it is. IOMMU support can be

Re: [PATCH 19/23] iommu/tegra: smmu: Unfied driver for Tegra SoCs

2013-06-27 Thread Thierry Reding
On Wed, Jun 26, 2013 at 12:28:22PM +0300, Hiroshi Doyu wrote: Support multiple generation of Tegra SoCs with this unified SMMU driver. Necessary info is expected to be passed from DT. Signed-off-by: Hiroshi Doyu hd...@nvidia.com --- drivers/iommu/tegra-smmu.c | 80

Re: [PATCH 11/23] iommu/tegra: smmu: Add of_mach_id for T114

2013-06-27 Thread Thierry Reding
On Wed, Jun 26, 2013 at 12:28:14PM +0300, Hiroshi Doyu wrote: Add of_mach_id for T114 I don't think of_mach_id is the right word. Why not use a subject such as iommu/tegra: smmu: Add Tegra114 support. And instead of duplicating the subject in the commit message, perhaps you can say instead that

Re: [PATCH 18/23] iommu/tegra: smmu: Workaround PCIe IOMMU'able

2013-06-27 Thread Thierry Reding
On Wed, Jun 26, 2013 at 12:28:21PM +0300, Hiroshi Doyu wrote: Make PCIe work as it is. IOMMU support can be implemented later. Signed-off-by: Hiroshi Doyu hd...@nvidia.com --- drivers/iommu/tegra-smmu.c | 3 +++ 1 file changed, 3 insertions(+) Can you provide more information about what

Re: [PATCH 03/23] ARM: dt: tegra30: iommu: Add nvidia,memory-clients

2013-06-27 Thread Thierry Reding
On Wed, Jun 26, 2013 at 12:28:06PM +0300, Hiroshi Doyu wrote: [...] diff --git a/Documentation/devicetree/bindings/iommu/nvidia,tegra30-smmu.txt b/Documentation/devicetree/bindings/iommu/nvidia,tegra30-smmu.txt [...] @@ -23,3 +24,13 @@ Example: nvidia,swgroups = 0x

Re: [PATCH 17/23] iommu/tegra: smmu: Use swgroups instead of pdata

2013-06-27 Thread Thierry Reding
On Wed, Jun 26, 2013 at 12:28:20PM +0300, Hiroshi Doyu wrote: Instead of using platfrom data, DT passes nvidia,swgroups. Signed-off-by: Hiroshi Doyu hd...@nvidia.com --- drivers/iommu/tegra-smmu.c | 24 +++- 1 file changed, 7 insertions(+), 17 deletions(-) Could this

Re: [PATCH 03/23] ARM: dt: tegra30: iommu: Add nvidia,memory-clients

2013-06-27 Thread Thierry Reding
On Wed, Jun 26, 2013 at 12:18:17PM +0200, Thierry Reding wrote: On Wed, Jun 26, 2013 at 12:28:06PM +0300, Hiroshi Doyu wrote: [...] diff --git a/Documentation/devicetree/bindings/iommu/nvidia,tegra30-smmu.txt b/Documentation/devicetree/bindings/iommu/nvidia,tegra30-smmu.txt [...] @@

Re: [PATCH 21/23] iommu/tegra: smmu: Get swgroup ID from DT

2013-06-27 Thread Thierry Reding
On Wed, Jun 26, 2013 at 12:28:24PM +0300, Hiroshi Doyu wrote: Get swgroup ID from DT. nvidia,swgroups indicates which swgroup IDs a device belongs to. Signed-off-by: Hiroshi Doyu hd...@nvidia.com --- arch/arm/boot/dts/tegra30.dtsi | 1 - drivers/iommu/tegra-smmu.c | 20

Re: [PATCH 02/23] ARM: dt: tegra30: iommu: Add nvidia,swgroups

2013-06-27 Thread Thierry Reding
On Wed, Jun 26, 2013 at 12:28:05PM +0300, Hiroshi Doyu wrote: This is a bitmap that indicates which HardWare Accelerators(HWA) are supported on Tegra30 SoC. Signed-off-by: Hiroshi Doyu hd...@nvidia.com --- Documentation/devicetree/bindings/iommu/nvidia,tegra30-smmu.txt | 6 +-