Hi Florian,
On 12/23/2013 03:34 PM, Florian Vaussard wrote:
Hi Suman,
On 12/23/2013 08:12 PM, Anna, Suman wrote:
Hi Florian,
On 12/17/2013 06:53 AM, Florian Vaussard wrote:
Add missing information required to probe the iommu for the camera
subsystem.
Signed-off-by: Florian Vaussard
---
Hi Florian,
>>
On 12/17/2013 06:53 AM, Florian Vaussard wrote:
OMAP2+ is heading towards a full device tree boot for 3.14. Currently,
the iommu used by the OMAP3 camera subsystem is not yet converted. It
cannot be probed as necessary data are only passed through device tree.
Patches 1 and 2 ar
Hi Florian,
>>
On 12/17/2013 06:53 AM, Florian Vaussard wrote:
As OMAP2+ is moving to a full DT boot for 3.14, commit 7ce93f3
"ARM: OMAP2+: Fix more missing data for omap3.dtsi file" adds
basic DT bits. But the driver is not yet converted, so this will
not work and driver will not be probed. Co
Hi Florian,
On 12/17/2013 06:53 AM, Florian Vaussard wrote:
Currently, bus_set_iommu() is done in omap_iommu_init(). However,
omap_iommu_probe() can fail in a number of ways, leaving the platform
bus with a dangling reference to a non-initialized iommu. Perform
bus_set_iommu() only if omap_iom
Hi Florian,
>>
On 12/17/2013 06:53 AM, Florian Vaussard wrote:
The data are now passed using the devicetree.
Patch is good by itself. A similar change is needed for the IVA
MMU as well.
As I understood, the IVA MMU is still not integrated into the iommu
core, as its implementation lives un
Hi Suman,
On 12/23/2013 08:08 PM, Anna, Suman wrote:
> Hi Florian,
>
> On 12/17/2013 06:53 AM, Florian Vaussard wrote:
>> The data are now passed using the devicetree.
>
> Patch is good by itself. A similar change is needed for the IVA
> MMU as well.
>
As I understood, the IVA MMU is still not
Hi Suman,
On 12/23/2013 08:48 PM, Anna, Suman wrote:
> Hi Florian,
>
> On 12/17/2013 06:53 AM, Florian Vaussard wrote:
>> As OMAP2+ is moving to a full DT boot for 3.14, commit 7ce93f3
>> "ARM: OMAP2+: Fix more missing data for omap3.dtsi file" adds
>> basic DT bits. But the driver is not yet con
Hi Suman,
On 12/23/2013 07:52 PM, Anna, Suman wrote:
> Hi Florian,
>
> On 12/17/2013 06:53 AM, Florian Vaussard wrote:
>> OMAP2+ is heading towards a full device tree boot for 3.14. Currently,
>> the iommu used by the OMAP3 camera subsystem is not yet converted. It
>> cannot be probed as necessary
Hi Suman,
On 12/23/2013 08:02 PM, Anna, Suman wrote:
> Hi Florian,
>
> On 12/17/2013 06:53 AM, Florian Vaussard wrote:
>> Currently, bus_set_iommu() is done in omap_iommu_init(). However,
>> omap_iommu_probe() can fail in a number of ways, leaving the platform
>> bus with a dangling reference to
Hi Suman,
On 12/23/2013 08:12 PM, Anna, Suman wrote:
> Hi Florian,
>
> On 12/17/2013 06:53 AM, Florian Vaussard wrote:
>> Add missing information required to probe the iommu for the camera
>> subsystem.
>>
>> Signed-off-by: Florian Vaussard
>> ---
>> arch/arm/boot/dts/omap3.dtsi | 4 +++-
>>
Hi Suman,
On 12/23/2013 08:05 PM, Anna, Suman wrote:
> Hi Florian,
>
> On 12/17/2013 06:53 AM, Florian Vaussard wrote:
>> When booting with a devietree, no platform data is provided. Do not
>> prematurely
>> exit iommu_enable() and iommu_disable() in such a case.
>
> Platform data may still be n
Hi Florian,
On 12/17/2013 06:53 AM, Florian Vaussard wrote:
As OMAP2+ is moving to a full DT boot for 3.14, commit 7ce93f3
"ARM: OMAP2+: Fix more missing data for omap3.dtsi file" adds
basic DT bits. But the driver is not yet converted, so this will
not work and driver will not be probed. Conver
Hi Florian,
On 12/17/2013 06:53 AM, Florian Vaussard wrote:
Add missing information required to probe the iommu for the camera
subsystem.
Signed-off-by: Florian Vaussard
---
arch/arm/boot/dts/omap3.dtsi | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts
Hi Florian,
On 12/17/2013 06:53 AM, Florian Vaussard wrote:
The data are now passed using the devicetree.
Patch is good by itself. A similar change is needed for the IVA
MMU as well.
regards
Suman
Signed-off-by: Florian Vaussard
---
arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 8 ---
Hi Florian,
On 12/17/2013 06:53 AM, Florian Vaussard wrote:
When booting with a devietree, no platform data is provided. Do not prematurely
exit iommu_enable() and iommu_disable() in such a case.
Platform data may still be needed if we were to go with the pdata quirks
approach for handling re
Hi Florian,
On 12/17/2013 06:53 AM, Florian Vaussard wrote:
Currently, bus_set_iommu() is done in omap_iommu_init(). However,
omap_iommu_probe() can fail in a number of ways, leaving the platform
bus with a dangling reference to a non-initialized iommu. Perform
bus_set_iommu() only if omap_iommu
Hi Florian,
On 12/17/2013 06:53 AM, Florian Vaussard wrote:
OMAP2+ is heading towards a full device tree boot for 3.14. Currently,
the iommu used by the OMAP3 camera subsystem is not yet converted. It
cannot be probed as necessary data are only passed through device tree.
Patches 1 and 2 are sm
On 12/17/2013 06:53 AM, Florian Vaussard wrote:
omap_iommu_attach() returns NULL or ERR_PTR in case of error, but
omap_iommu_attach_dev() only checks for IS_ERR. Thus a NULL return value (in
case driver_find_device fails) will cause the kernel to panic when
omap_iommu_attach_dev() dereferences th
Mark functions int get_irte() and ir_dev_scope_init() as static in
intel_irq_remapping.c because they are not used outside this file.
This eliminates the following warnings in intel_irq_remapping.c:
drivers/iommu/intel_irq_remapping.c:49:5: warning: no previous prototype for
‘get_irte’ [-Wmissing
Mark the functions check_zero_address() and dmar_get_fault_reason() as
static in dmar.c because they are not used outside this file.
This eliminates the following warnings in dmar.c:
drivers/iommu/dmar.c:491:12: warning: no previous prototype for
‘check_zero_address’ [-Wmissing-prototypes]
driver
David,
Any comments on this patch? Thanks,
Alex
On Tue, 2013-10-29 at 10:21 -0600, Alex Williamson wrote:
> The setting of the SNP bit in the intel-iommu page tables should not
> be dependent on the current capability of the iommu domain. The
> current VT-d spec (2.2) indicates the SNP bit is
Mark function eoi_ioapic_pin_remapped() as static in irq_remapping.c
because it is not used outside this file.
This eliminates the following warning in
irq_remapping.c:drivers/iommu/irq_remapping.c:153:6: warning: no
previous prototype for ‘eoi_ioapic_pin_remapped’ [-Wmissing-prototypes]
Signed-o
22 matches
Mail list logo
