RE: [PATCH] iommu: fsl_pamu.c: Fix for possible null pointer dereference

2014-05-21 Thread Varun Sethi
> -Original Message- > From: iommu-boun...@lists.linux-foundation.org [mailto:iommu- > boun...@lists.linux-foundation.org] On Behalf Of > bharat.bhus...@freescale.com > Sent: Wednesday, May 21, 2014 9:28 AM > To: Rickard Strandqvist; Joerg Roedel; Grant Likely > Cc: devicet...@vger.kernel

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-21 Thread Thierry Reding
On Tue, May 20, 2014 at 10:31:29PM +0200, Arnd Bergmann wrote: > On Tuesday 20 May 2014 16:00:02 Thierry Reding wrote: > > On Tue, May 20, 2014 at 03:34:46PM +0200, Arnd Bergmann wrote: > > > On Tuesday 20 May 2014 15:17:43 Thierry Reding wrote: > > > > On Tue, May 20, 2014 at 02:41:18PM +0200, Arn

Re: [PATCH v3] PCI: Introduce new device binding path using pci_dev.driver_override

2014-05-21 Thread Alexander Graf
On 20.05.14 16:53, Alex Williamson wrote: The driver_override field allows us to specify the driver for a device rather than relying on the driver to provide a positive match of the device. This shortcuts the existing process of looking up the vendor and device ID, adding them to the driver new

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-21 Thread Thierry Reding
On Tue, May 20, 2014 at 10:26:12PM +0200, Arnd Bergmann wrote: > On Tuesday 20 May 2014 16:24:59 Dave Martin wrote: > > On Tue, May 20, 2014 at 02:41:18PM +0200, Arnd Bergmann wrote: > > > On Tuesday 20 May 2014 14:02:43 Thierry Reding wrote: [...] > > > > Multiple-master IOMMU: > > > > ---

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-21 Thread Arnd Bergmann
On Wednesday 21 May 2014 10:26:11 Thierry Reding wrote: > On Tue, May 20, 2014 at 10:26:12PM +0200, Arnd Bergmann wrote: > > On Tuesday 20 May 2014 16:24:59 Dave Martin wrote: > > > On Tue, May 20, 2014 at 02:41:18PM +0200, Arnd Bergmann wrote: > > > > On Tuesday 20 May 2014 14:02:43 Thierry Reding

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-21 Thread Arnd Bergmann
On Wednesday 21 May 2014 10:16:09 Thierry Reding wrote: > On Tue, May 20, 2014 at 10:31:29PM +0200, Arnd Bergmann wrote: > > On Tuesday 20 May 2014 16:00:02 Thierry Reding wrote: > > > On Tue, May 20, 2014 at 03:34:46PM +0200, Arnd Bergmann wrote: > > > > On Tuesday 20 May 2014 15:17:43 Thierry Red

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-21 Thread Thierry Reding
On Wed, May 21, 2014 at 10:50:38AM +0200, Arnd Bergmann wrote: > On Wednesday 21 May 2014 10:26:11 Thierry Reding wrote: > > On Tue, May 20, 2014 at 10:26:12PM +0200, Arnd Bergmann wrote: > > > On Tuesday 20 May 2014 16:24:59 Dave Martin wrote: > > > > On Tue, May 20, 2014 at 02:41:18PM +0200, Arnd

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-21 Thread Thierry Reding
On Wed, May 21, 2014 at 10:54:42AM +0200, Arnd Bergmann wrote: > On Wednesday 21 May 2014 10:16:09 Thierry Reding wrote: > > On Tue, May 20, 2014 at 10:31:29PM +0200, Arnd Bergmann wrote: > > > On Tuesday 20 May 2014 16:00:02 Thierry Reding wrote: > > > > On Tue, May 20, 2014 at 03:34:46PM +0200, A

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-21 Thread Arnd Bergmann
On Wednesday 21 May 2014 11:02:45 Thierry Reding wrote: > On Wed, May 21, 2014 at 10:54:42AM +0200, Arnd Bergmann wrote: > > > Right. As long as we always unmap the buffers from the IOMMU after they > > have stopped being in use, it's very unlikely that even a broken device > > driver causes a DMA

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-21 Thread Arnd Bergmann
On Wednesday 21 May 2014 11:00:38 Thierry Reding wrote: > On Wed, May 21, 2014 at 10:50:38AM +0200, Arnd Bergmann wrote: > > On Wednesday 21 May 2014 10:26:11 Thierry Reding wrote: > > > > > For determining dma masks, it is the output address that it > > > > > important. Santosh's code can probab

[git pull] IOMMU Fixes for Linux v3.15-rc5

2014-05-21 Thread Joerg Roedel
Hi Linus, The following changes since commit d6d211db37e75de2ddc3a4f979038c40df7cc79c: Linux 3.15-rc5 (2014-05-09 13:10:52 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git tags/iommu-fixes-v3.15-rc5 for you to fetch changes up to

Re: [PATCH] iommu/intel: Exclude devices using RMRRs from IOMMU API domains

2014-05-21 Thread David Woodhouse
On Wed, 2014-05-14 at 13:27 -0600, Alex Williamson wrote: > The user of the IOMMU API domain expects to have full control of > the IOVA space for the domain. RMRRs are fundamentally incompatible > with that idea. We can neither map the RMRR into the IOMMU API > domain, nor can we guarantee that t

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-21 Thread Thierry Reding
On Wed, May 21, 2014 at 11:36:32AM +0200, Arnd Bergmann wrote: > On Wednesday 21 May 2014 11:00:38 Thierry Reding wrote: > > On Wed, May 21, 2014 at 10:50:38AM +0200, Arnd Bergmann wrote: > > > On Wednesday 21 May 2014 10:26:11 Thierry Reding wrote: > > > > > > > For determining dma masks, it is t

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-21 Thread Arnd Bergmann
On Wednesday 21 May 2014 12:50:38 Thierry Reding wrote: > On Wed, May 21, 2014 at 11:36:32AM +0200, Arnd Bergmann wrote: > > On Wednesday 21 May 2014 11:00:38 Thierry Reding wrote: > > > On Wed, May 21, 2014 at 10:50:38AM +0200, Arnd Bergmann wrote: > > > > On Wednesday 21 May 2014 10:26:11 Thierry

Re: [PATCH] iommu/intel: Exclude devices using RMRRs from IOMMU API domains

2014-05-21 Thread Alex Williamson
On Wed, 2014-05-21 at 11:38 +0100, David Woodhouse wrote: > On Wed, 2014-05-14 at 13:27 -0600, Alex Williamson wrote: > > The user of the IOMMU API domain expects to have full control of > > the IOVA space for the domain. RMRRs are fundamentally incompatible > > with that idea. We can neither map

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-21 Thread Grant Grundler
On Wed, May 21, 2014 at 2:32 AM, Arnd Bergmann wrote: > On Wednesday 21 May 2014 11:02:45 Thierry Reding wrote: >> On Wed, May 21, 2014 at 10:54:42AM +0200, Arnd Bergmann wrote: >> >> > Right. As long as we always unmap the buffers from the IOMMU after they >> > have stopped being in use, it's ver

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-21 Thread Arnd Bergmann
On Wednesday 21 May 2014 08:44:42 Grant Grundler wrote: > On Wed, May 21, 2014 at 2:32 AM, Arnd Bergmann wrote: > > On Wednesday 21 May 2014 11:02:45 Thierry Reding wrote: > >> On Wed, May 21, 2014 at 10:54:42AM +0200, Arnd Bergmann wrote: > >> > >> > Right. As long as we always unmap the buffers

Re: [PATCH v2 00/10] Renesas ipmmu-vmsa: Miscellaneous cleanups and fixes

2014-05-21 Thread Laurent Pinchart
Hi Joerg, Ping ? On Thursday 15 May 2014 12:40:41 Laurent Pinchart wrote: > Hello, > > This patch set cleans up and fixes small issues in the ipmmu-vmsa driver. > The patches are based on top of "[PATCH v3] iommu: Add driver for Renesas > VMSA-compatible IPMMU" that adds the ipmmu-vmsa driver. >

Re: [PATCH] iommu/intel: Exclude devices using RMRRs from IOMMU API domains

2014-05-21 Thread Linda Knippers
On 5/21/2014 9:20 AM, Alex Williamson wrote: > On Wed, 2014-05-21 at 11:38 +0100, David Woodhouse wrote: >> On Wed, 2014-05-14 at 13:27 -0600, Alex Williamson wrote: >>> The user of the IOMMU API domain expects to have full control of >>> the IOVA space for the domain. RMRRs are fundamentally inco

Re: [PATCH] iommu/intel: Exclude devices using RMRRs from IOMMU API domains

2014-05-21 Thread David Woodhouse
On Wed, 2014-05-21 at 13:05 -0400, Linda Knippers wrote: > > > Exactly, I have a hard time bringing myself to care about supporting > > such devices. Vendors that proliferate RMRR usage need to be aware of > > the implications of RMRRs for all use cases of a device. First and > > foremost, we ne

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-21 Thread Dave Martin
On Wed, May 21, 2014 at 11:00:38AM +0200, Thierry Reding wrote: > On Wed, May 21, 2014 at 10:50:38AM +0200, Arnd Bergmann wrote: > > On Wednesday 21 May 2014 10:26:11 Thierry Reding wrote: > > > On Tue, May 20, 2014 at 10:26:12PM +0200, Arnd Bergmann wrote: > > > > On Tuesday 20 May 2014 16:24:59 D

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-21 Thread Arnd Bergmann
On Wednesday 21 May 2014 18:09:54 Dave Martin wrote: > On Wed, May 21, 2014 at 11:00:38AM +0200, Thierry Reding wrote: > > On Wed, May 21, 2014 at 10:50:38AM +0200, Arnd Bergmann wrote: > > > On Wednesday 21 May 2014 10:26:11 Thierry Reding wrote: > > > > > > > > Similarily, should the IOMMU not b

[PATCH 1/3] iommu/exynos: Remove invalid symbol dependency

2014-05-21 Thread Sachin Kamat
EXYNOS_DEV_SYSMMU symbol is not defined anywhere and prevents building the Exynos driver. Remove it. Signed-off-by: Sachin Kamat --- drivers/iommu/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig index df56e4c74a7e..b067

[PATCH 2/3] iommu/exynos: Fix trivial typo

2014-05-21 Thread Sachin Kamat
Fix typo and add missing punctuation. Signed-off-by: Sachin Kamat --- drivers/iommu/Kconfig | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig index b067a62263d1..422807ff0999 100644 --- a/drivers/iommu/Kconfig +++ b/d

[PATCH 3/3] iommu/exynos: Fix checkpatch warning

2014-05-21 Thread Sachin Kamat
Silences the following type of warnings: WARNING: Missing a blank line after declarations Signed-off-by: Sachin Kamat --- drivers/iommu/exynos-iommu.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index 09f69b1d80fc..99054d2