Re: [Patch Part3 V5 8/8] pci, ACPI, iommu: Enhance pci_root to support DMAR device hotplug

2014-09-14 Thread Yijing Wang
On 2014/9/12 10:10, Jiang Liu wrote: > Finally enhance pci_root driver to support DMAR device hotplug when > hot-plugging PCI host bridges. Reviewed-by: Yijing Wang > > Signed-off-by: Jiang Liu > --- > drivers/acpi/pci_root.c | 16 ++-- > 1 file changed, 14 insertions(+), 2 dele

Re: [Patch Part3 V5 7/8] iommu/vt-d: Enhance intel-iommu driver to support DMAR unit hotplug

2014-09-14 Thread Yijing Wang
On 2014/9/12 10:10, Jiang Liu wrote: > Implement required callback functions for intel-iommu driver > to support DMAR unit hotplug. > Reviewed-by: Yijing Wang > Signed-off-by: Jiang Liu > --- > drivers/iommu/intel-iommu.c | 206 > +++ > 1 file changed

Re: [RFC][PATCH] devicetree: Add master-id-bits property to the iommu device

2014-09-14 Thread Arnd Bergmann
On Sunday 14 September 2014, Varun Sethi wrote: > "master-id-bits" property added to the IOMMU device node. This property can > be used by the IOMMU driver to match relevan bits in the master id expressed > by a DMA master. > > This can be used to mask out certain bits that get added to the device

Re: [Patch Part3 V5 6/8] iommu/vt-d: Enhance error recovery in function intel_enable_irq_remapping()

2014-09-14 Thread Yijing Wang
On 2014/9/12 10:10, Jiang Liu wrote: > Enhance error recovery in function intel_enable_irq_remapping() > by tearing down all created data structures. > > Signed-off-by: Jiang Liu > --- > drivers/iommu/intel_irq_remapping.c |8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > d

Re: [Patch Part3 V5 5/8] iommu/vt-d: Enhance intel_irq_remapping driver to support DMAR unit hotplug

2014-09-14 Thread Yijing Wang
> +static void ir_remove_ioapic_hpet_scope(struct intel_iommu *iommu) > +{ > + int i; > > - ir_parse_one_hpet_scope(scope, iommu); > - } > - start += scope->length; > - } > + for (i = 0; i < MAX_HPET_TBS; i++) > + if (ir_hpet[i].

Re: [Patch Part3 V5 4/8] iommu/vt-d: Search for ACPI _DSM method for DMAR hotplug

2014-09-14 Thread Yijing Wang
On 2014/9/12 10:10, Jiang Liu wrote: > According to Intel VT-d specification, _DSM method to support DMAR > hotplug should exist directly under corresponding ACPI object > representing PCI host bridge. But some BIOSes doesn't conform to > this, so search for _DSM method in the subtree starting from

Re: [Patch Part3 V5 3/8] iommu/vt-d: Implement DMAR unit hotplug framework

2014-09-14 Thread Yijing Wang
On 2014/9/12 10:10, Jiang Liu wrote: > On Intel platforms, an IO Hub (PCI/PCIe host bridge) may contain DMAR > units, so we need to support DMAR hotplug when supporting PCI host > bridge hotplug on Intel platforms. > > According to Section 8.8 "Remapping Hardware Unit Hot Plug" in "Intel > Virtual

[RFC][PATCH] devicetree: Add master-id-bits property to the iommu device

2014-09-14 Thread Varun Sethi
"master-id-bits" property added to the IOMMU device node. This property can be used by the IOMMU driver to match relevan bits in the master id expressed by a DMA master. This can be used to mask out certain bits that get added to the device master id due to IOMMU topology. For example, in case of