Re: [PATCH v2 1/6] vfio: implement iommu driver capabilities with an enum

2014-10-31 Thread Alex Williamson
On Mon, 2014-10-27 at 19:05 +0100, Antonios Motakis wrote: > Currently a VFIO driver's IOMMU capabilities are encoded as a series of > numerical defines. Replace this with an enum for future maintainability. > > Signed-off-by: Antonios Motakis > --- > include/uapi/linux/vfio.h | 21 ++---

Re: [PATCH v9 10/19] vfio/platform: return IRQ info

2014-10-31 Thread Alex Williamson
On Mon, 2014-10-27 at 19:07 +0100, Antonios Motakis wrote: > Return information for the interrupts exposed by the device. > This patch extends VFIO_DEVICE_GET_INFO with the number of IRQs > and enables VFIO_DEVICE_GET_IRQ_INFO. > > Signed-off-by: Antonios Motakis > --- > drivers/vfio/platform/Ma

Re: [PATCH v9 15/19] vfio: add local lock in virqfd instead of depending on VFIO PCI

2014-10-31 Thread Alex Williamson
On Mon, 2014-10-27 at 19:08 +0100, Antonios Motakis wrote: > Virqfd just needs to keep accesses to any struct *virqfd safe, but this > comes into play only when creating or destroying eventfds, so sharing > the same spinlock with the VFIO bus driver is not necessary. > > Signed-off-by: Antonios Mo

Re: [PATCH v9 12/19] vfio/platform: trigger an interrupt via eventfd

2014-10-31 Thread Alex Williamson
On Mon, 2014-10-27 at 19:07 +0100, Antonios Motakis wrote: > This patch allows to set an eventfd for a patform device's interrupt, > and also to trigger the interrupt eventfd from userspace for testing. > Level sensitive interrupts are marked as maskable and are handled in > a later patch. Edge tri

Re: [PATCH v9 13/19] vfio/platform: support for level sensitive interrupts

2014-10-31 Thread Alex Williamson
On Mon, 2014-10-27 at 19:07 +0100, Antonios Motakis wrote: > Level sensitive interrupts are exposed as maskable and automasked > interrupts and are masked and disabled automatically when they fire. > > Signed-off-by: Antonios Motakis > --- > drivers/vfio/platform/vfio_platform_irq.c | 102 >

Re: [PATCH v9 07/19] vfio/platform: return info for device memory mapped IO regions

2014-10-31 Thread Alex Williamson
On Mon, 2014-10-27 at 19:07 +0100, Antonios Motakis wrote: > This patch enables the IOCTLs VFIO_DEVICE_GET_REGION_INFO ioctl call, > which allows the user to learn about the available MMIO resources of > a device. > > Signed-off-by: Antonios Motakis > --- > drivers/vfio/platform/vfio_platform_co

Re: [PATCH v9 04/19] vfio: amba: VFIO support for AMBA devices

2014-10-31 Thread Alex Williamson
On Mon, 2014-10-27 at 19:07 +0100, Antonios Motakis wrote: > Add support for discovering AMBA devices with VFIO and handle them > similarly to Linux platform devices. > > Signed-off-by: Antonios Motakis > --- > drivers/vfio/platform/vfio_amba.c | 116 > ++ >

Re: [PATCH v9 17/19] vfio: virqfd: add vfio_ prefix to virqfd_enable and virqfd_disable

2014-10-31 Thread Antonios Motakis
On Mon, Oct 27, 2014 at 9:12 PM, Bjorn Helgaas wrote: > On Mon, Oct 27, 2014 at 12:08 PM, Antonios Motakis > wrote: >> The virqfd_enable and virqfd_disable functions are now global. Add the >> vfio_ prefix to those functions. > > Wouldn't it be better to change the name *before* making them globa

Re: [PATCH v9 14/19] vfio: move eventfd support code for VFIO_PCI to a separate file

2014-10-31 Thread Antonios Motakis
On Mon, Oct 27, 2014 at 8:16 PM, Bjorn Helgaas wrote: > Hi Antonios, > > On Mon, Oct 27, 2014 at 12:07 PM, Antonios Motakis > wrote: >> The virqfd functionality that is used by VFIO_PCI to implement interrupt >> masking and unmasking via an eventfd, is generic enough and can be reused >> by anoth

Re: [RFC PATCH v2 0/4] vfio: platform: return device tree info for a platform device node

2014-10-31 Thread Antonios Motakis
On Wed, Oct 22, 2014 at 11:56 PM, Alex Williamson wrote: > On Thu, 2014-10-16 at 17:54 +0200, Antonios Motakis wrote: >> This RFC's intention is to show what an interface to access device node >> properties for the VFIO platform driver can look like. >> >> If a device tree node corresponding to a

Re: [Patch Part2 v3 15/24] x86, MSI: Use hierarchy irqdomain to manage MSI interrupts

2014-10-31 Thread Thomas Gleixner
On Fri, 31 Oct 2014, Jiang Liu wrote: > On 2014/10/29 5:37, Thomas Gleixner wrote: > > Then it calls down the domain allocation chain. x86_msi_domain would > > simply hand down to the parent domain. That would either be the remap > > domain or the vector domain. > The issue here is that, the hierar

Re: [PATCH v4 05/12] memory: Add NVIDIA Tegra memory controller support

2014-10-31 Thread Thierry Reding
On Thu, Oct 30, 2014 at 04:08:41PM +0100, Thierry Reding wrote: > On Wed, Oct 15, 2014 at 03:09:30PM -0700, Olof Johansson wrote: > > Hi, > > > > Oh, a few more comments: > > > > On Mon, Oct 13, 2014 at 3:33 AM, Thierry Reding > > wrote: > > > > > diff --git a/drivers/memory/Makefile b/drivers/

Re: [Patch Part2 v3 15/24] x86, MSI: Use hierarchy irqdomain to manage MSI interrupts

2014-10-31 Thread Jiang Liu
On 2014/10/29 5:37, Thomas Gleixner wrote: > On Tue, 28 Oct 2014, Jiang Liu wrote: >> @@ -166,25 +264,59 @@ int setup_msi_irq(struct pci_dev *dev, struct msi_desc >> *msidesc, >> >> int native_setup_msi_irqs(struct pci_dev *dev, int nvec, int type) >> { >> -struct msi_desc *msidesc; >> -