> -Original Message-
> From: David Woodhouse [mailto:dw...@infradead.org]
> Sent: Wednesday, January 28, 2015 11:27 PM
> To: Wu, Feng
> Cc: t...@linutronix.de; mi...@redhat.com; h...@zytor.com; x...@kernel.org;
> g...@kernel.org; pbonz...@redhat.com; j...@8bytes.org;
> alex.william...@red
Hi Will,
On Wednesday 28 January 2015 13:32:19 Will Deacon wrote:
> On Wed, Jan 28, 2015 at 01:15:10PM +, Laurent Pinchart wrote:
> > On Wednesday 28 January 2015 12:29:42 Will Deacon wrote:
> >> On Wed, Jan 28, 2015 at 12:23:03PM +, Laurent Pinchart wrote:
> >>> On Wednesday 28 January 20
On 01/28/2015 10:45 AM, Rob Herring wrote:
On Wed, Jan 28, 2015 at 5:05 AM, Catalin Marinas
wrote:
On Tue, Jan 27, 2015 at 06:55:15PM +, Murali Karicheri wrote:
On 01/27/2015 06:27 AM, Robin Murphy wrote:
On 23/01/15 22:32, Murali Karicheri wrote:
Fix the dma-range size when the DT attr
On Wed, Jan 28, 2015 at 03:55:57PM +, Robin Murphy wrote:
> On 28/01/15 11:05, Catalin Marinas wrote:
> > On Tue, Jan 27, 2015 at 06:55:15PM +, Murali Karicheri wrote:
> >> How about having the logic like this?
> >>
> >>ret = of_dma_get_range(np, &dma_addr, &paddr, &size);
> >>if (r
On Wed, Jan 28, 2015 at 03:45:19PM +, Rob Herring wrote:
> On Wed, Jan 28, 2015 at 5:05 AM, Catalin Marinas
> wrote:
> > On Tue, Jan 27, 2015 at 06:55:15PM +, Murali Karicheri wrote:
> >> How about having the logic like this?
> >>
> >> ret = of_dma_get_range(np, &dma_addr, &paddr, &s
On 28/01/15 11:05, Catalin Marinas wrote:
On Tue, Jan 27, 2015 at 06:55:15PM +, Murali Karicheri wrote:
On 01/27/2015 06:27 AM, Robin Murphy wrote:
On 23/01/15 22:32, Murali Karicheri wrote:
Fix the dma-range size when the DT attribute is missing. i.e set size to
dev->coherent_dma_mask + 1
On Wed, Jan 28, 2015 at 5:05 AM, Catalin Marinas
wrote:
> On Tue, Jan 27, 2015 at 06:55:15PM +, Murali Karicheri wrote:
>> On 01/27/2015 06:27 AM, Robin Murphy wrote:
>> > On 23/01/15 22:32, Murali Karicheri wrote:
>> >> Fix the dma-range size when the DT attribute is missing. i.e set size to
On Fri, 2014-12-12 at 23:15 +0800, Feng Wu wrote:
> Enable VT-d Posted-Interrtups and add a command line
> parameter for it.
>
> Signed-off-by: Feng Wu
Acked-by: David Woodhouse
--
David WoodhouseOpen Source Technology Centre
david.woodho...@intel.com
On Fri, 2014-12-12 at 23:14 +0800, Feng Wu wrote:
> Add the Intel side implementation for capability in
> struct irq_remap_ops.
>
> Signed-off-by: Feng Wu
> Reviewed-by: Jiang Liu
> +static bool intel_irq_remapping_capability(enum irq_remap_cap cap)
> +{
> + struct dmar_drhd_unit *drhd;
> +
On Fri, 2014-12-12 at 23:14 +0800, Feng Wu wrote:
> Add helper function to detect VT-d Posted-Interrupts capability.
>
> Signed-off-by: Feng Wu
> Reviewed-by: Jiang Liu
Acked-by: David Woodhouse
--
David WoodhouseOpen Source Technology Centre
david.woodho...@intel
On 01/28/2015 06:21 AM, Robin Murphy wrote:
Hi Murali,
[sorry, missed replying to yesterday's version]
On 27/01/15 21:00, Murali Karicheri wrote:
Fix the dma-range size when the DT attribute is missing. i.e set size to
dev->coherent_dma_mask + 1 instead of dev->coherent_dma_mask. Also add
code
On Fri, 2014-12-12 at 23:14 +0800, Feng Wu wrote:
> We don't need to migrate the irqs for VT-d Posted-Interrupts here.
> When 'pst' is set in IRTE, the associated irq will be posted to
> guests instead of interrupt remapping. The destination of the
> interrupt is set in Posted-Interrupts Descriptor
On Fri, 2014-12-12 at 23:14 +0800, Feng Wu wrote:
> Add a new irte_pi structure for VT-d Posted-Interrupts.
>
> Signed-off-by: Feng Wu
> Reviewed-by: Jiang Liu
I think it makes most sense for this to go along with the other patches
rather than through me, and I'm happy for it to do so.
--
Dav
On Fri, 2014-12-12 at 23:14 +0800, Feng Wu wrote:
> Implement irq_set_vcpu_affinity for intel_ir_chip.
>
> Signed-off-by: Feng Wu
> Reviewed-by: Jiang Liu
Acked-by: David.Woodhouse assuming a
suitable answer to...
> + vcpu_pi_info = (struct vcpu_data *)vcpu_info;
> + m
On Fri, 2014-12-12 at 23:14 +0800, Feng Wu wrote:
> This patch adds a new member capability to struct irq_remap_ops,
> this new function ops can be used to check whether some
> features are supported, such as VT-d Posted-Interrupts.
> + /* Check some capability is supported */
> + bool (*c
On 01/28/2015 08:32 AM, Will Deacon wrote:
On Wed, Jan 28, 2015 at 01:15:10PM +, Laurent Pinchart wrote:
On Wednesday 28 January 2015 12:29:42 Will Deacon wrote:
On Wed, Jan 28, 2015 at 12:23:03PM +, Laurent Pinchart wrote:
On Wednesday 28 January 2015 11:33:00 Will Deacon wrote:
On M
On 28/01/15 14:30, Will Deacon wrote:
On Tue, Jan 27, 2015 at 12:08:56AM +, Joerg Roedel wrote:
From: Joerg Roedel
The default domain will be used (if supported by the iommu
driver) when the devices in the iommu group are not attached
to any other domain.
Signed-off-by: Joerg Roedel
---
CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*data)...) over
kzalloc(sizeof(struct pamu_isr_data)...)
+ data = kzalloc(sizeof(struct pamu_isr_data), GFP_KERNEL);
CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*dma_domain->win_arr)...) over
kzalloc(sizeof(struct dma_window)...)
+
WARNING:ALLOC_WITH_MULTIPLY: Prefer kcalloc over kzalloc with multiply
+ dma_domain->win_arr = kzalloc(sizeof(*dma_domain->win_arr) *
+ w_count, GFP_ATOMIC);
Signed-off-by: Emil Medve
---
drivers/iommu/fsl_pamu_domain.c | 5 ++
Signed-off-by: Emil Medve
---
drivers/iommu/fsl_pamu.c| 4 ++--
drivers/iommu/fsl_pamu.h| 4 ++--
drivers/iommu/fsl_pamu_domain.c | 8
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c
index 7a4665d..ea49d9f
drivers/iommu/fsl_pamu_domain.c:859:2-3: Unneeded semicolon
drivers/iommu/fsl_pamu_domain.c:833:2-3: Unneeded semicolon
Signed-off-by: Emil Medve
---
drivers/iommu/fsl_pamu_domain.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iommu/fsl_pamu_domain.c b/drivers/
drivers/iommu/fsl_pamu.c:78:17: warning: symbol 'spaace_pool' was not declared.
Should it be static?
drivers/iommu/fsl_pamu.c:762:13: warning: symbol 'pamu_av_isr' was not
declared. Should it be static?
Signed-off-by: Emil Medve
---
drivers/iommu/fsl_pamu.c | 4 ++--
1 file changed, 2 insertio
Signed-off-by: Emil Medve
---
drivers/iommu/fsl_pamu.h| 2 +-
drivers/iommu/fsl_pamu_domain.c | 15 ++-
2 files changed, 7 insertions(+), 10 deletions(-)
diff --git a/drivers/iommu/fsl_pamu.h b/drivers/iommu/fsl_pamu.h
index 04dcd25..342ac6d 100644
--- a/drivers/iommu/fsl_pa
Signed-off-by: Emil Medve
---
drivers/iommu/fsl_pamu.c| 24
drivers/iommu/fsl_pamu_domain.c | 6 +++---
2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c
index dc3955f..ba5d1e0 100644
--- a/driver
drivers/iommu/fsl_pamu.c:532:72: warning: Using plain integer as NULL pointer
drivers/iommu/fsl_pamu.c:559:72: warning: Using plain integer as NULL pointer
drivers/iommu/fsl_pamu.c:570:66: warning: Using plain integer as NULL pointer
Signed-off-by: Emil Medve
---
drivers/iommu/fsl_pamu.c | 6 +++
Signed-off-by: Emil Medve
---
drivers/iommu/fsl_pamu.c | 27 ++-
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c
index 652c34d..7d9f8a0 100644
--- a/drivers/iommu/fsl_pamu.c
+++ b/drivers/iommu/fsl_pamu.c
WARNING:LEADING_SPACE: please, no spaces at the start of a line
+ return __ffs(subwindow_cnt) - 1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
+(PAACE_ATM_WINDOW_XLATE | PAACE_ATM_PAGE_XLATE)$
Signed-off-by: Emil Medve
---
drivers/iommu/fsl_pamu.c | 4
WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a
quoted newline
+ pr_debug("Invalid window size \n");
Signed-off-by: Emil Medve
---
drivers/iommu/fsl_pamu_domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/fsl_pamu_d
ERROR:CODE_INDENT: code indent should use tabs where possible
+^I stash_dest_hint, vcpu);$
ERROR:CODE_INDENT: code indent should use tabs where possible
+^I phys_addr_t ppaact_phys, phys_addr_t spaact_phys,$
ERROR:CODE_INDENT: code indent should use tabs where possible
+^I^I
Only pr_*() here
WARNING:LONG_LINE: line over 80 characters
+ pr_debug("window size too small or not a power of two %pa\n",
&win_size);
WARNING:LONG_LINE: line over 80 characters
+ pr_debug("missing cache-stash-id at %s\n",
node->full_name);
ARNING:L
drivers/iommu/fsl_pamu_domain.c:884:9-10: WARNING: return of 0/1 in function
'check_pci_ctl_endpt_part' with return type bool
Signed-off-by: Emil Medve
---
drivers/iommu/fsl_pamu_domain.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/iommu/fsl_pamu_domain.c b/d
Signed-off-by: Emil Medve
---
drivers/iommu/fsl_pamu.c| 12 ++--
drivers/iommu/fsl_pamu_domain.c | 2 +-
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c
index d958e65..652c34d 100644
--- a/drivers/iommu/fsl_pamu.c
WARNING:OOM_MESSAGE: Possible unnecessary 'out of memory' message
+ if (!data) {
+ dev_err(&pdev->dev, "PAMU isr data memory allocation failed\n");
Signed-off-by: Emil Medve
---
drivers/iommu/fsl_pamu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iommu/fsl_pamu
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
+^Iu32 ^Icpu;^I/* cpu number */$
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
+^Iu32 ^Icache;^I/* cache to stash to: L1,L2,L3 */$
Signed-off-by: Emil Medve
---
arch/powerpc/include/asm/fsl_pamu_stash.h | 4 ++--
1 file changed, 2
CHECK:SPACING: No space is necessary after a cast
+ pamu_reg_base = (unsigned long) pamu_regs + pamu_reg_off;
CHECK:SPACING: No space is necessary after a cast
+ memcpy((struct pamu_stash_attribute *) data,
&dma_domain->dma_stash,
Signed-off-by: Emil Medve
---
drive
CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
+ set_bf(paace->addr_bitfields, PAACE_AF_V,
+PAACE_V_INVALID);
CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
+ set_bf(paace->addr_bitfields, PAACE_AF_AP,
linux/modules.h - drivers can't be a module
linux/bootmem.h - no boot time memory allocator is used
linux/notifier.h- not used
etc.
Factorize common includes into fsl_pamu.h
Signed-off-by: Emil Medve
---
drivers/iommu/fsl_pamu.c| 16 +++-
drivers/iomm
Signed-off-by: Emil Medve
---
drivers/iommu/fsl_pamu.c | 39 ++-
1 file changed, 18 insertions(+), 21 deletions(-)
diff --git a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c
index 18a604a..22b72e2 100644
--- a/drivers/iommu/fsl_pamu.c
+++ b/drivers/iommu
pr_fmt() and dev_*() already take care of it
Signed-off-by: Emil Medve
---
drivers/iommu/fsl_pamu.c| 2 +-
drivers/iommu/fsl_pamu_domain.c | 12 ++--
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c
index 22b72e2.
CHECK:TYPO_SPELLING: 'accomodate' may be misspelled - perhaps 'accommodate'?
+ * Hard coded value for the PAACT size to accomodate
Signed-off-by: Emil Medve
---
drivers/iommu/fsl_pamu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/fsl_pamu.h b/drivers/iommu/f
WARNING:PREFER_PACKED: __packed is preferred over __attribute__((packed))
+} __attribute__((packed));
Signed-off-by: Emil Medve
---
drivers/iommu/fsl_pamu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/fsl_pamu.h b/drivers/iommu/fsl_pamu.h
index 86abc70..04dc
CHECK:LINE_SPACING: Please don't use multiple blank lines
+
+
CHECK:LINE_SPACING: Please don't use multiple blank lines
+
+
CHECK:LINE_SPACING: Please don't use multiple blank lines
+
+
CHECK:LINE_SPACING: Please don't use multiple blank lines
+
+
WARNING:LINE_SPACING: Missing a blank line afte
WARNING:BRACES: braces {} are not necessary for single statement blocks
+ if (!paace) {
+ return -ENOENT;
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
+ if (!paace) {
+ return -ENOE
Currently a PAMU driver patch is very likely to receive some checkpatch
complaints about the code in the context of the patch. This sequence is an
attempt to fix most of that and make the dirver more readable
Also fixed a subset of the sparse and coccinelle reported issues
Emil Medve (26):
iomm
A lot of the IOMMU support code does not build if the CPU does
not have an MMU itself, and it's not clear if there is any
use case for it, so let's just disable it and wait for anybody
to need it.
This avoids randconfig errors like
../arch/arm/mm/dma-mapping.c: In function '__iommu_alloc_remap':
On Tue, Jan 27, 2015 at 12:08:58AM +, Joerg Roedel wrote:
> From: Joerg Roedel
>
> Make use of the default domain and re-attach a device to it
> when it is detached from another domain. Also enforce that a
> device has to be in the default domain before it can be
> attached to a different dom
On Tue, Jan 27, 2015 at 12:08:57AM +, Joerg Roedel wrote:
> From: Joerg Roedel
>
> This patch changes the behavior of the iommu_attach_device
> and iommu_detach_device functions. With this change these
> functions only work on devices that have their own group.
> For all other devices the iom
On Tue, Jan 27, 2015 at 12:08:56AM +, Joerg Roedel wrote:
> From: Joerg Roedel
>
> The default domain will be used (if supported by the iommu
> driver) when the devices in the iommu group are not attached
> to any other domain.
>
> Signed-off-by: Joerg Roedel
> ---
> drivers/iommu/iommu.c
Hi Joerg,
Thanks for posting this!
On Mon, Jan 26, 2015 at 11:51:32PM +, Joerg Roedel wrote:
> From: Joerg Roedel
>
> This allows to handle domains differently based on their
> type in the future. An IOMMU driver can implement certain
> optimizations for DMA-API domains for example.
>
> Si
On Tue, Jan 27, 2015 at 12:38:09PM +, Joerg Roedel wrote:
> On Tue, Jan 27, 2015 at 12:27:39PM +, Robin Murphy wrote:
> > Laz^WPragmatism - I'm expecting quite a lot of changes to get this
> > looking good, so keeping the series as lean as possible to aid
> > reviewing/rebasing/etc. seemed
On Wed, Jan 28, 2015 at 01:15:10PM +, Laurent Pinchart wrote:
> On Wednesday 28 January 2015 12:29:42 Will Deacon wrote:
> > On Wed, Jan 28, 2015 at 12:23:03PM +, Laurent Pinchart wrote:
> > > On Wednesday 28 January 2015 11:33:00 Will Deacon wrote:
> > >> On Mon, Jan 26, 2015 at 06:49:01PM
On Wednesday 28 January 2015 12:29:42 Will Deacon wrote:
> On Wed, Jan 28, 2015 at 12:23:03PM +, Laurent Pinchart wrote:
> > On Wednesday 28 January 2015 11:33:00 Will Deacon wrote:
> >> On Mon, Jan 26, 2015 at 06:49:01PM +, Murali Karicheri wrote:
> >>> On 01/25/2015 08:32 AM, Laurent Pinc
On Wed, Jan 28, 2015 at 12:23:03PM +, Laurent Pinchart wrote:
> On Wednesday 28 January 2015 11:33:00 Will Deacon wrote:
> > On Mon, Jan 26, 2015 at 06:49:01PM +, Murali Karicheri wrote:
> > > On 01/25/2015 08:32 AM, Laurent Pinchart wrote:
> > >> On Friday 23 January 2015 17:32:34 Murali K
Hi Will,
On Wednesday 28 January 2015 11:33:00 Will Deacon wrote:
> On Mon, Jan 26, 2015 at 06:49:01PM +, Murali Karicheri wrote:
> > On 01/25/2015 08:32 AM, Laurent Pinchart wrote:
> >> On Friday 23 January 2015 17:32:34 Murali Karicheri wrote:
> >>> Function of_iommu_configure() is called fr
On Fri, Jan 23, 2015 at 10:33:20PM +, Mitchel Humpherys wrote:
> On Fri, Jan 23 2015 at 03:24:15 AM, Will Deacon wrote:
> > On Thu, Jan 22, 2015 at 11:48:02PM +, Mitchel Humpherys wrote:
> >> Context interrupts can call domain-specific handlers which might sleep.
> >> Currently we register
On Mon, Jan 26, 2015 at 06:49:01PM +, Murali Karicheri wrote:
> On 01/25/2015 08:32 AM, Laurent Pinchart wrote:
> > Hi Murali,
> >
> > Thank you for the patch.
> >
> > On Friday 23 January 2015 17:32:34 Murali Karicheri wrote:
> >> Function of_iommu_configure() is called from of_dma_configure()
Hi Murali,
[sorry, missed replying to yesterday's version]
On 27/01/15 21:00, Murali Karicheri wrote:
Fix the dma-range size when the DT attribute is missing. i.e set size to
dev->coherent_dma_mask + 1 instead of dev->coherent_dma_mask. Also add
code to check invalid values of size configured
On Tue, Jan 27, 2015 at 06:55:15PM +, Murali Karicheri wrote:
> On 01/27/2015 06:27 AM, Robin Murphy wrote:
> > On 23/01/15 22:32, Murali Karicheri wrote:
> >> Fix the dma-range size when the DT attribute is missing. i.e set size to
> >> dev->coherent_dma_mask + 1 instead of dev->coherent_dma_m
Hi Joerg,
Could you please pick this patch up for v3.20 ?
On Saturday 24 January 2015 23:13:50 Laurent Pinchart wrote:
> When adding a new device the driver loops over all registered IOMMUs and
> calls the ipmmu_find_utlbs() function to parse the DT iommus attribute.
> The function returns an err
59 matches
Mail list logo
