Re: [PATCH v6 4/5] iommu/mediatek: Add mt8173 IOMMU driver

2015-12-16 Thread Yong Wu
On Wed, 2015-12-16 at 12:48 +, Robin Murphy wrote: > On 16/12/15 05:59, Yong Wu wrote: > > On Tue, 2015-12-15 at 12:37 +, Robin Murphy wrote: > >> On 15/12/15 03:28, Yong Wu wrote: > >>> On Mon, 2015-12-14 at 15:16 +0100, Joerg Roedel wrote: > On Tue, Dec 08, 2015 at 05:49:12PM +0800,

Re: [PATCH v6 4/5] iommu/mediatek: Add mt8173 IOMMU driver

2015-12-16 Thread Joerg Roedel
On Tue, Dec 15, 2015 at 12:37:34PM +, Robin Murphy wrote: > The potential issue I *do* see, looking more closely, is that > iommu_group_get_for_dev() is setting group->domain but not calling > the attach_dev callback, which looks wrong... Attaching the device happens from

RE: [PATCH] IOMMU: arm-smmu-v3: fix broken S2PS and AARCH64 in Broadcom Vulcan

2015-12-16 Thread Prem (Premachandra) Mallappa
> Ok -- so what is the value reported by your IDR5? Our IDR5, OAS=0x4 (44bits) > > Ok, I just didn't see any mention of that in the commit message and wanted > to make sure it wasn't an accidental unrelated change. > Got it. /Prem ___ iommu

Re: [Patch v2 7/9] iommu/amd: copy old tables and do not update dev tables before driver init

2015-12-16 Thread Joerg Roedel
Hi Baoquan, On Sun, Dec 13, 2015 at 09:19:29AM +0800, Baoquan He wrote: >From definition and usage for other arch/component set_dma_mask is only > used to set the DMA addressing limitations which is I got from reading. > Could you please give more tips on this? Maybe I didn't dig into it deep >

Re: [PATCH] IOMMU: arm-smmu-v3: fix broken S2PS and AARCH64 in Broadcom Vulcan

2015-12-16 Thread Will Deacon
On Wed, Dec 16, 2015 at 04:37:07AM +, Prem (Premachandra) Mallappa wrote: > > On Mon, Dec 14, 2015 at 10:01:27PM +0530, Prem Mallappa wrote: > > > Vulcan SMMUv3 looks for AARCH64 and S2PS inroder to validate the STE > > > entry, > > > > 'inroder' ? > > > In order Got it! > > > which is a