Re: [PATCH 1/3] drivers: iommu: arm-smmu: constify iommu_gather_ops structures

2016-10-25 Thread Julia Lawall
On Tue, 25 Oct 2016, Bhumika Goyal wrote: > Check for iommu_gather_ops structures that are only stored in the tlb > field of an io_pgtable_cfg structure. The tlb field is of type > const struct iommu_gather_ops *, so iommu_gather_ops structures > having this property can be declared as const. >

Re: [PATCH 3/3] drivers: iommu: io-pgtable-arm: use const and __initconst for iommu_gather_ops structures

2016-10-25 Thread Julia Lawall
On Tue, 25 Oct 2016, Bhumika Goyal wrote: > Check for iommu_gather_ops structures that are only stored in the tlb > field of an io_pgtable_cfg structure. The tlb field is of type > const struct iommu_gather_ops *, so iommu_gather_ops structures > having this property can be declared as const.

[PATCH 1/3] drivers: iommu: arm-smmu: constify iommu_gather_ops structures

2016-10-25 Thread Bhumika Goyal
Check for iommu_gather_ops structures that are only stored in the tlb field of an io_pgtable_cfg structure. The tlb field is of type const struct iommu_gather_ops *, so iommu_gather_ops structures having this property can be declared as const. Signed-off-by: Bhumika Goyal ---

[PATCH 3/3] drivers: iommu: io-pgtable-arm: use const and __initconst for iommu_gather_ops structures

2016-10-25 Thread Bhumika Goyal
Check for iommu_gather_ops structures that are only stored in the tlb field of an io_pgtable_cfg structure. The tlb field is of type const struct iommu_gather_ops *, so iommu_gather_ops structures having this property can be declared as const. Also, replace __initdata with __initconst.

[PATCH 2/3] drivers: iommu: arm-smmu-v3: constify iommu_gather_ops structures

2016-10-25 Thread Bhumika Goyal
Check for iommu_gather_ops structures that are only stored in the tlb field of an io_pgtable_cfg structure. The tlb field is of type const struct iommu_gather_ops *, so iommu_gather_ops structures having this property can be declared as const. Signed-off-by: Bhumika Goyal ---

[PATCH 0/3] drivers: iommu: declare iommu_gather_ops structures as const

2016-10-25 Thread Bhumika Goyal
Constify iommu_gather_ops structures and replace __initdata with __initconst where needed. Bhumika Goyal (3): drivers: iommu: arm-smmu: constify iommu_gather_ops structures drivers: iommu: arm-smmu-v3: constify iommu_gather_ops structures drivers: iommu: io-pgtable-arm: use const and

[PATCH] drivers: iommu: constify iommu_gather_ops structures

2016-10-25 Thread Bhumika Goyal
Check for iommu_gather_ops structures that are only stored in the tlb field of an io_pgtable_cfg structure. The tlb field is of type const struct iommu_gather_ops *, so iommu_gather_ops structures having this property can be declared as const. Done using Coccinelle: @r1 disable optional_qualifier

Re: [PATCH] drivers: iommu: constify iommu_gather_ops structures

2016-10-25 Thread Julia Lawall
On Tue, 25 Oct 2016, Bhumika Goyal wrote: > Check for iommu_gather_ops structures that are only stored in the tlb > field of an io_pgtable_cfg structure. The tlb field is of type > const struct iommu_gather_ops *, so iommu_gather_ops structures > having this property can be declared as const. >

Re: [PATCH 1/2] iommu/arm-smmu: Don't inadvertently reject multiple SMMUv3s

2016-10-25 Thread Hanjun Guo
On 2016/10/17 19:06, Robin Murphy wrote: We now delay installing our per-bus iommu_ops until we know an SMMU has successfully probed, as they don't serve much purpose beforehand, and doing so also avoids fights between multiple IOMMU drivers in a single kernel. However, the upshot of passing the

Re: [PATCH v6 00/16] ACPI IORT ARM SMMU support

2016-10-25 Thread Hanjun Guo
On 2016/10/19 0:03, Lorenzo Pieralisi wrote: This patch series is v6 of a previous posting: https://lkml.org/lkml/2016/9/9/418 v5 -> v6 - Rebased against v4.9-rc1 - Changed FWNODE_IOMMU to FWNODE_ACPI_STATIC - Moved platform devices creation into IORT code -

Re: [PATCH V3 0/8] IOMMU probe deferral support

2016-10-25 Thread Robin Murphy
Hi Sricharan, On 04/10/16 18:03, Sricharan R wrote: > Initial post from Laurent Pinchart[1]. This is > series calls the dma ops configuration for the devices > at a generic place so that it works for all busses. > The dma_configure_ops for a device is now called during > the device_attach

Re: [PATCH 4/4] iommu/arm-smmu: Add the device_link between masters and smmu

2016-10-25 Thread Marek Szyprowski
Hi Sricharan, On 2016-10-21 19:14, Sricharan R wrote: The device link between master and its smmu is added so that the smmu gets runtime enabled/disabled when the master needs it. This is done from add_device callback which gets called once when the master is added to the smmu group.

RE: [PATCH v5 7/7] iommu/exynos: Use device dependency links to control runtime pm

2016-10-25 Thread Sricharan
Hi Marek, > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c > index 5e6d7bbf9b70..59b4f2ce4f5f 100644 > --- a/drivers/iommu/exynos-iommu.c > +++ b/drivers/iommu/exynos-iommu.c > @@ -781,10 +781,6 @@ static void exynos_iommu_detach_device(struct >

RE: [PATCH 3/4] iommu/arm-smmu: Add context save restore support

2016-10-25 Thread Sricharan
Hi, >> The smes registers and the context bank registers are >> back. The data required to configure the context banks >> are the master's domain data and pgtable cfgs. >> So store them as a part of the context banks info >> the ones that are needs to be saved and restored. >> Fortunately the

RE: [PATCH 2/4] iommu/arm-smmu: Add pm_runtime/sleep ops

2016-10-25 Thread Sricharan
Hi, >On 21 October 2016 at 11:14, Sricharan R wrote: >> The smmu needs to be functional when the respective >> master/s using it are active. As there is a device_link >> between the master and smmu, the pm runtime ops for the smmu >> gets invoked in sync with the

Re: [PATCH V3 0/8] IOMMU probe deferral support

2016-10-25 Thread Archit Taneja
On 10/04/2016 10:33 PM, Sricharan R wrote: Initial post from Laurent Pinchart[1]. This is series calls the dma ops configuration for the devices at a generic place so that it works for all busses. The dma_configure_ops for a device is now called during the device_attach callback just before