Re: [PATCH v9 8/8] perf/amd/iommu: Enable support for multiple IOMMUs

2017-02-14 Thread Suravee Suthikulpanit
Boris, On 2/9/17 02:33, Borislav Petkov wrote: On Tue, Feb 07, 2017 at 02:40:36AM -0600, Suravee Suthikulpanit wrote: From: Suravee Suthikulpanit [..] + perf_iommu->max_banks= amd_iommu_pc_get_max_banks(idx); + perf_iommu->max_counters = amd_iommu_pc_get_max_counters(idx);

Re: [PATCH 2/2] iommu: add warning when sharing groups

2017-02-14 Thread okaya
On 2017-02-14 18:51, Alex Williamson wrote: On Tue, 14 Feb 2017 16:25:22 -0500 Sinan Kaya wrote: The ACS requirement has been obscured in the current code and is only known by certain individuals who happen to read the code. Print out a warning with ACS path failure when ACS requirement is not

Re: [PATCH 2/2] iommu: add warning when sharing groups

2017-02-14 Thread Alex Williamson
On Tue, 14 Feb 2017 16:25:22 -0500 Sinan Kaya wrote: > The ACS requirement has been obscured in the current code and is only > known by certain individuals who happen to read the code. Print out a > warning with ACS path failure when ACS requirement is not met. > > Signed-off-by: Sinan Kaya > -

[PATCH 2/2] iommu: add warning when sharing groups

2017-02-14 Thread Sinan Kaya
The ACS requirement has been obscured in the current code and is only known by certain individuals who happen to read the code. Print out a warning with ACS path failure when ACS requirement is not met. Signed-off-by: Sinan Kaya --- drivers/iommu/iommu.c | 3 +++ 1 file changed, 3 insertions(+)

[PATCH 1/2] PCI: add QCOM root port quirks for ACS

2017-02-14 Thread Sinan Kaya
These QCOM root ports do provide ACS-like features to disable peer transactions and validate bus numbers in requests, but do not provide an actual PCIe ACS capability. Hardware supports source validation but it will report the issue as Completer Abort instead of ACS Violation. Hardware doesn't su

Re: [RFC 2/2] iommu/arm-smmu: support qcom implementation

2017-02-14 Thread Rob Clark
On Tue, Feb 14, 2017 at 1:46 PM, Robin Murphy wrote: > Hi Rob, > > On 10/02/17 18:41, Rob Clark wrote: >> For devices with iommu(s) in secure mode, we cannot touch global >> registers, and we have to live with the context -> sid mapping that >> the secure world has set up for us. >> >> This enable

Re: [RFC 2/2] iommu/arm-smmu: support qcom implementation

2017-02-14 Thread Robin Murphy
Hi Rob, On 10/02/17 18:41, Rob Clark wrote: > For devices with iommu(s) in secure mode, we cannot touch global > registers, and we have to live with the context -> sid mapping that > the secure world has set up for us. > > This enables, for example db410c (apq8016) devices to use the up- > stream

Re: RFC on No ACS Support and SMMUv3 Support

2017-02-14 Thread Sinan Kaya
On 2/14/2017 7:36 AM, Will Deacon wrote: > On Mon, Feb 13, 2017 at 08:54:04PM -0500, Sinan Kaya wrote: >> On 2/13/2017 8:46 PM, Alex Williamson wrote: My first goal is to support virtual function passthrough for device's that are directly connected. This will be possible with the qu

Re: RFC on No ACS Support and SMMUv3 Support

2017-02-14 Thread Will Deacon
On Mon, Feb 13, 2017 at 08:54:04PM -0500, Sinan Kaya wrote: > On 2/13/2017 8:46 PM, Alex Williamson wrote: > >> My first goal is to support virtual function passthrough for device's that > >> are directly > >> connected. This will be possible with the quirk I proposed and it will be > >> the most

Re: [PATCH v8 9/9] perf/amd/iommu: Enable support for multiple IOMMUs

2017-02-14 Thread Peter Zijlstra
On Tue, Feb 07, 2017 at 08:57:52AM +0700, Suravee Suthikulpanit wrote: > >But instead it looks like you get the counter form: > > > > #define _GET_CNTR(ev) ((u8)(ev->hw.extra_reg.reg)) > > > >Which is absolutely insane. > > > > So, the IOMMU counters are grouped into bank, and there could b

Re: RFC on No ACS Support and SMMUv3 Support

2017-02-14 Thread Robin Murphy
On 14/02/17 01:54, Sinan Kaya wrote: > On 2/13/2017 8:46 PM, Alex Williamson wrote: >>> My first goal is to support virtual function passthrough for device's that >>> are directly >>> connected. This will be possible with the quirk I proposed and it will be >>> the most >>> secure solution. It ca