Re: [RFC PATCH v4 11/28] x86: Add support to determine the E820 type of an address

2017-03-03 Thread Borislav Petkov
On Tue, Feb 28, 2017 at 04:34:39PM -0600, Tom Lendacky wrote: > Or if we want to guard against ACPI adding a type 0 in the future, I > could make the function return an int and then return -EINVAL if an e820 > entry isn't found. This might be the better option. Yap, think so too. I don't trust sp

Re: [RFC PATCH 22/30] iommu: Bind/unbind tasks to/from devices

2017-03-03 Thread David Woodhouse
On Mon, 2017-02-27 at 19:54 +, Jean-Philippe Brucker wrote: > Add three functions to the IOMMU API. iommu_bind_task takes a device and a > task as argument. If the IOMMU, the device and the bus support it, attach > task to device and create a Process Address Space ID (PASID) unique to the > dev

Re: [PATCH 3/9] Docs: dt: document qcom iommu bindings

2017-03-03 Thread Rob Clark
On Fri, Mar 3, 2017 at 1:21 AM, Rob Herring wrote: > On Wed, Mar 01, 2017 at 12:42:52PM -0500, Rob Clark wrote: > > Nit: use "dt-bindings: iommu: ..." for subject. And a commit message > would be nice. > >> Cc: devicet...@vger.kernel.org >> Signed-off-by: Rob Clark >> --- >> .../devicetree/bindi

Re: [RFC PATCH 22/30] iommu: Bind/unbind tasks to/from devices

2017-03-03 Thread Raj, Ashok
Hi David, Good to hear back from you! On Fri, Mar 03, 2017 at 09:40:44AM +, David Woodhouse wrote: > > Intel slightly deviates from the "one PASID per process" vision too, > because it currently has a PASID allocator idr per IOMMU. That wants > making system-wide. And probably not Intel-spe

Re: [RFC PATCH 22/30] iommu: Bind/unbind tasks to/from devices

2017-03-03 Thread Jean-Philippe Brucker
Hi David, On Fri, Mar 03, 2017 at 09:40:44AM +, David Woodhouse wrote: > On Mon, 2017-02-27 at 19:54 +, Jean-Philippe Brucker wrote: > > Add three functions to the IOMMU API. iommu_bind_task takes a device and a > > task as argument. If the IOMMU, the device and the bus support it, attach

Re: [RFC PATCH 03/30] PCI: Move ATS declarations outside of CONFIG_PCI

2017-03-03 Thread Bjorn Helgaas
On Mon, Feb 27, 2017 at 07:54:14PM +, Jean-Philippe Brucker wrote: > Currently ATS helpers like pci_enable_ats are only defined when CONFIG_PCI > is enabled. The ARM SMMU driver might get built with CONFIG_PCI disabled. > It would thus have to wrap any use of ATS helpers around #ifdef > CONFIG_

Re: [RFC PATCH 18/30] PCI: Make "PRG Response PASID Required" handling common

2017-03-03 Thread Bjorn Helgaas
On Mon, Feb 27, 2017 at 07:54:29PM +, Jean-Philippe Brucker wrote: > The PASID ECN to the PCIe spec added a bit in the PRI status register that > allows a Function to declare whether a PRG Response should contain the > PASID prefix or not. > > Move the helper that accesses it from amd_iommu in

Re: [RFC PATCH 19/30] PCI: Cache PRI and PASID bits in pci_dev

2017-03-03 Thread Bjorn Helgaas
On Mon, Feb 27, 2017 at 07:54:30PM +, Jean-Philippe Brucker wrote: > Device drivers need to check if an IOMMU enabled ATS, PRI and PASID in > order to know when they can use the SVM API. Cache PRI and PASID bits in > the pci_dev structure, similarly to what is currently done for ATS. > > Signe