Re: ARM-SMMU: Delete error messages for a failed memory allocation in three functions

2018-01-22 Thread SF Markus Elfring
>> Date: Sat, 20 Jan 2018 15:30:17 +0100 >> >> Omit extra messages for a memory allocation failure in these functions. > > Why? Do you find the wording “WARNING: Possible unnecessary 'out of memory' message” (from the script “checkpatch.pl”) more reasonable? > This may as well be "delete some s

Re: [PATCH] ARM-SMMU: Delete error messages for a failed memory allocation in three functions

2018-01-22 Thread Will Deacon
On Mon, Jan 22, 2018 at 11:47:13AM +, Robin Murphy wrote: > On 20/01/18 14:36, SF Markus Elfring wrote: > >From: Markus Elfring > >Date: Sat, 20 Jan 2018 15:30:17 +0100 > > > >Omit extra messages for a memory allocation failure in these functions. > > Why? Don't worry -- I was ignoring this

Re: [PATCH] ARM-SMMU: Delete error messages for a failed memory allocation in three functions

2018-01-22 Thread Robin Murphy
On 20/01/18 14:36, SF Markus Elfring wrote: From: Markus Elfring Date: Sat, 20 Jan 2018 15:30:17 +0100 Omit extra messages for a memory allocation failure in these functions. Why? It's your job as patch author to convince reviewers and maintainers why your change is a good thing and they sh

Re: [PATCH v2] iommu/arm-smmu-v3: limit reporting of MSI allocation failures

2018-01-22 Thread Marc Zyngier
On 20/01/18 18:08, Nate Watterson wrote: > Currently, the arm-smmu-v3 driver expects to allocate MSIs for all SMMUs > with FEAT_MSI set. This results in unwarranted "failed to allocate MSIs" > warnings being printed on systems where FW was either deliberately > configured to force the use of SMMU w