Re: [PATCH 5/6] dma-mapping: support fsl-mc bus

On Tue, Mar 06, 2018 at 04:41:56AM +, Nipun Gupta wrote: > Sorry for asking a trivial question - looking into dma_configure() I see that > PCI is used in the start and the end of the API. > In the end part pci_put_host_bridge_device() is called. > So are two bus callbacks something like

Re: [PATCH v8 1/5] iommu/arm-smmu: Destroy domain context in failure path

On Wed, Mar 7, 2018 at 5:50 PM, Robin Murphy wrote: > On 02/03/18 10:10, Vivek Gautam wrote: >> >> If we fail after initializing domain_context, we should destroy >> the context to free up resources. > > > Have another think about why the "problem" this patch caters for

Re: [PATCH v8 4/5] iommu/arm-smmu: Add the device_link between masters and smmu

On Wed, Mar 7, 2018 at 6:17 PM, Robin Murphy wrote: > On 02/03/18 10:10, Vivek Gautam wrote: >> >> From: Sricharan R >> >> Finally add the device link between the master device and >> smmu, so that the smmu gets runtime enabled/disabled only when

Re: [PATCH v8 3/5] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

On Thu, Mar 8, 2018 at 1:58 AM, Robin Murphy wrote: > On 07/03/18 13:52, Tomasz Figa wrote: >> >> On Wed, Mar 7, 2018 at 9:38 PM, Robin Murphy wrote: >>> >>> On 02/03/18 10:10, Vivek Gautam wrote: From: Sricharan R

Re: [PATCH 1/6] Docs: dt: add fsl-mc iommu-parent device-tree binding

On Mon, Mar 05, 2018 at 07:59:21PM +0530, Nipun Gupta wrote: > The existing IOMMU bindings cannot be used to specify the relationship > between fsl-mc devices and IOMMUs. This patch adds a binding for > mapping fsl-mc devices to IOMMUs, using a new iommu-parent property. > > Signed-off-by: Nipun

Re: [PATCH v8 3/5] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

On 07/03/18 13:52, Tomasz Figa wrote: On Wed, Mar 7, 2018 at 9:38 PM, Robin Murphy wrote: On 02/03/18 10:10, Vivek Gautam wrote: From: Sricharan R The smmu device probe/remove and add/remove master device callbacks gets called when the smmu

Re: [PATCH 1/1] iommu/arm-smmu: Add support for qcom, smmu-500 variant

On Wed, Mar 7, 2018 at 12:32 AM, Vivek Gautam wrote: > Qualcomm's arm-smmu 500 implementation supports runtime pm > so enable the same. That's a driver detail unrelated to the binding. > > Signed-off-by: Vivek Gautam > --- > > Based on

Re: [PATCH v8 3/5] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

On Wed, Mar 7, 2018 at 9:38 PM, Robin Murphy wrote: > On 02/03/18 10:10, Vivek Gautam wrote: >> >> From: Sricharan R >> >> The smmu device probe/remove and add/remove master device callbacks >> gets called when the smmu is not linked to its master,

Re: [PATCH v7 09/14] dt-bindings: iommu/rockchip: Add clock property

On 06/03/18 03:21, Jeffy Chen wrote: Add clock property, since we are going to control clocks in rockchip iommu driver. Reviewed-by: Robin Murphy Signed-off-by: Jeffy Chen Reviewed-by: Rob Herring --- Changes in v7: None

Re: [PATCH v7 03/14] iommu/rockchip: Request irqs in rk_iommu_probe()

On 06/03/18 03:02, Jeffy Chen wrote: Move request_irq to the end of rk_iommu_probe(). Acked-by: Robin Murphy Suggested-by: Robin Murphy Signed-off-by: Jeffy Chen Reviewed-by: Tomasz Figa ---

Re: [PATCH v7 02/14] iommu/rockchip: Fix error handling in probe

On 06/03/18 03:02, Jeffy Chen wrote: Add missing iommu_device_sysfs_remove in error path. Acked-by: Robin Murphy (strictly you don't need to introduce the additional return, but it's only a couple of lines and definitely not worth respinning just for that)

Re: [PATCH v7 01/14] iommu/rockchip: Prohibit unbind and remove

On 06/03/18 03:02, Jeffy Chen wrote: Removal of IOMMUs cannot be done reliably. This is similar to exynos iommu driver. Acked-by: Robin Murphy Signed-off-by: Jeffy Chen Reviewed-by: Tomasz Figa --- Changes in v7: None

Re: [PATCH v8 4/5] iommu/arm-smmu: Add the device_link between masters and smmu

On 02/03/18 10:10, Vivek Gautam wrote: From: Sricharan R Finally add the device link between the master device and smmu, so that the smmu gets runtime enabled/disabled only when the master needs it. This is done from add_device callback which gets called once when the

Re: [PATCH v8 3/5] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

On 02/03/18 10:10, Vivek Gautam wrote: From: Sricharan R The smmu device probe/remove and add/remove master device callbacks gets called when the smmu is not linked to its master, that is without the context of the master device. So calling runtime apis in those

Re: [PATCH v8 1/5] iommu/arm-smmu: Destroy domain context in failure path

On 02/03/18 10:10, Vivek Gautam wrote: If we fail after initializing domain_context, we should destroy the context to free up resources. Have another think about why the "problem" this patch caters for cannot ever happen (hint: consider how domain->smmu is used in

Re: [PATCH 1/3] dt-bindings: iommu: ipmmu-vmsa: Add device tree support for r8a774[35]

[CC Alex Williamson] It looks like the last patch to this file was taken by Alex. Perhaps he would be willing to take this one too if it it was reposted with him CCed. On Tue, Mar 06, 2018 at 04:55:44PM +, Fabrizio Castro wrote: > Dear All, > > I am very sorry to bother you, do you know who