Re: [PATCH] iommu: io-pgtable: Support non-coherent page tables

2019-05-15 Thread Vivek Gautam
On Thu, May 16, 2019 at 5:03 AM Bjorn Andersson wrote: > > Describe the memory related to page table walks as non-cachable for iommu > instances that are not DMA coherent. > > Signed-off-by: Bjorn Andersson > --- > drivers/iommu/io-pgtable-arm.c | 12 +--- > 1 file changed, 9 insertions(

Re: [PATCH v3 02/10] swiotlb: Factor out slot allocation and free

2019-05-15 Thread Lu Baolu
Hi, On 5/13/19 3:05 PM, Christoph Hellwig wrote: On Mon, May 06, 2019 at 09:54:30AM +0800, Lu Baolu wrote: Agreed. I will prepare the next version simply without the optimization, so the offset is not required. For your changes in swiotlb, will you formalize them in patches or want me to do th

[PATCH] iommu: io-pgtable: Support non-coherent page tables

2019-05-15 Thread Bjorn Andersson
Describe the memory related to page table walks as non-cachable for iommu instances that are not DMA coherent. Signed-off-by: Bjorn Andersson --- drivers/iommu/io-pgtable-arm.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/iommu/io-pgtable-arm.c b/drive

Re: [PATCH v3 00/16] Shared virtual address IOMMU and VT-d support

2019-05-15 Thread Jacob Pan
Hi all, Just wondering if you have any more feedbacks other than the cache invalidate API change for archid? I plan to do the next version on top of Jean's sva/api branch (common iommu APIs) with minor tweak to support non-identity guest-host PASID mapping. It would be great if I can address additi

Re: [PATCH v3 02/16] iommu: Introduce cache_invalidate API

2019-05-15 Thread Jacob Pan
On Wed, 15 May 2019 16:52:46 +0100 Jean-Philippe Brucker wrote: > On 14/05/2019 18:55, Jacob Pan wrote: > > Yes, I agree to replace the standalone __64 pasid with this struct. > > Looks more inline with address selective info., Just to double > > confirm the new struct. > > > > Jean, will you pu

Re: [RFC PATCH v3 11/21] x86/watchdog/hardlockup: Add an HPET-based hardlockup detector

2019-05-15 Thread Ricardo Neri
On Tue, May 14, 2019 at 07:26:58AM -0700, Randy Dunlap wrote: > On 5/14/19 7:02 AM, Ricardo Neri wrote: > > diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug > > index 15d0fbe27872..376a5db81aec 100644 > > --- a/arch/x86/Kconfig.debug > > +++ b/arch/x86/Kconfig.debug > > @@ -169,6 +169,1

Re: [PATCH v7 04/23] iommu: Introduce attach/detach_pasid_table API

2019-05-15 Thread Jean-Philippe Brucker
On 15/05/2019 14:06, Auger Eric wrote: > Hi Jean-Philippe, > > On 5/15/19 2:09 PM, Jean-Philippe Brucker wrote: >> On 08/04/2019 13:18, Eric Auger wrote: >>> diff --git a/include/uapi/linux/iommu.h b/include/uapi/linux/iommu.h >>> index edcc0dda7993..532a64075f23 100644 >>> --- a/include/uapi/linu

Re: [RFC PATCH v3 04/21] x86/hpet: Add hpet_set_comparator() for periodic and one-shot modes

2019-05-15 Thread Ricardo Neri
On Tue, May 14, 2019 at 07:24:38AM -0700, Randy Dunlap wrote: > On 5/14/19 7:01 AM, Ricardo Neri wrote: > > Instead of setting the timer period directly in hpet_set_periodic(), add a > > new helper function hpet_set_comparator() that only sets the accumulator > > and comparator. hpet_set_periodic()

Re: [RFC PATCH v3 03/21] x86/hpet: Calculate ticks-per-second in a separate function

2019-05-15 Thread Ricardo Neri
On Tue, May 14, 2019 at 07:23:47AM -0700, Randy Dunlap wrote: > On 5/14/19 7:01 AM, Ricardo Neri wrote: > > It is easier to compute the expiration times of an HPET timer by using > > its frequency (i.e., the number of times it ticks in a second) than its > > period, as given in the capabilities reg

Re: [PATCH v3 02/16] iommu: Introduce cache_invalidate API

2019-05-15 Thread Jean-Philippe Brucker
On 14/05/2019 18:55, Jacob Pan wrote: > Yes, I agree to replace the standalone __64 pasid with this struct. > Looks more inline with address selective info., Just to double confirm > the new struct. > > Jean, will you put this in your sva/api repo? Yes, I pushed it along with some documentation f

Re: [PATCH v3 02/16] iommu: Introduce cache_invalidate API

2019-05-15 Thread Jean-Philippe Brucker
On 15/05/2019 15:47, Tian, Kevin wrote: >> From: Jean-Philippe Brucker >> Sent: Wednesday, May 15, 2019 7:04 PM >> >> On 14/05/2019 18:44, Jacob Pan wrote: >>> Hi Thank you both for the explanation. >>> >>> On Tue, 14 May 2019 11:41:24 +0100 >>> Jean-Philippe Brucker wrote: >>> On 14/05/2019

RE: [PATCH v3 02/16] iommu: Introduce cache_invalidate API

2019-05-15 Thread Tian, Kevin
> From: Jean-Philippe Brucker > Sent: Wednesday, May 15, 2019 7:04 PM > > On 14/05/2019 18:44, Jacob Pan wrote: > > Hi Thank you both for the explanation. > > > > On Tue, 14 May 2019 11:41:24 +0100 > > Jean-Philippe Brucker wrote: > > > >> On 14/05/2019 08:36, Auger Eric wrote: > >>> Hi Jacob, >

Re: Linux crash when using FTDI FT232R USB to serial converter on AMD boards.

2019-05-15 Thread starost...@gmail.com
Dne 15.5.2019 v 15:54 Oliver Neukum napsal(a): 1. Determine whether the bug depends on the use of an IOMMU No, bug not depends on the use of an IOMMU. System crash on both cases. 2.Send a new report to the corresponding mailing list Which mailing list is correct? starosta ___

Re: Linux crash when using FTDI FT232R USB to serial converter on AMD boards.

2019-05-15 Thread Oliver Neukum
On Mi, 2019-05-15 at 13:21 +0200, starost...@gmail.com wrote: > Dne 15.5.2019 v 11:46 Oliver Neukum napsal(a): > > > > Most helpful. First, try to replicate this with the iommu > > disabled. > > > > I am trying this with "iommu disabled" in bios, but system crash

Re: [PATCH v7 04/23] iommu: Introduce attach/detach_pasid_table API

2019-05-15 Thread Auger Eric
Hi Jean-Philippe, On 5/15/19 2:09 PM, Jean-Philippe Brucker wrote: > On 08/04/2019 13:18, Eric Auger wrote: >> diff --git a/include/uapi/linux/iommu.h b/include/uapi/linux/iommu.h >> index edcc0dda7993..532a64075f23 100644 >> --- a/include/uapi/linux/iommu.h >> +++ b/include/uapi/linux/iommu.h >>

Re: [PATCH v3 2/4] iommu/dma-iommu: Handle deferred devices

2019-05-15 Thread Tom Murphy
like this? In that case we need to add a call to iommu_dma_alloc_remap. >From 862aeebb601008cf863e3aff4ff8ed7cefebeefa Mon Sep 17 00:00:00 2001 From: Tom Murphy Date: Wed, 15 May 2019 05:43:25 -0700 Subject: [PATCH] iommu/dma-iommu: Handle deferred devices Handle devices which defer their attac

Re: [PATCH v7 04/23] iommu: Introduce attach/detach_pasid_table API

2019-05-15 Thread Jean-Philippe Brucker
On 08/04/2019 13:18, Eric Auger wrote: > diff --git a/include/uapi/linux/iommu.h b/include/uapi/linux/iommu.h > index edcc0dda7993..532a64075f23 100644 > --- a/include/uapi/linux/iommu.h > +++ b/include/uapi/linux/iommu.h > @@ -112,4 +112,51 @@ struct iommu_fault { > struct iommu_faul

Re: Linux crash when using FTDI FT232R USB to serial converter on AMD boards.

2019-05-15 Thread starost...@gmail.com
Dne 15.5.2019 v 11:46 Oliver Neukum napsal(a): Most helpful. First, try to replicate this with the iommu disabled. I am trying this with "iommu disabled" in bios, but system crash too: https://paste.ee/p/wUgHl Secondly, make a proper bugreport mentioning the affected kernel version (5.1) How

Re: Linux crash when using FTDI FT232R USB to serial converter on AMD boards.

2019-05-15 Thread starost...@gmail.com
Dne 15.5.2019 v 11:46 Oliver Neukum napsal(a): Most helpful. First, try to replicate this with the iommu disabled. I am trying this with "iommu disabled" in bios, but system crash too: https://paste.ee/p/wUgHl Secondly, make a proper bugrep

Re: [PATCH v3 02/16] iommu: Introduce cache_invalidate API

2019-05-15 Thread Jean-Philippe Brucker
On 14/05/2019 18:44, Jacob Pan wrote: > Hi Thank you both for the explanation. > > On Tue, 14 May 2019 11:41:24 +0100 > Jean-Philippe Brucker wrote: > >> On 14/05/2019 08:36, Auger Eric wrote: >>> Hi Jacob, >>> >>> On 5/14/19 12:16 AM, Jacob Pan wrote: On Mon, 13 May 2019 18:09:48 +0100 >

Re: Linux crash when using FTDI FT232R USB to serial converter on AMD boards.

2019-05-15 Thread Oliver Neukum
On Mi, 2019-05-15 at 11:43 +0200, starost...@gmail.com wrote: > As I wrote, I made new test on kernel Linux version > 5.1.0-050100-generic amd64: > > https://kernel.ubuntu.com/~kernel-ppa/mainline/v5.1/ > > Same problem, system crash after a few seconds. Full kern.log: > https:

Re: Linux crash when using FTDI FT232R USB to serial converter on AMD boards.

2019-05-15 Thread Oliver Neukum
On Mi, 2019-05-15 at 09:54 +0200, starost...@gmail.com wrote: > Hello, > can I still help with this problem? It's very important for us. Thank you. Your first step would be t verify whether your kernel has the fix coming in the patch Joerg mentioned. Regards Oliver

Re: Linux crash when using FTDI FT232R USB to serial converter on AMD boards.

2019-05-15 Thread starost...@gmail.com
As I wrote, I made new test on kernel Linux version 5.1.0-050100-generic amd64: https://kernel.ubuntu.com/~kernel-ppa/mainline/v5.1/ Same problem, system crash after a few seconds. Full kern.log: https://paste.ee/p/EmLsw Unfortunately, I can't judge if the patch is t

Re: Linux crash when using FTDI FT232R USB to serial converter on AMD boards.

2019-05-15 Thread starost...@gmail.com
As I wrote, I made new test on kernel Linux version 5.1.0-050100-generic amd64: https://kernel.ubuntu.com/~kernel-ppa/mainline/v5.1/ Same problem, system crash after a few seconds. Full kern.log: https://paste.ee/p/EmLsw Unfortunately, I can't judge if the patch is there, but I found, that th

Re: Linux crash when using FTDI FT232R USB to serial converter on AMD boards.

2019-05-15 Thread starost...@gmail.com
Hello, can I still help with this problem? It's very important for us. Thank you. starosta Dne 6.5.2019 v 9:10 starost...@gmail.com napsal(a): New test on kernel Linux version 5.1.0-050100-generic. Same problem, system crash after a few seconds. Full kern.log: https://paste.ee/p/EmLsw I can do