Re: [PATCH v7 5/6] vfio/type1: Add IOVA range capability support

2019-07-07 Thread Auger Eric
Hi Shameer, On 6/26/19 5:12 PM, Shameer Kolothum wrote: > This allows the user-space to retrieve the supported IOVA > range(s), excluding any reserved regions. The implementation non relaxable reserved regions > is based on capability chains, added to VFIO_IOMMU_GET_INFO ioctl. > >

Re: [PATCH v7 4/6] vfio/type1: check dma map request is within a valid iova range

2019-07-07 Thread Auger Eric
Hi Shameer, On 6/26/19 5:12 PM, Shameer Kolothum wrote: > This checks and rejects any dma map request outside valid iova > range. > > Signed-off-by: Shameer Kolothum > --- > v6 --> v7 > > Addressed the case where a container with only an mdev device will > have an empty list(Suggested by

Re: [PATCH v7 6/6] vfio/type1: remove duplicate retrieval of reserved regions

2019-07-07 Thread Auger Eric
Hi Shameer, On 6/26/19 5:12 PM, Shameer Kolothum wrote: > As we now already have the reserved regions list, just pass that into > vfio_iommu_has_sw_msi() fn. > > Signed-off-by: Shameer Kolothum Reviewed-by: Eric Auger Thanks Eric > --- > drivers/vfio/vfio_iommu_type1.c | 15 ++- >

Re: [PATCH v7 3/6] vfio/type1: Update iova list on detach

2019-07-07 Thread Auger Eric
Hi Shameer, On 6/26/19 5:12 PM, Shameer Kolothum wrote: > Get a copy of iova list on _group_detach and try to update the list. > On success replace the current one with the copy. Leave the list as > it is if update fails. > > Signed-off-by: Shameer Kolothum > --- >

Re: [PATCH v7 2/6] vfio/type1: Check reserve region conflict and update iova list

2019-07-07 Thread Auger Eric
Hi Shameer, On 6/26/19 5:12 PM, Shameer Kolothum wrote: > This retrieves the reserved regions associated with dev group and > checks for conflicts with any existing dma mappings. Also update > the iova list excluding the reserved regions. s/reserve/reserved in the commit title > > Reserved

Re: [PATCH v7 1/6] vfio/type1: Introduce iova list and add iommu aperture validity check

2019-07-07 Thread Auger Eric
Hi Shameer, On 6/26/19 5:12 PM, Shameer Kolothum wrote: > This introduces an iova list that is valid for dma mappings. Make > sure the new iommu aperture window doesn't conflict with the current > one or with any existing dma mappings during attach. > > Signed-off-by: Shameer Kolothum > --- >