On Sat, Oct 5, 2019 at 1:25 AM Christoph Hellwig wrote:
>
> Hi Andrey,
>
> thanks for the patch. I think it would be much easier to just
> use the original open coded check in dma_common_free_remap instead
> of adding a new helper. What do you think of the version below?
>
Looks good to me. I
the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Kees-Cook/dma-mapping-Move-vmap-address-checks-into-dma_map_single/20191005-073954
config: i386-randconfig-d001-201939 (attached as .config)
compiler: gcc-7 (Debian
Commit 5cf4537975bb ("dma-mapping: introduce a dma_common_find_pages
helper") changed invalid input check in dma_common_free_remap() from:
if (!area || !area->flags != VM_DMA_COHERENT)
to
if (!area || !area->flags != VM_DMA_COHERENT || !area->pages)
which seem to produce false
Il giorno sab 5 ott 2019 alle ore 06:56 Bjorn Andersson
ha scritto:
>
> On Tue 01 Oct 15:01 PDT 2019, khol...@gmail.com wrote:
>
> > From: AngeloGioacchino Del Regno
> >
> > Some Qualcomm Family-B SoCs have got a different version of the QCOM
> > IOMMU, specifically v2 and 500, which perfectly
Please split the usb and dma-mapping parts into separate patches.
> diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
> index 4a1c4fca475a..12dbd07f74f2 100644
> --- a/include/linux/dma-mapping.h
> +++ b/include/linux/dma-mapping.h
> @@ -583,6 +583,13 @@ static inline
On Thu, Oct 03, 2019 at 02:38:43PM -0700, Kees Cook wrote:
> > I think it would be reasonable to pull the is_vmalloc_addr() check inline,
> > as that probably covers 90+% of badness (especially given vmapped stacks),
> > and as you say should be reliably cheap everywhere. Callers are certainly
> >
Hi Andrey,
thanks for the patch. I think it would be much easier to just
use the original open coded check in dma_common_free_remap instead
of adding a new helper. What do you think of the version below?
---
>From 2cf2aa6a69db0b17b3979144287af8775c1c1534 Mon Sep 17 00:00:00 2001
From: Andrey
On Fri, Oct 04, 2019 at 02:28:16PM -0700, Kees Cook wrote:
> As we've seen from USB and other areas, we need to always do runtime
> checks for DMA operating on memory regions that might be remapped. This
> moves the existing checks from USB into dma_map_single(), but leaves
> the slightly heavier
