Re: [PATCH 21/29] mm: remove the pgprot argument to __vmalloc

2020-05-01 Thread Andrew Morton
On Thu, 30 Apr 2020 22:38:10 -0400 John Dorminy wrote: > the change > description refers to PROT_KERNEL, which is a symbol which does not > appear to exist; perhaps PAGE_KERNEL was meant? Yes, thanks, fixed. ___ iommu mailing list

Re: [PATCH 03/14] docs: fix references for DMA*.txt files

2020-05-01 Thread Paul E. McKenney
On Fri, May 01, 2020 at 05:37:47PM +0200, Mauro Carvalho Chehab wrote: > As we moved those files to core-api, fix references to point > to their newer locations. > > Signed-off-by: Mauro Carvalho Chehab > --- > Documentation/PCI/pci.rst | 6 +++--- >

[PATCH 03/14] docs: fix references for DMA*.txt files

2020-05-01 Thread Mauro Carvalho Chehab
As we moved those files to core-api, fix references to point to their newer locations. Signed-off-by: Mauro Carvalho Chehab --- Documentation/PCI/pci.rst | 6 +++--- Documentation/block/biodoc.rst | 2 +-

[PATCH 00/14] Move the ReST files from Documentation/*.txt

2020-05-01 Thread Mauro Carvalho Chehab
The main goal of this series is to cleanup the Documentation/ directory. Most of the files under Documentation/*.txt are already in ReST format. They just need to be moved to some place. So, most of the work here is to just move files for them to generate an output using the docs building system.

Re: [PATCH 1/2] arm64: dts: qcom: sc7180: Add A618 gpu dt blob

2020-05-01 Thread Doug Anderson
Hi, On Fri, May 1, 2020 at 3:30 AM Sharat Masetty wrote: > > This patch adds the required dt nodes and properties > to enabled A618 GPU. > > Signed-off-by: Sharat Masetty > --- > * Remove GCC_DDRSS_GPU_AXI_CLK clock reference from gpu smmu node. > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 102

Re: [PATCH 2/2] dt-bindings: arm-smmu: Add sc7180 compatible string

2020-05-01 Thread Doug Anderson
Hi, On Fri, May 1, 2020 at 3:30 AM Sharat Masetty wrote: > > This patch simply adds a new compatible string for SC7180 platform. > > Signed-off-by: Sharat Masetty > --- > Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Douglas

Re: [PATCH v2]iommu/qcom:fix local_base status check

2020-05-01 Thread Tang Bin
On 2020/5/1 19:37, Joerg Roedel wrote: On Sat, Apr 18, 2020 at 09:47:03PM +0800, Tang Bin wrote: The function qcom_iommu_device_probe() does not perform sufficient error checking after executing devm_ioremap_resource(), which can result in crashes if a critical error path is encountered.

Re: [PATCH v6 17/25] iommu/arm-smmu-v3: Implement iommu_sva_bind/unbind()

2020-05-01 Thread Jason Gunthorpe
On Fri, May 01, 2020 at 05:15:52AM -0700, Christoph Hellwig wrote: > > @@ -432,6 +432,7 @@ config ARM_SMMU_V3 > > tristate "ARM Ltd. System MMU Version 3 (SMMUv3) Support" > > depends on ARM64 > > select IOMMU_API > > + select IOMMU_SVA > > select IOMMU_IO_PGTABLE_LPAE > >

Re: [PATCH v6 17/25] iommu/arm-smmu-v3: Implement iommu_sva_bind/unbind()

2020-05-01 Thread Christoph Hellwig
> @@ -432,6 +432,7 @@ config ARM_SMMU_V3 > tristate "ARM Ltd. System MMU Version 3 (SMMUv3) Support" > depends on ARM64 > select IOMMU_API > + select IOMMU_SVA > select IOMMU_IO_PGTABLE_LPAE > select GENERIC_MSI_IRQ_DOMAIN Doesn't this need to select MMU_NOTIFIER

Re: [PATCH v2]iommu/qcom:fix local_base status check

2020-05-01 Thread Joerg Roedel
On Sat, Apr 18, 2020 at 09:47:03PM +0800, Tang Bin wrote: > The function qcom_iommu_device_probe() does not perform sufficient > error checking after executing devm_ioremap_resource(), which can > result in crashes if a critical error path is encountered. > > Fixes: 0ae349a0f33f ("iommu/qcom: Add

Re: [PATCH] drivers/iommu: properly export iommu_group_get_for_dev

2020-05-01 Thread Joerg Roedel
On Thu, Apr 30, 2020 at 02:01:20PM +0200, Greg Kroah-Hartman wrote: > In commit a7ba5c3d008d ("drivers/iommu: Export core IOMMU API symbols to > permit modular drivers") a bunch of iommu symbols were exported, all > with _GPL markings except iommu_group_get_for_dev(). That export should > also be

Re: [PATCH 1/1] iommu/vt-d: Use right Kconfig option name

2020-05-01 Thread Joerg Roedel
On Fri, May 01, 2020 at 03:24:27PM +0800, Lu Baolu wrote: > The CONFIG_ prefix should be added in the code. > > Fixes: 046182525db61 ("iommu/vt-d: Add Kconfig option to enable/disable > scalable mode") > Reported-and-tested-by: Kumar, Sanjay K > Cc: Ashok Raj > Signed-off-by: Lu Baolu > --- >

Re: [PATCH] iommu: Free fwspec with the dev_iommu object

2020-05-01 Thread Joerg Roedel
Hi Jean-Philippe, On Wed, Apr 22, 2020 at 03:55:14PM +0200, Jean-Philippe Brucker wrote: > Fix this leak by freeing the fwspec in dev_iommu_free(). > > Fixes: 72acd9df18f1 ("iommu: Move iommu_fwspec to struct dev_iommu") > Signed-off-by: Jean-Philippe Brucker > --- > drivers/iommu/iommu.c | 1

Re: [PATCH] iommu/amd: Fix legacy interrupt remapping for x2APIC-enabled system

2020-05-01 Thread Joerg Roedel
On Wed, Apr 22, 2020 at 08:30:02AM -0500, Suravee Suthikulpanit wrote: > Currently, system fails to boot because the legacy interrupt remapping > mode does not enable 128-bit IRTE (GA), which is required for x2APIC > support. > > Fix by using AMD_IOMMU_GUEST_IR_LEGACY_GA mode when booting with >

[PATCH 1/2] arm64: dts: qcom: sc7180: Add A618 gpu dt blob

2020-05-01 Thread Sharat Masetty
This patch adds the required dt nodes and properties to enabled A618 GPU. Signed-off-by: Sharat Masetty --- * Remove GCC_DDRSS_GPU_AXI_CLK clock reference from gpu smmu node. arch/arm64/boot/dts/qcom/sc7180.dtsi | 102 +++ 1 file changed, 102 insertions(+) diff

[PATCH 2/2] dt-bindings: arm-smmu: Add sc7180 compatible string

2020-05-01 Thread Sharat Masetty
This patch simply adds a new compatible string for SC7180 platform. Signed-off-by: Sharat Masetty --- Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml

[PATCH 1/1] iommu/vt-d: Use right Kconfig option name

2020-05-01 Thread Lu Baolu
The CONFIG_ prefix should be added in the code. Fixes: 046182525db61 ("iommu/vt-d: Add Kconfig option to enable/disable scalable mode") Reported-and-tested-by: Kumar, Sanjay K Cc: Ashok Raj Signed-off-by: Lu Baolu --- drivers/iommu/intel-iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH] drivers/iommu: properly export iommu_group_get_for_dev

2020-05-01 Thread Will Deacon
On Thu, Apr 30, 2020 at 02:23:32PM +0200, Joerg Roedel wrote: > On Thu, Apr 30, 2020 at 01:17:53PM +0100, Will Deacon wrote: > > Thanks, not sure how I managed to screw this up in the original patch! > > > > Acked-by: Will Deacon > > > > Joerg -- can you pick this one up please? > > Yes, will