RE: [PATCH 2/2] iommu/ipmmu-vmsa: Add support for R-Car Gen4

2022-02-02 Thread Yoshihiro Shimoda
Hi Geert-san, > From: Geert Uytterhoeven, Sent: Wednesday, February 2, 2022 8:07 PM > > Hi Shimoda-san, > > On Wed, Feb 2, 2022 at 11:48 AM Yoshihiro Shimoda > wrote: > > > From: Geert Uytterhoeven, Sent: Wednesday, February 2, 2022 6:24 PM > > > On Tue, Jan 25, 2022 at 6:36 PM Yoshihiro

Re: iommu/amd: bug report: page table memory leak

2022-02-02 Thread Daniel Jordan
Friendly ping. Any thoughts about this report? thanks, Daniel On Tue, Jan 18, 2022 at 02:47:20PM -0500, Daniel Jordan wrote: > Hi, > > I've hit a memory leak while testing qemu v6.2.0-rc4 on an AMD EPYC 7J13 > (Milan) system. Starting an almost 1T guest, the leak is over 1.5G per > qemu

RE: [PATCH] Netvsc: Call hv_unmap_memory() in the netvsc_device_remove()

2022-02-02 Thread Michael Kelley (LINUX) via iommu
From: Tianyu Lan Sent: Tuesday, February 1, 2022 8:32 AM > > netvsc_device_remove() calls vunmap() inside which should not be > called in the interrupt context. Current code calls hv_unmap_memory() > in the free_netvsc_device() which is rcu callback and maybe called > in the interrupt context.

Re: [PATCH v4 3/7] mm: page_isolation: check specified range for unmovable pages

2022-02-02 Thread Oscar Salvador
On Wed, Feb 02, 2022 at 01:25:28PM +0100, David Hildenbrand wrote: > That's the whole idea for being able to allocate parts of an unmovable > pageblock that are movable. > > If the first part is unmovable but the second part is movable, nothing > should stop us from trying to allocate the second

Re: [PATCH v4 3/7] mm: page_isolation: check specified range for unmovable pages

2022-02-02 Thread Zi Yan via iommu
On 2 Feb 2022, at 7:25, David Hildenbrand wrote: > On 02.02.22 13:18, Oscar Salvador wrote: >> On Wed, Jan 19, 2022 at 02:06:19PM -0500, Zi Yan wrote: >>> From: Zi Yan >>> >>> Enable set_migratetype_isolate() to check specified sub-range for >>> unmovable pages during isolation. Page isolation

Re: [PATCH 0/2] x86/hyperv/Swiotlb: Add swiotlb_alloc_from_low_pages switch

2022-02-02 Thread Tianyu Lan
On 2/2/2022 4:12 PM, Christoph Hellwig wrote: I think this interface is a little too hacky. In the end all the non-trusted hypervisor schemes (including the per-device swiotlb one) can allocate the memory from everywhere and want for force use of swiotlb. I think we need some kind of proper

Re: [PATCH] iommu/vt-d: Remove comment reference to iommu_dev_has_feature

2022-02-02 Thread Christoph Hellwig
Looks good: Reviewed-by: Christoph Hellwig ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH 0/2] x86/hyperv/Swiotlb: Add swiotlb_alloc_from_low_pages switch

2022-02-02 Thread Robin Murphy
On 2022-02-02 08:12, Christoph Hellwig wrote: I think this interface is a little too hacky. In the end all the non-trusted hypervisor schemes (including the per-device swiotlb one) can allocate the memory from everywhere and want for force use of swiotlb. I think we need some kind of proper

Re: [PATCH v4 3/7] mm: page_isolation: check specified range for unmovable pages

2022-02-02 Thread David Hildenbrand
On 02.02.22 13:18, Oscar Salvador wrote: > On Wed, Jan 19, 2022 at 02:06:19PM -0500, Zi Yan wrote: >> From: Zi Yan >> >> Enable set_migratetype_isolate() to check specified sub-range for >> unmovable pages during isolation. Page isolation is done >> at max(MAX_ORDER_NR_PAEGS, pageblock_nr_pages)

Re: [PATCH v4 3/7] mm: page_isolation: check specified range for unmovable pages

2022-02-02 Thread Oscar Salvador
On Wed, Jan 19, 2022 at 02:06:19PM -0500, Zi Yan wrote: > From: Zi Yan > > Enable set_migratetype_isolate() to check specified sub-range for > unmovable pages during isolation. Page isolation is done > at max(MAX_ORDER_NR_PAEGS, pageblock_nr_pages) granularity, but not all > pages within that

Re: [PATCH 2/2] iommu/ipmmu-vmsa: Add support for R-Car Gen4

2022-02-02 Thread Geert Uytterhoeven
Hi Shimoda-san, On Wed, Feb 2, 2022 at 11:48 AM Yoshihiro Shimoda wrote: > > From: Geert Uytterhoeven, Sent: Wednesday, February 2, 2022 6:24 PM > > On Tue, Jan 25, 2022 at 6:36 PM Yoshihiro Shimoda > > wrote: > > > Add support for R-Car Gen4 like r8a779f0 (R-Car S4-8). The IPMMU > > > hardware

RE: [PATCH 2/2] iommu/ipmmu-vmsa: Add support for R-Car Gen4

2022-02-02 Thread Yoshihiro Shimoda
Hi Geert-san, Thank you for your review! > From: Geert Uytterhoeven, Sent: Wednesday, February 2, 2022 6:24 PM > > Hi Shimoda-san, > > On Tue, Jan 25, 2022 at 6:36 PM Yoshihiro Shimoda > wrote: > > Add support for R-Car Gen4 like r8a779f0 (R-Car S4-8). The IPMMU > > hardware design of

Re: [PATCH 1/2] dt-bindings: iommu: renesas, ipmmu-vmsa: add r8a779f0 support

2022-02-02 Thread Geert Uytterhoeven
Hi Shimoda-san, On Fri, Jan 28, 2022 at 1:09 AM Yoshihiro Shimoda wrote: > > From: Geert Uytterhoeven, Sent: Thursday, January 27, 2022 8:06 PM > > > On Tue, Jan 25, 2022 at 6:33 PM Yoshihiro Shimoda > > wrote: > > > Document the compatible values for the IPMMU-VMSA blocks in > > > the Renesas

Re: [PATCH 2/2] iommu/ipmmu-vmsa: Add support for R-Car Gen4

2022-02-02 Thread Geert Uytterhoeven
Hi Shimoda-san, On Tue, Jan 25, 2022 at 6:36 PM Yoshihiro Shimoda wrote: > Add support for R-Car Gen4 like r8a779f0 (R-Car S4-8). The IPMMU > hardware design of r8a779f0 is the same as r8a779a0. So, rename > "r8a779a0" to "rcar_gen4". > > Signed-off-by: Yoshihiro Shimoda Thanks for your patch!

Re: [PATCH 0/2] x86/hyperv/Swiotlb: Add swiotlb_alloc_from_low_pages switch

2022-02-02 Thread Christoph Hellwig
I think this interface is a little too hacky. In the end all the non-trusted hypervisor schemes (including the per-device swiotlb one) can allocate the memory from everywhere and want for force use of swiotlb. I think we need some kind of proper interface for that instead of setting all kinds of