Re: [PATCH] iommu/vt-d: Add RPLS to quirk list to skip TE disabling

2022-02-25 Thread Lu Baolu
On 2/25/22 10:12 PM, Vivi, Rodrigo wrote: On Fri, 2022-02-25 at 10:20 +0800, Lu Baolu wrote: On 2/24/22 9:39 PM, Vivi, Rodrigo wrote: On Thu, 2022-02-24 at 13:42 +0800, Lu Baolu wrote: On 2/23/22 2:29 PM, Tejas Upadhyay wrote: The VT-d spec requires (10.4.4 Global Command Register, TE field)

Re: [PATCH v1 09/10] iommu/vt-d: Refactor dmar_insert_one_dev_info()

2022-02-25 Thread Jacob Pan
Hi BaoLu, On Mon, 7 Feb 2022 14:41:41 +0800, Lu Baolu wrote: > > - if (dev && domain_context_mapping(domain, dev)) { > - dev_err(dev, "Domain context map failed\n"); > - dmar_remove_one_dev_info(dev); > - return NULL; > - } > + /* Setup the cont

Re: [PATCH v5 00/12] x86: Trenchboot secure dynamic launch Linux kernel support

2022-02-25 Thread Daniel P. Smith
Hi Dave! Please find a response that will hopefully address the questions raised. The answers were meant to be thorough but succinct, though if there is any areas that are not clear for anyone, please feel free to ask. This response and any further questions for clarity will be incorporated into t

RE: [PATCH v8 03/11] ACPI/IORT: Add helper functions to parse RMR nodes

2022-02-25 Thread Shameerali Kolothum Thodi via iommu
> -Original Message- > From: Lorenzo Pieralisi [mailto:lorenzo.pieral...@arm.com] > Sent: 24 February 2022 10:14 > To: Shameerali Kolothum Thodi > Cc: linux-arm-ker...@lists.infradead.org; linux-a...@vger.kernel.org; > iommu@lists.linux-foundation.org; Linuxarm ; > j...@8bytes.org; robin

Re: cleanup swiotlb initialization

2022-02-25 Thread Boris Ostrovsky
On 2/25/22 3:47 AM, Christoph Hellwig wrote: On Thu, Feb 24, 2022 at 12:07:26PM -0500, Boris Ostrovsky wrote: Just to be clear: this crashes only as dom0. Boots fine as baremetal. Ah. I can gues what this might be. On Xen the hypervisor controls the IOMMU and we should never end up initiali

Re: [PATCH] iommu/arm-smmu: remove redundant assignment to variable res

2022-02-25 Thread Robin Murphy
On 2022-02-25 09:32, Colin Ian King wrote: The variable res is being assigned a value that isn't being read later. The assignment is redundant and can be removed. Cleans up clang scan warning: drivers/iommu/arm/arm-smmu/arm-smmu.c:2109:10: warning: Although the value stored to 'res' is used in t

Re: [PATCH V2 1/2] Swiotlb: Add swiotlb_alloc_from_low_pages switch

2022-02-25 Thread Tianyu Lan
On 2/23/2022 5:46 PM, Tianyu Lan wrote: On 2/23/2022 12:00 AM, Christoph Hellwig wrote: On Tue, Feb 22, 2022 at 11:07:19PM +0800, Tianyu Lan wrote: Thanks for your comment. That means we need to expose an swiotlb_device_init() interface to allocate bounce buffer and initialize io tlb mem entr

Re: [PATCH] iommu/vt-d: Add RPLS to quirk list to skip TE disabling

2022-02-25 Thread Vivi, Rodrigo
On Fri, 2022-02-25 at 10:20 +0800, Lu Baolu wrote: > On 2/24/22 9:39 PM, Vivi, Rodrigo wrote: > > On Thu, 2022-02-24 at 13:42 +0800, Lu Baolu wrote: > > > On 2/23/22 2:29 PM, Tejas Upadhyay wrote: > > > > The VT-d spec requires (10.4.4 Global Command Register, TE > > > > field) that: > > > > > > >

[PATCH] iommu/arm-smmu: remove redundant assignment to variable res

2022-02-25 Thread Colin Ian King
The variable res is being assigned a value that isn't being read later. The assignment is redundant and can be removed. Cleans up clang scan warning: drivers/iommu/arm/arm-smmu/arm-smmu.c:2109:10: warning: Although the value stored to 'res' is used in the enclosing expression, the value is never a

Re: [PATCH 22/23] video: omapfb: dss: Make use of the helper component_compare_dev

2022-02-25 Thread Greg Kroah-Hartman
On Tue, Feb 15, 2022 at 09:46:24PM +0100, Helge Deller wrote: > On 2/14/22 07:08, Yong Wu wrote: > > Use the common compare helper from component. > > > > Cc: Helge Deller > > Cc: linux-o...@vger.kernel.org > > Cc: linux-fb...@vger.kernel.org > > Signed-off-by: Yong Wu > > Applied to the fbdev f

Re: cleanup swiotlb initialization

2022-02-25 Thread Christoph Hellwig
On Thu, Feb 24, 2022 at 12:07:26PM -0500, Boris Ostrovsky wrote: >>> Just to be clear: this crashes only as dom0. Boots fine as baremetal. >> Ah. I can gues what this might be. On Xen the hypervisor controls the >> IOMMU and we should never end up initializing it in Linux, right? > > > Right, we