Re: [PATCH v1 16/16] arm64: dts: mt8195: Add display node for vdosys0

2022-07-04 Thread AngeloGioacchino Del Regno
Il 04/07/22 12:00, Tinghan Shen ha scritto: From: "Jason-JH.Lin" Add display node for vdosys0 of mt8195. Signed-off-by: Jason-JH.Lin Signed-off-by: Tinghan Shen --- arch/arm64/boot/dts/mediatek/mt8195.dtsi | 109 +++ 1 file changed, 109 insertions(+) diff --git a/arch

Re: [PATCH v1 06/16] arm64: dts: mt8195: Add cpufreq node

2022-07-04 Thread AngeloGioacchino Del Regno
Il 04/07/22 12:00, Tinghan Shen ha scritto: From: YT Lee Add cpufreq node for mt8195. Signed-off-by: YT Lee Signed-off-by: Tinghan Shen Reviewed-by: AngeloGioacchino Del Regno ___ iommu mailing list iommu@lists.linux-foundation.org https

Re: [PATCH v1 07/16] arm64: dts: mt8195: Add vdosys and vppsys clock nodes

2022-07-04 Thread AngeloGioacchino Del Regno
Il 04/07/22 12:00, Tinghan Shen ha scritto: Add display clock nodes. Signed-off-by: Tinghan Shen Reviewed-by: AngeloGioacchino Del Regno ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo

Re: [PATCH v1 08/16] arm64: dts: mt8195: Add power domains controller

2022-07-04 Thread AngeloGioacchino Del Regno
Il 04/07/22 12:00, Tinghan Shen ha scritto: Add power domains controller node for mt8195. Signed-off-by: Weiyi Lu Signed-off-by: Tinghan Shen Reviewed-by: AngeloGioacchino Del Regno ___ iommu mailing list iommu@lists.linux-foundation.org https

Re: [PATCH v1 09/16] arm64: dts: mt8195: Add spmi node

2022-07-04 Thread AngeloGioacchino Del Regno
Il 04/07/22 12:00, Tinghan Shen ha scritto: Add spmi node to mt8195. Signed-off-by: Henry Chen Signed-off-by: Tinghan Shen Reviewed-by: AngeloGioacchino Del Regno ___ iommu mailing list iommu@lists.linux-foundation.org https

Re: [PATCH v1 10/16] arm64: dts: mt8195: Add scp node

2022-07-04 Thread AngeloGioacchino Del Regno
Il 04/07/22 12:00, Tinghan Shen ha scritto: Add scp node for mt8195. Signed-off-by: Tinghan Shen Reviewed-by: AngeloGioacchino Del Regno ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo

Re: [PATCH v1 15/16] arm64: dts: mt8195: Add gce node

2022-07-04 Thread AngeloGioacchino Del Regno
Il 04/07/22 12:00, Tinghan Shen ha scritto: From: "Jason-JH.Lin" Add gce node and gce alias to mt8195 device tree. Signed-off-by: Jason-JH.Lin Signed-off-by: Tinghan Shen Reviewed-by: AngeloGioacchino Del Regno ___ iommu mailing

Re: [PATCH v1 11/16] arm64: dts: mt8195: Add audio related nodes

2022-07-04 Thread AngeloGioacchino Del Regno
Il 04/07/22 12:00, Tinghan Shen ha scritto: Add audio related nodes for mt8195. Signed-off-by: Trevor Wu Signed-off-by: Tinghan Shen Reviewed-by: AngeloGioacchino Del Regno ___ iommu mailing list iommu@lists.linux-foundation.org https

Re: [PATCH v1 14/16] arm64: dts: mt8195: Add iommu and smi nodes

2022-07-04 Thread AngeloGioacchino Del Regno
Il 04/07/22 12:00, Tinghan Shen ha scritto: Add iommu nodes and smi nodes for mt8195. Signed-off-by: Yong Wu Signed-off-by: Tinghan Shen Reviewed-by: AngeloGioacchino Del Regno ___ iommu mailing list iommu@lists.linux-foundation.org https

Re: [PATCH v1 13/16] arm64: dts: mt8195: Specify audio reset controller

2022-07-04 Thread AngeloGioacchino Del Regno
Il 04/07/22 12:00, Tinghan Shen ha scritto: From: Trevor Wu Specify audio reset controller for audio hardware resetting. Signed-off-by: Trevor Wu Signed-off-by: Tinghan Shen Reviewed-by: AngeloGioacchino Del Regno ___ iommu mailing list iommu

Re: [PATCH v1 05/16] arm64: dts: mt8195: Disable I2C0 node

2022-07-04 Thread AngeloGioacchino Del Regno
Il 04/07/22 12:00, Tinghan Shen ha scritto: From: Tzung-Bi Shih The I2C0 node doesn't need to be enabled in dtsi. "The I2C0 node should not be enabled globally, as usage is board dependant: disable it in dtsi." after which... Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v1 04/16] arm64: dts: mt8195: Disable watchdog external reset signal

2022-07-04 Thread AngeloGioacchino Del Regno
in the watchdog registers" After which: Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Fengquan Chen Signed-off-by: Tinghan Shen --- arch/arm64/boot/dts/mediatek/mt8195.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b

Re: [PATCH v1 02/16] dt-bindings: memory: mediatek: Update condition for mt8195 smi node

2022-07-04 Thread AngeloGioacchino Del Regno
Il 04/07/22 12:00, Tinghan Shen ha scritto: The max clock items for the dts node with compatible 'mediatek,mt8195-smi-sub-common' should be 3. However, the dtbs_check of such node will get following message, arch/arm64/boot/dts/mediatek/mt8195-evb.dtb: smi@1401: clock-names: ['apb', 'smi',

[PATCH v4 3/3] iommu/mediatek: Add support for MT6795 Helio X10 M4Us

2022-06-24 Thread AngeloGioacchino Del Regno
Add support for the M4Us found in the MT6795 Helio X10 SoC. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Yong Wu --- drivers/iommu/mtk_iommu.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c index

[PATCH v4 0/3] MediaTek Helio X10 MT6795 - M4U/IOMMU Support

2022-06-24 Thread AngeloGioacchino Del Regno
nges in v3: - Added new flag as suggested by Yong Wu - Rebased on top of https://patchwork.kernel.org/project/linux-mediatek/list/?series=648784 Changes in v2: - Rebased on top of https://patchwork.kernel.org/project/linux-mediatek/list/?series=642681 AngeloGioacchino Del Regno (3): dt-bindings

[PATCH v4 2/3] iommu/mediatek: Introduce new flag TF_PORT_TO_ADDR_MT8173

2022-06-24 Thread AngeloGioacchino Del Regno
In preparation for adding support for MT6795, add a new flag named TF_PORT_TO_ADDR_MT8173 and use that instead of checking for m4u_plat type in mtk_iommu_hw_init() to avoid seeing a long list of m4u_plat checks there in the future. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Yong Wu

[PATCH v4 1/3] dt-bindings: mediatek: Add bindings for MT6795 M4U

2022-06-24 Thread AngeloGioacchino Del Regno
Add bindings for the MediaTek Helio X10 (MT6795) IOMMU/M4U. Signed-off-by: AngeloGioacchino Del Regno Acked-by: Rob Herring --- .../bindings/iommu/mediatek,iommu.yaml| 4 + include/dt-bindings/memory/mt6795-larb-port.h | 95 +++ 2 files changed, 99 insertions

Re: [PATCH v2 5/5] iommu/mediatek: Remove a unused "mapping" which is only for v1

2022-06-16 Thread AngeloGioacchino Del Regno
apping, not a struct member... Perhaps... iommu/mediatek: Remove unused "mapping" member from mtk_iommu_data ? After clarifying the commit title: Reviewed-by: AngeloGioacchino Del Regno Cheers, Angelo ___ iommu mailing list iommu@li

[PATCH v4 5/5] iommu/mediatek: Cleanup pericfg lookup flow

2022-06-16 Thread AngeloGioacchino Del Regno
Since only the INFRA type IOMMU needs to modify register(s) in the pericfg iospace, it's safe to drop the pericfg_comp_str NULL check; also, directly assign the regmap handle to data->pericfg instead of to the infracfg variable to improve code readability. Signed-off-by: AngeloGioacc

[PATCH v4 2/5] iommu/mediatek: Lookup phandle to retrieve syscon to infracfg

2022-06-16 Thread AngeloGioacchino Del Regno
g" phandle. In order to keep retrocompatibility with older devicetrees, the old way is kept in place. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Miles Chen Reviewed-by: Yong Wu Reviewed-by: Matthias Brugger --- drivers/iommu/mtk_iommu.c | 38 ---

[PATCH v4 4/5] arm64: dts: mediatek: mt2712e: Add mediatek, infracfg phandle for IOMMU

2022-06-16 Thread AngeloGioacchino Del Regno
ht phandle to mediatek,infracfg in the iommu node. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Miles Chen --- arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi b/arch/arm64/boot/dts/mediatek/mt

[PATCH v4 3/5] arm64: dts: mediatek: mt8173: Add mediatek, infracfg phandle for IOMMU

2022-06-16 Thread AngeloGioacchino Del Regno
ht phandle to mediatek,infracfg in the iommu node. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Miles Chen --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.

[PATCH v4 1/5] dt-bindings: iommu: mediatek: Add mediatek, infracfg phandle

2022-06-16 Thread AngeloGioacchino Del Regno
Add property "mediatek,infracfg" to let the mtk_iommu driver retrieve a phandle to the infracfg syscon instead of performing a per-soc compatible lookup in the entire devicetree and set it as a required property for MT2712 and MT8173. Signed-off-by: AngeloGioacchino Del Regno --- ..

[PATCH v4 0/5] mtk_iommu: Specify phandles to infracfg and pericfg

2022-06-16 Thread AngeloGioacchino Del Regno
!) - Removed legacy devicetree print Changes in v2: - Squashed dt-bindings patches as suggested by Matthias - Removed quotes from infra/peri phandle refs - Changed dev_warn to dev_info in patches [2/7], [3/7] AngeloGioacchino Del Regno (5): dt-bindings: iommu: mediatek: Add mediatek,infracfg

Re: [PATCH v3 6/6] iommu: mtk_iommu: Lookup phandle to retrieve syscon to pericfg

2022-06-16 Thread AngeloGioacchino Del Regno
Il 16/06/22 08:30, Yong Wu ha scritto: On Mon, 2022-06-13 at 10:13 +0200, AngeloGioacchino Del Regno wrote: Il 13/06/22 07:32, Yong Wu ha scritto: On Thu, 2022-06-09 at 12:08 +0200, AngeloGioacchino Del Regno wrote: On some SoCs (of which only MT8195 is supported at the time of writing), the

Re: [PATCH v3 6/6] iommu: mtk_iommu: Lookup phandle to retrieve syscon to pericfg

2022-06-15 Thread AngeloGioacchino Del Regno
Il 15/06/22 14:09, Matthias Brugger ha scritto: On 09/06/2022 12:08, AngeloGioacchino Del Regno wrote: On some SoCs (of which only MT8195 is supported at the time of writing), the "R" and "W" (I/O) enable bits for the IOMMUs are in the pericfg_ao register space and not in

Re: [PATCH v3 6/6] iommu: mtk_iommu: Lookup phandle to retrieve syscon to pericfg

2022-06-13 Thread AngeloGioacchino Del Regno
Il 13/06/22 07:32, Yong Wu ha scritto: On Thu, 2022-06-09 at 12:08 +0200, AngeloGioacchino Del Regno wrote: On some SoCs (of which only MT8195 is supported at the time of writing), the "R" and "W" (I/O) enable bits for the IOMMUs are in the pericfg_ao register space and no

[PATCH v3 1/3] dt-bindings: mediatek: Add bindings for MT6795 M4U

2022-06-09 Thread AngeloGioacchino Del Regno
Add bindings for the MediaTek Helio X10 (MT6795) IOMMU/M4U. Signed-off-by: AngeloGioacchino Del Regno Acked-by: Rob Herring --- .../bindings/iommu/mediatek,iommu.yaml| 4 + include/dt-bindings/memory/mt6795-larb-port.h | 96 +++ 2 files changed, 100 insertions

[PATCH v3 3/3] iommu: mtk_iommu: Add support for MT6795 Helio X10 M4Us

2022-06-09 Thread AngeloGioacchino Del Regno
Add support for the M4Us found in the MT6795 Helio X10 SoC. Signed-off-by: AngeloGioacchino Del Regno --- drivers/iommu/mtk_iommu.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c index 8611cf8e4bd5..beca1c5a6c10 100644

[PATCH v3 2/3] iommu: mtk_iommu: Introduce new flag TF_PORT_TO_ADDR_MT8173

2022-06-09 Thread AngeloGioacchino Del Regno
In preparation for adding support for MT6795, add a new flag named TF_PORT_TO_ADDR_MT8173 and use that instead of checking for m4u_plat type in mtk_iommu_hw_init() to avoid seeing a long list of m4u_plat checks there in the future. Signed-off-by: AngeloGioacchino Del Regno --- drivers/iommu

[PATCH v3 0/3] MediaTek Helio X10 MT6795 - M4U/IOMMU Support

2022-06-09 Thread AngeloGioacchino Del Regno
st/?series=642681 AngeloGioacchino Del Regno (3): dt-bindings: mediatek: Add bindings for MT6795 M4U iommu: mtk_iommu: Introduce new flag TF_PORT_TO_ADDR_MT8173 iommu: mtk_iommu: Add support for MT6795 Helio X10 M4Us .../bindings/iommu/mediatek,iommu.yaml| 4 + drivers/iommu/m

[PATCH v3 5/6] dt-bindings: iommu: mediatek: Add mediatek, pericfg phandle

2022-06-09 Thread AngeloGioacchino Del Regno
Add property "mediatek,pericfg" to let the mtk_iommu driver retrieve a phandle to the infracfg syscon instead of performing a per-soc compatible lookup in the entire devicetree and set it as a required property for MT8195's infra IOMMU. Signed-off-by: AngeloGioac

[PATCH v3 2/6] iommu: mtk_iommu: Lookup phandle to retrieve syscon to infracfg

2022-06-09 Thread AngeloGioacchino Del Regno
g" phandle. In order to keep retrocompatibility with older devicetrees, the old way is kept in place. Signed-off-by: AngeloGioacchino Del Regno --- drivers/iommu/mtk_iommu.c | 38 -- 1 file changed, 24 insertions(+), 14 deletions(-) diff --git

[PATCH v3 6/6] iommu: mtk_iommu: Lookup phandle to retrieve syscon to pericfg

2022-06-09 Thread AngeloGioacchino Del Regno
f specifying pericfg compatibles on a per-SoC basis, following what was done with infracfg, let's lookup the syscon by phandle instead. Signed-off-by: AngeloGioacchino Del Regno --- drivers/iommu/mtk_iommu.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) d

[PATCH v3 3/6] arm64: dts: mediatek: mt8173: Add mediatek, infracfg phandle for IOMMU

2022-06-09 Thread AngeloGioacchino Del Regno
ht phandle to mediatek,infracfg in the iommu node. Signed-off-by: AngeloGioacchino Del Regno --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index 40d7b47fc52e..82

[PATCH v3 4/6] arm64: dts: mediatek: mt2712e: Add mediatek, infracfg phandle for IOMMU

2022-06-09 Thread AngeloGioacchino Del Regno
ht phandle to mediatek,infracfg in the iommu node. Signed-off-by: AngeloGioacchino Del Regno --- arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi index 62

[PATCH v3 1/6] dt-bindings: iommu: mediatek: Add mediatek, infracfg phandle

2022-06-09 Thread AngeloGioacchino Del Regno
Add property "mediatek,infracfg" to let the mtk_iommu driver retrieve a phandle to the infracfg syscon instead of performing a per-soc compatible lookup in the entire devicetree and set it as a required property for MT2712 and MT8173. Signed-off-by: AngeloGioacchino Del Regno --- ..

[PATCH v3 0/6] mtk_iommu: Specify phandles to infracfg and pericfg

2022-06-09 Thread AngeloGioacchino Del Regno
to dev_info in patches [2/7], [3/7] AngeloGioacchino Del Regno (6): dt-bindings: iommu: mediatek: Add mediatek,infracfg phandle iommu: mtk_iommu: Lookup phandle to retrieve syscon to infracfg arm64: dts: mediatek: mt8173: Add mediatek,infracfg phandle for IOMMU arm64: dts: mediatek

Re: [PATCH 2/6] iommu/qcom: Write TCR before TTBRs to fix ASID access behavior

2022-06-08 Thread AngeloGioacchino Del Regno
Il 08/06/22 12:54, Robin Murphy ha scritto: On 2022-06-08 11:27, AngeloGioacchino Del Regno wrote: Il 06/06/22 00:06, Marijn Suijten ha scritto: On 2022-05-31 16:55:59, Will Deacon wrote: On Fri, May 27, 2022 at 11:28:57PM +0200, Konrad Dybcio wrote: From: AngeloGioacchino Del Regno As

Re: [PATCH 2/6] iommu/qcom: Write TCR before TTBRs to fix ASID access behavior

2022-06-08 Thread AngeloGioacchino Del Regno
Il 06/06/22 00:06, Marijn Suijten ha scritto: On 2022-05-31 16:55:59, Will Deacon wrote: On Fri, May 27, 2022 at 11:28:57PM +0200, Konrad Dybcio wrote: From: AngeloGioacchino Del Regno As also stated in the arm-smmu driver, we must write the TCR before writing the TTBRs, since the TCR

Re: [PATCH 1/6] iommu/qcom: Use the asid read from device-tree if specified

2022-06-08 Thread AngeloGioacchino Del Regno
, Konrad Dybcio wrote: From: AngeloGioacchino Del Regno As specified in this driver, the context banks are 0x1000 apart. Problem is that sometimes the context number (our asid) does not match this logic and we end up using the wrong one: this starts being a problem in the case that we need to send

Re: [PATCH v2 1/7] dt-bindings: iommu: mediatek: Add phandles for mediatek infra/pericfg

2022-05-18 Thread AngeloGioacchino Del Regno
Il 18/05/22 13:29, Matthias Brugger ha scritto: On 18/05/2022 12:04, AngeloGioacchino Del Regno wrote: Add properties "mediatek,infracfg" and "mediatek,pericfg" to let the mtk_iommu driver retrieve phandles to the infracfg and pericfg syscon(s) instead of performing

[PATCH v2 1/2] dt-bindings: mediatek: Add bindings for MT6795 M4U

2022-05-18 Thread AngeloGioacchino Del Regno
Add bindings for the MediaTek Helio X10 (MT6795) IOMMU/M4U. Signed-off-by: AngeloGioacchino Del Regno --- .../bindings/iommu/mediatek,iommu.yaml| 4 + include/dt-bindings/memory/mt6795-larb-port.h | 96 +++ 2 files changed, 100 insertions(+) create mode 100644 include

[PATCH v2 2/2] iommu: mtk_iommu: Add support for MT6795 Helio X10 M4Us

2022-05-18 Thread AngeloGioacchino Del Regno
Add support for the M4Us found in the MT6795 Helio X10 SoC. Signed-off-by: AngeloGioacchino Del Regno --- drivers/iommu/mtk_iommu.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c index 090cf6e15f85

[PATCH v2 0/2] MediaTek Helio X10 MT6795 - M4U/IOMMU Support

2022-05-18 Thread AngeloGioacchino Del Regno
Xperia M5 (codename "Holly") smartphone. Changes in v2: - Rebased on top of https://patchwork.kernel.org/project/linux-mediatek/list/?series=642681 AngeloGioacchino Del Regno (2): dt-bindings: mediatek: Add bindings for MT6795 M4U iommu: mtk_iommu: Add support for MT6795 Heli

[PATCH v2 6/7] dt-bindings: iommu: mediatek: Require mediatek, infracfg for mt2712/8173

2022-05-18 Thread AngeloGioacchino Del Regno
Both MT2712 and MT8173 got a mediatek,infracfg phandle: add that to the required properties for these SoCs to deprecate the old way of looking for SoC-specific infracfg compatible in the entire devicetree. Signed-off-by: AngeloGioacchino Del Regno Acked-by: Rob Herring --- .../devicetree

[PATCH v2 3/7] iommu: mtk_iommu: Lookup phandle to retrieve syscon to pericfg

2022-05-18 Thread AngeloGioacchino Del Regno
f specifying pericfg compatibles on a per-SoC basis, following what was done with infracfg, let's lookup the syscon by phandle instead. Also following the previous infracfg change, add a warning for outdated devicetrees, in hope that the user will take action. Signed-off-by: AngeloGioacchino

[PATCH v2 2/7] iommu: mtk_iommu: Lookup phandle to retrieve syscon to infracfg

2022-05-18 Thread AngeloGioacchino Del Regno
g" phandle. In order to keep retrocompatibility with older devicetrees, the old way is kept in place, but also a dev_warn() was added to advertise this change in hope that the user will see it and eventually update the devicetree if this is possible. Signed-off-by: AngeloGioacchino Del Regno

[PATCH v2 0/7] mtk_iommu: Specify phandles to infracfg and pericfg

2022-05-18 Thread AngeloGioacchino Del Regno
there is no IOMMU node in there yet. Changes in v2: - Squashed dt-bindings patches as suggested by Matthias - Removed quotes from infra/peri phandle refs - Changed dev_warn to dev_info in patches [2/7], [3/7] AngeloGioacchino Del Regno (7): dt-bindings: iommu: mediatek: Add phandles for mediatek

[PATCH v2 4/7] arm64: dts: mediatek: mt8173: Add mediatek, infracfg phandle for IOMMU

2022-05-18 Thread AngeloGioacchino Del Regno
ht phandle to mediatek,infracfg in the iommu node. Signed-off-by: AngeloGioacchino Del Regno --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index 40d7b47fc52e..82

[PATCH v2 5/7] arm64: dts: mediatek: mt2712e: Add mediatek, infracfg phandle for IOMMU

2022-05-18 Thread AngeloGioacchino Del Regno
ht phandle to mediatek,infracfg in the iommu node. Signed-off-by: AngeloGioacchino Del Regno --- arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi index 62

[PATCH v2 7/7] dt-bindings: iommu: mediatek: Require mediatek, pericfg for mt8195-infra

2022-05-18 Thread AngeloGioacchino Del Regno
The MT8195 SoC has IOMMU related registers in the pericfg_ao iospace: require a phandle to that. Signed-off-by: AngeloGioacchino Del Regno Acked-by: Rob Herring --- .../devicetree/bindings/iommu/mediatek,iommu.yaml | 10 ++ 1 file changed, 10 insertions(+) diff --git a

[PATCH v2 1/7] dt-bindings: iommu: mediatek: Add phandles for mediatek infra/pericfg

2022-05-18 Thread AngeloGioacchino Del Regno
Add properties "mediatek,infracfg" and "mediatek,pericfg" to let the mtk_iommu driver retrieve phandles to the infracfg and pericfg syscon(s) instead of performing a per-soc compatible lookup. Signed-off-by: AngeloGioacchino Del Regno --- .../devicetree/bindings/iommu

Re: [PATCH 2/8] iommu: mtk_iommu: Lookup phandle to retrieve syscon to infracfg

2022-05-18 Thread AngeloGioacchino Del Regno
Il 17/05/22 16:12, Robin Murphy ha scritto: On 2022-05-17 14:21, AngeloGioacchino Del Regno wrote: This driver will get support for more SoCs and the list of infracfg compatibles is expected to grow: in order to prevent getting this situation out of control and see a long list of compatible

Re: [PATCH 7/8] dt-bindings: iommu: mediatek: Require mediatek,infracfg for mt2712/8173

2022-05-18 Thread AngeloGioacchino Del Regno
Il 18/05/22 03:41, Rob Herring ha scritto: On Tue, May 17, 2022 at 03:21:06PM +0200, AngeloGioacchino Del Regno wrote: Both MT2712 and MT8173 got a mediatek,infracfg phandle: add that to the required properties for these SoCs to deprecate the old way of looking for SoC-specific infracfg

[PATCH 8/8] dt-bindings: iommu: mediatek: Require mediatek, pericfg for mt8195-infra

2022-05-17 Thread AngeloGioacchino Del Regno
The MT8195 SoC has IOMMU related registers in the pericfg_ao iospace: require a phandle to that. Signed-off-by: AngeloGioacchino Del Regno --- Note for Rob: as of now, there's no iommu node in upstream mt8195 devicetrees yet. .../devicetree/bindings/iommu/mediatek,iommu.yaml

[PATCH 0/8] mtk_iommu: Specify phandles to infracfg and pericfg

2022-05-17 Thread AngeloGioacchino Del Regno
there is no IOMMU node in there yet. AngeloGioacchino Del Regno (8): dt-bindings: iommu: mediatek: Add mediatek,infracfg phandle iommu: mtk_iommu: Lookup phandle to retrieve syscon to infracfg dt-bindings: iommu: mediatek: Add mediatek,pericfg phandle iommu: mtk_iommu: Lookup phandle to

[PATCH 5/8] arm64: dts: mediatek: mt8173: Add mediatek, infracfg phandle for IOMMU

2022-05-17 Thread AngeloGioacchino Del Regno
ht phandle to mediatek,infracfg in the iommu node. Signed-off-by: AngeloGioacchino Del Regno --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index 40d7b47fc52e..82

[PATCH 1/8] dt-bindings: iommu: mediatek: Add mediatek, infracfg phandle

2022-05-17 Thread AngeloGioacchino Del Regno
Add property "mediatek,infracfg" to let the mtk_iommu driver retrieve a phandle to the infracfg syscon instead of performing a per-soc compatible lookup. Signed-off-by: AngeloGioacchino Del Regno --- Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml | 4 1 file

[PATCH 4/8] iommu: mtk_iommu: Lookup phandle to retrieve syscon to pericfg

2022-05-17 Thread AngeloGioacchino Del Regno
f specifying pericfg compatibles on a per-SoC basis, following what was done with infracfg, let's lookup the syscon by phandle instead. Also following the previous infracfg change, add a warning for outdated devicetrees, in hope that the user will take action. Signed-off-by: AngeloGioacchino

[PATCH 6/8] arm64: dts: mediatek: mt2712e: Add mediatek, infracfg phandle for IOMMU

2022-05-17 Thread AngeloGioacchino Del Regno
ht phandle to mediatek,infracfg in the iommu node. Signed-off-by: AngeloGioacchino Del Regno --- arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi index 62

[PATCH 2/8] iommu: mtk_iommu: Lookup phandle to retrieve syscon to infracfg

2022-05-17 Thread AngeloGioacchino Del Regno
g" phandle. In order to keep retrocompatibility with older devicetrees, the old way is kept in place, but also a dev_warn() was added to advertise this change in hope that the user will see it and eventually update the devicetree if this is possible. Signed-off-by: AngeloGioacchino Del Regno

[PATCH 3/8] dt-bindings: iommu: mediatek: Add mediatek, pericfg phandle

2022-05-17 Thread AngeloGioacchino Del Regno
Add property "mediatek,pericfg" to let the mtk_iommu driver retrieve a phandle to the pericfg syscon instead of performing a per-soc compatible lookup, as it was also done with infracfg. Signed-off-by: AngeloGioacchino Del Regno --- Documentation/devicetree/bindings/iommu/mediatek,

[PATCH 7/8] dt-bindings: iommu: mediatek: Require mediatek, infracfg for mt2712/8173

2022-05-17 Thread AngeloGioacchino Del Regno
Both MT2712 and MT8173 got a mediatek,infracfg phandle: add that to the required properties for these SoCs to deprecate the old way of looking for SoC-specific infracfg compatible in the entire devicetree. Signed-off-by: AngeloGioacchino Del Regno --- .../devicetree/bindings/iommu/mediatek

Re: [PATCH 1/2] dt-bindings: mediatek: Add bindings for MT6795 M4U

2022-05-17 Thread AngeloGioacchino Del Regno
Il 16/05/22 18:03, Rob Herring ha scritto: On Fri, 13 May 2022 17:14:10 +0200, AngeloGioacchino Del Regno wrote: Add bindings for the MediaTek Helio X10 (MT6795) IOMMU/M4U. Signed-off-by: AngeloGioacchino Del Regno --- .../bindings/iommu/mediatek,iommu.yaml| 3 + include/dt

Re: [PATCH 2/2] iommu: mtk_iommu: Add support for MT6795 Helio X10 M4Us

2022-05-17 Thread AngeloGioacchino Del Regno
Il 17/05/22 11:08, Yong Wu ha scritto: On Fri, 2022-05-13 at 17:14 +0200, AngeloGioacchino Del Regno wrote: Add support for the M4Us found in the MT6795 Helio X10 SoC. Signed-off-by: AngeloGioacchino Del Regno < angelogioacchino.delre...@collabora.com> --- drivers/iommu/mtk_iommu.

[PATCH 2/2] iommu: mtk_iommu: Add support for MT6795 Helio X10 M4Us

2022-05-13 Thread AngeloGioacchino Del Regno
Add support for the M4Us found in the MT6795 Helio X10 SoC. Signed-off-by: AngeloGioacchino Del Regno --- drivers/iommu/mtk_iommu.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c index 71b2ace74cd6

[PATCH 1/2] dt-bindings: mediatek: Add bindings for MT6795 M4U

2022-05-13 Thread AngeloGioacchino Del Regno
Add bindings for the MediaTek Helio X10 (MT6795) IOMMU/M4U. Signed-off-by: AngeloGioacchino Del Regno --- .../bindings/iommu/mediatek,iommu.yaml| 3 + include/dt-bindings/memory/mt6795-larb-port.h | 96 +++ 2 files changed, 99 insertions(+) create mode 100644 include

[PATCH 0/2] MediaTek Helio X10 MT6795 - M4U/IOMMU Support

2022-05-13 Thread AngeloGioacchino Del Regno
Xperia M5 (codename "Holly") smartphone. AngeloGioacchino Del Regno (2): dt-bindings: mediatek: Add bindings for MT6795 M4U iommu: mtk_iommu: Add support for MT6795 Helio X10 M4Us .../bindings/iommu/mediatek,iommu.yaml| 3 + drivers/iommu/mtk_iommu.c

Re: [PATCH 1/4] iommu/mediatek: Use dev_err_probe to mute probe_defer err log

2022-05-11 Thread AngeloGioacchino Del Regno
ned-off-by: Yong Wu Reviewed-by: AngeloGioacchino Del Regno ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH 3/4] iommu/mediatek: Validate number of phandles associated with "mediatek,larbs"

2022-05-11 Thread AngeloGioacchino Del Regno
ixes: d2e9a1102cfc ("iommu/mediatek: Contain MM IOMMU flow with the MM TYPE") Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Guenter Roeck Signed-off-by: Yong Wu Reviewed-by: AngeloGioacchino Del Regno ___ iommu

Re: [PATCH v3] iommu/mediatek: Fix NULL pointer dereference when printing dev_name

2022-05-05 Thread AngeloGioacchino Del Regno
hy Cc: Yong Wu Reported-by: kernel test robot Fixes: 635319a4a744 ("media: iommu/mediatek: Add device_link between the consumer and the larb devices") Signed-off-by: Miles Chen Reviewed-by: AngeloGioacchino Del Regno ___ iommu maili

Re: [PATCH v6 00/34] MT8195 IOMMU SUPPORT

2022-04-19 Thread AngeloGioacchino Del Regno
Il 07/04/22 09:56, Yong Wu ha scritto: This patchset adds MT8195 iommu support. Hello maintainers, This is a friendly ping to avoid forgetting about this fully reviewed and fully tested review. Cheers, Angelo MT8195 have 3 IOMMU HWs. 2 IOMMU HW is for multimedia, and 1 IOMMU HW is for infr

Re: [PATCH v3 2/2] iommu/mediatek: Add mt8186 iommu support

2022-04-07 Thread AngeloGioacchino Del Regno
Il 07/04/22 10:32, Yong Wu ha scritto: Add mt8186 iommu supports. Signed-off-by: Anan Sun Signed-off-by: Yong Wu Reviewed-by: Matthias Brugger Reviewed-by: AngeloGioacchino Del Regno ___ iommu mailing list iommu@lists.linux-foundation.org

Re: [PATCH v3 1/2] dt-bindings: mediatek: mt8186: Add binding for MM iommu

2022-04-07 Thread AngeloGioacchino Del Regno
Il 07/04/22 10:32, Yong Wu ha scritto: Add mt8186 iommu binding. "-mm" means the iommu is for Multimedia. Signed-off-by: Yong Wu Acked-by: Krzysztof Kozlowski Reviewed-by: Rob Herring Reviewed-by: Matthias Brugger Reviewed-by: AngeloGioacchino

Re: [PATCH v5 00/34] MT8195 IOMMU SUPPORT

2022-03-04 Thread AngeloGioacchino Del Regno
Il 04/03/22 11:05, Joerg Roedel ha scritto: On Fri, Mar 04, 2022 at 05:57:19PM +0800, Yong Wu wrote: Thanks for this info. I will re-send this patchset after the next -rc1. Could you help apply Dafna's patchset at this time? This patchset depends on it and it won't conflict with the others. A

Re: [PATCH v5 00/34] MT8195 IOMMU SUPPORT

2022-02-28 Thread AngeloGioacchino Del Regno
Il 28/02/22 13:34, Joerg Roedel ha scritto: Hi Yong Wu, On Thu, Feb 17, 2022 at 07:34:19PM +0800, Yong Wu wrote: Yong Wu (34): dt-bindings: mediatek: mt8195: Add binding for MM IOMMU dt-bindings: mediatek: mt8195: Add binding for infra IOMMU iommu/mediatek: Fix 2 HW sharing pgtable iss

Re: [PATCH v5 27/34] iommu/mediatek-v1: Just rename mtk_iommu to mtk_iommu_v1

2022-02-18 Thread AngeloGioacchino Del Regno
Il 17/02/22 12:34, Yong Wu ha scritto: No functional change. Just rename this for readable. Differentiate this from mtk_iommu.c Signed-off-by: Yong Wu Reviewed-by: AngeloGioacchino Del Regno --- drivers/iommu/mtk_iommu_v1.c | 211 +-- 1 file changed

Re: [PATCH v5 32/34] iommu/mediatek: Initialise/Remove for multi bank dev

2022-02-18 Thread AngeloGioacchino Del Regno
ys all the banks are initialised, it depend on if there is masters for that bank. Signed-off-by: Yong Wu Reviewed-by: AngeloGioacchino Del Regno ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v5 26/34] iommu/mediatek: Remove mtk_iommu.h

2022-02-18 Thread AngeloGioacchino Del Regno
release_of. There is many copy in drm, it should be another topic. Signed-off-by: Yong Wu Reviewed-by: AngeloGioacchino Del Regno --- drivers/iommu/mtk_iommu.c| 25 - drivers/iommu/mtk_iommu.h| 42 drivers/iommu

Re: [PATCH v5 25/34] iommu/mediatek: Separate mtk_iommu_data for v1 and v2

2022-02-18 Thread AngeloGioacchino Del Regno
r to avoid affect v1 when we add many new features for v2, I totally separate v1 and v2 in this patch, there are many structures only for v2. Signed-off-by: Yong Wu Reviewed-by: AngeloGioacchino Del Regno --- drivers/iommu/mtk_iommu.c| 82 +--- dri

Re: [PATCH v5 21/34] iommu/mediatek: Add PCIe support

2022-02-18 Thread AngeloGioacchino Del Regno
ned-off-by: Yong Wu Reviewed-by: AngeloGioacchino Del Regno ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v5 19/34] iommu/mediatek: Add a PM_CLK_AO flag for infra iommu

2022-02-18 Thread AngeloGioacchino Del Regno
this file, Comment them in the code here. Signed-off-by: Yong Wu Reviewed-by: AngeloGioacchino Del Regno ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH 2/2] iommu/mediatek: Add mt8186 iommu support

2022-02-18 Thread AngeloGioacchino Del Regno
Il 18/02/22 04:32, Yong Wu ha scritto: On Mon, 2022-01-31 at 10:25 +0100, AngeloGioacchino Del Regno wrote: Il 28/01/22 10:39, Yong Wu ha scritto: On Thu, 2022-01-27 at 12:28 +0100, AngeloGioacchino Del Regno wrote: Il 25/01/22 10:32, Yong Wu ha scritto: Add mt8186 iommu supports. Signed

Re: [PATCH 20/23] ASoC: codecs: wcd938x: Make use of the helper component_compare/release_of

2022-02-14 Thread AngeloGioacchino Del Regno
Il 14/02/22 13:40, Mark Brown ha scritto: On Mon, Feb 14, 2022 at 02:08:16PM +0800, Yong Wu wrote: Use the common compare/release helpers from component. What's the story with dependencies here? I've just got this one patch with no cover letter... Hello Mark, I agree, the cover letter shoul

Re: [PATCH 2/2] iommu/mediatek: Add mt8186 iommu support

2022-01-31 Thread AngeloGioacchino Del Regno
Il 28/01/22 10:39, Yong Wu ha scritto: On Thu, 2022-01-27 at 12:28 +0100, AngeloGioacchino Del Regno wrote: Il 25/01/22 10:32, Yong Wu ha scritto: Add mt8186 iommu supports. Signed-off-by: Anan Sun Signed-off-by: Yong Wu --- drivers/iommu/mtk_iommu.c | 17 + 1 file

Re: [PATCH 2/2] iommu/mediatek: Add mt8186 iommu support

2022-01-27 Thread AngeloGioacchino Del Regno
Il 25/01/22 10:32, Yong Wu ha scritto: Add mt8186 iommu supports. Signed-off-by: Anan Sun Signed-off-by: Yong Wu --- drivers/iommu/mtk_iommu.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c index be36e73e4bcc..a31

Re: [PATCH v4 35/35] iommu/mediatek: mt8195: Enable multi banks for infra iommu

2022-01-27 Thread AngeloGioacchino Del Regno
Il 25/01/22 09:56, Yong Wu ha scritto: Enable the multi-bank functions for infra-iommu. We put PCIE in bank0 and USB in the last bank(bank4). and we don't use the other banks currently, disable them. Signed-off-by: Yong Wu Reviewed-by: AngeloGioacchino Del

Re: [PATCH v4 34/35] iommu/mediatek: Backup/restore regsiters for multi banks

2022-01-27 Thread AngeloGioacchino Del Regno
Il 25/01/22 09:56, Yong Wu ha scritto: Each bank has some independent registers. thus backup/restore them for each a bank when suspend and resume. Signed-off-by: Yong Wu Reviewed-by: AngeloGioacchino Del Regno ___ iommu mailing list iommu

Re: [PATCH v4 32/35] iommu/mediatek: Get the proper bankid for multi banks

2022-01-27 Thread AngeloGioacchino Del Regno
matter. In any case: Reviewed-by: AngeloGioacchino Del Regno ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v4 29/35] iommu/mediatek: Add mtk_iommu_bank_data structure

2022-01-27 Thread AngeloGioacchino Del Regno
: AngeloGioacchino Del Regno ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v4 27/35] iommu/mediatek: Remove mtk_iommu.h

2022-01-27 Thread AngeloGioacchino Del Regno
Il 25/01/22 09:56, Yong Wu ha scritto: Currently there is only compare_of/release_of/a suspend structure in the header file. I think it is no need to keep a header file only for these. Move these into the c file and rm this header file. I think there should be a common helper for compare_of and

Re: [PATCH v4 08/35] iommu/mediatek: Use kmalloc for protect buffer

2022-01-27 Thread AngeloGioacchino Del Regno
Il 25/01/22 09:56, Yong Wu ha scritto: No need zero for the protect buffer that is only accessed by the IOMMU HW translation fault happened. Signed-off-by: Yong Wu I would rather keep this a devm_kzalloc instead... the cost is very minimal and this will be handy when new hardware will be intr

Re: [PATCH v4 07/35] iommu/mediatek: Add mutex for data in the mtk_iommu_domain

2022-01-27 Thread AngeloGioacchino Del Regno
ngeloGioacchino Del Regno ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v4 06/35] iommu/mediatek: Add mutex for m4u_group and m4u_dom in data

2022-01-27 Thread AngeloGioacchino Del Regno
er propose: goto err_unlock; Apart from this, Reviewed-by: AngeloGioacchino Del Regno ret = mtk_iommu_hw_init(data); if (ret) { pm_runtime_put(m4udev); - return ret; + goto data_unl

Re: [PATCH v4 03/35] iommu/mediatek: Fix 2 HW sharing pgtable issue

2022-01-27 Thread AngeloGioacchino Del Regno
HW. Fix this for the sharing pgtable case. Only affect mt2712 which is the only SoC that share pgtable currently. Fixes: 4f956c97d26b ("iommu/mediatek: Move domain_finalise into attach_device") Signed-off-by: Yong Wu Reviewed-by: AngeloGioacchino Del Regno ___

Re: [PATCH v10 00/13] Clean up "mediatek,larb"

2022-01-17 Thread AngeloGioacchino Del Regno
Il 17/01/22 08:04, Yong Wu ha scritto: MediaTek IOMMU block diagram always like below: M4U | smi-common | - | | ... | | larb1 larb2 | | vdec venc All the consumer connect with smi-larb, then connect wit

Re: [PATCH v3 2/7] dt-bindings: memory: mtk-smi: No need mediatek,larb-id for mt8167

2022-01-13 Thread AngeloGioacchino Del Regno
OMMU, thus no need this property. Fixes: 27bb0e42855a ("dt-bindings: memory: mediatek: Convert SMI to DT schema") Signed-off-by: Yong Wu Acked-by: AngeloGioacchino Del Regno ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v3 3/7] dt-bindings: memory: mtk-smi: Correct minItems to 2 for the gals clocks

2022-01-13 Thread AngeloGioacchino Del Regno
then the minItems for clocks and clock-names are 2. Fixes: 27bb0e42855a ("dt-bindings: memory: mediatek: Convert SMI to DT schema") Signed-off-by: Yong Wu Reviewed-by: AngeloGioacchino Del Regno ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v3 4/7] dt-bindings: memory: mediatek: Add mt8186 support

2022-01-13 Thread AngeloGioacchino Del Regno
Il 13/01/22 12:10, Yong Wu ha scritto: Add mt8186 smi support in the bindings. Signed-off-by: Yong Wu Acked-by: Rob Herring Reviewed-by: AngeloGioacchino Del Regno ___ iommu mailing list iommu@lists.linux-foundation.org https

  1   2   >