Re: Regression 5.12.0-rc4 net: ice: significant throughput drop

2021-06-02 Thread Daniel Borkmann
On 6/1/21 7:42 PM, Jussi Maki wrote: Hi Robin, On Tue, Jun 1, 2021 at 2:39 PM Robin Murphy wrote: The regression shows as a significant drop in throughput as measured with "super_netperf" [0], with measured bandwidth of ~95Gbps before and ~35Gbps after: I guess that must be the difference be

Re: Regression 5.12.0-rc4 net: ice: significant throughput drop

2021-06-01 Thread Daniel Borkmann
[ ping Robin / Joerg, +Cc Christoph ] On 5/28/21 10:34 AM, Jussi Maki wrote: Hi all, While measuring the impact of a kernel patch on our lab machines I stumbled upon a performance regression affecting the 100Gbit ICE nic and bisected it from range v5.11.1..v5.13-rc3 to the commit: a250c23f15c2

Re: add an API to check if a streamming mapping needs sync calls

2020-07-08 Thread Daniel Borkmann
On 7/8/20 9:44 AM, Christoph Hellwig wrote: On Mon, Jun 29, 2020 at 03:39:01PM +0200, Björn Töpel wrote: On 2020-06-29 15:03, Christoph Hellwig wrote: Hi all, this series lifts the somewhat hacky checks in the XSK code if a DMA streaming mapping needs dma_sync_single_for_{device,cpu} calls to

Re: [PATCH net] xsk: remove cheap_dma optimization

2020-06-30 Thread Daniel Borkmann
On 6/30/20 7:07 AM, Christoph Hellwig wrote: On Mon, Jun 29, 2020 at 05:18:38PM +0200, Daniel Borkmann wrote: On 6/29/20 5:10 PM, Björn Töpel wrote: On 2020-06-29 15:52, Daniel Borkmann wrote: Ok, fair enough, please work with DMA folks to get this properly integrated and restored then

Re: [PATCH net] xsk: remove cheap_dma optimization

2020-06-29 Thread Daniel Borkmann
On 6/29/20 5:10 PM, Björn Töpel wrote: On 2020-06-29 15:52, Daniel Borkmann wrote: Ok, fair enough, please work with DMA folks to get this properly integrated and restored then. Applied, thanks! Daniel, you were too quick! Please revert this one; Christoph just submitted a 4-patch-series

Re: [PATCH net] xsk: remove cheap_dma optimization

2020-06-29 Thread Daniel Borkmann
On 6/28/20 7:16 PM, Björn Töpel wrote: On 2020-06-27 09:04, Christoph Hellwig wrote: On Sat, Jun 27, 2020 at 01:00:19AM +0200, Daniel Borkmann wrote: Given there is roughly a ~5 weeks window at max where this removal could still be applied in the worst case, could we come up with a fix

Re: [PATCH net] xsk: remove cheap_dma optimization

2020-06-26 Thread Daniel Borkmann
On 6/26/20 3:43 PM, Björn Töpel wrote: From: Björn Töpel When the AF_XDP buffer allocation API was introduced it had an optimization, "cheap_dma". The idea was that when the umem was DMA mapped, the pool also checked whether the mapping required a synchronization (CPU to device, and vice versa)